From patchwork Fri Nov 16 10:04:26 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Viresh Kumar X-Patchwork-Id: 151316 Delivered-To: patch@linaro.org Received: by 2002:a2e:299d:0:0:0:0:0 with SMTP id p29-v6csp228662ljp; Fri, 16 Nov 2018 02:05:03 -0800 (PST) X-Google-Smtp-Source: AJdET5cSmXF4x5HXaGTiDfycINQ2/dI/zDqxtai/XQrhXSgt2JHZFCP5Kv0tpNMTNcONmsLG218g X-Received: by 2002:a63:ea4f:: with SMTP id l15mr9146272pgk.102.1542362702968; Fri, 16 Nov 2018 02:05:02 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1542362702; cv=none; d=google.com; s=arc-20160816; b=KJTuqauE8TisZM8WJgTGzV6hkZPecogUQdAeB0AyA3X1aQKwEigiSS+4fFGoRoodvY AX2zfmMpVvBp0LqdFjT4vNcLXJjhIz9/oo3DGYSRT8Gv+lubJXc5e3VYCK0grRaDuQVH p4ovEGS/8B7++TSrw7rAiDD3Nw3UoSwOcV+UiyRf9B7zTtb+GlUO206J1vyVVPvldW6G WNOCqoOqhiivZFj+X01NJOl/RnRj0bALNjh+jC+6PuSlmyp0BbodvMvC1VlUWCt4Dh6w YLq4ZrIWfvepqC2NrhgAhV0CI1bnwYjuH01/yLfK04ObDsae3hqVBBOMyIS8fNdfKmlf r/7g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=oskLWY4mMeTJJ9TYoYBq3J1qg+P8pf5LnWRqIcwKGK8=; b=RTkIP7aW8IlwTuMwp5tvhMBfuA93hazL1vVYEnmH1HwgZdVRfBntdxdJAQZsQEsKKs bSyQEnMS8n/BKQL7/3tnnxeYq/XAKwDfGitR+xReAcmX/UhAvJICjZztuZX5df/8KPwA eDGWhhjrEQdR+f0ay+cOl/nw0mt/cDnbKnQr8ydNzeyhy4OwDsNKzkDbit6MWZBmGzMY KV8cQ5BNKn2bzYnvZYpQ4WsCIFg7dyPNkKb7DhzjRpiL9/T2d/yQ0tJRKOpJR2v06mlN AVTZQWsN5EudZgOVeGoQ1QA+Kk0MVe3OKyCsIEvflGPLAJKva+ffU/SIb7EjeqnJSj9v tuEg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=ATnBdGjg; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 12-v6si21132818plb.324.2018.11.16.02.05.02; Fri, 16 Nov 2018 02:05:02 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=ATnBdGjg; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389545AbeKPUQi (ORCPT + 32 others); Fri, 16 Nov 2018 15:16:38 -0500 Received: from mail-pf1-f193.google.com ([209.85.210.193]:40334 "EHLO mail-pf1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727543AbeKPUQh (ORCPT ); Fri, 16 Nov 2018 15:16:37 -0500 Received: by mail-pf1-f193.google.com with SMTP id x2-v6so11173015pfm.7 for ; Fri, 16 Nov 2018 02:05:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=oskLWY4mMeTJJ9TYoYBq3J1qg+P8pf5LnWRqIcwKGK8=; b=ATnBdGjgO7zh0Orx+cQY5HgoRJ4l9UbThujztH+bBaMJGHsFpCw1g+uMRsgziODVZb rbecT9tokiUQH9Sxkd6bI6PKhqIioXGKtsSJ80pXMCVb7cLjyKGLCWsapQGglk8SjHYz 3j+FQd43roFL2giLKateOQSrXnm4Je8L7ScME= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=oskLWY4mMeTJJ9TYoYBq3J1qg+P8pf5LnWRqIcwKGK8=; b=P7i5oihBJqiMvZwzlWpRJGMYKPocnFB8cg88Fqks9Qxw2jGTh6eZ7x5HB9YUEhTrw5 tSqL2jwyS05O2asc3RRTDjbmTLZe8/N1flqTmbdL813M+1zfbVUaY9fyjhh+7y8CxGKb SCRVFtICd18cjR++Wfs2F7CzEpRJ03kQ7codCrLcYAG6Y3ZrwRZ5Hq9GJo3EtC7KfWBk yio8UoOU1EwYapCzP7JEuIN3AfTxo6VGSUC7YEvm+QAtyHHl7+e8khpacmM4iOM/2DhM w8J8+EiUXndE3Y/KC0BipvvLAPgjN75zfjM4+a2S9sbGlsiRfOD9a3m/GwtP9XYosKL1 RR9Q== X-Gm-Message-State: AGRZ1gIU5J1ShnCV9t+Q1x2eP/xFu0s62WBRn+p+ZxGBUN4OBjy2TLBp +QjRpNBjuAfoKgVHYp8jx+nff+ggD3U= X-Received: by 2002:a63:7a5b:: with SMTP id j27mr9396597pgn.112.1542362699588; Fri, 16 Nov 2018 02:04:59 -0800 (PST) Received: from localhost ([122.172.88.116]) by smtp.gmail.com with ESMTPSA id r2sm10042207pfh.57.2018.11.16.02.04.58 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 16 Nov 2018 02:04:59 -0800 (PST) From: Viresh Kumar To: Mark Rutland , Rob Herring , arm@kernel.org, Shawn Guo , Li Yang Cc: Viresh Kumar , devicetree@vger.kernel.org, Vincent Guittot , Daniel Lezcano , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH 03/10] ARM64: dts: fsl: Add all CPUs in cooling maps Date: Fri, 16 Nov 2018 15:34:26 +0530 Message-Id: X-Mailer: git-send-email 2.19.1.568.g152ad8e3369a In-Reply-To: References: MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Each CPU can (and does) participate in cooling down the system but the DT only captures a handful of them, normally CPU0, in the cooling maps. Things work by chance currently as under normal circumstances its the first CPU of each cluster which is used by the operating systems to probe the cooling devices. But as soon as this CPU ordering changes and any other CPU is used to bring up the cooling device, we will start seeing failures. Also the DT is rather incomplete when we list only one CPU in the cooling maps, as the hardware doesn't have any such limitations. Update cooling maps to include all devices affected by individual trip points. Signed-off-by: Viresh Kumar --- .../arm64/boot/dts/freescale/fsl-ls1043a.dtsi | 6 ++-- .../arm64/boot/dts/freescale/fsl-ls1046a.dtsi | 6 ++-- .../arm64/boot/dts/freescale/fsl-ls1088a.dtsi | 17 ++++++----- .../arm64/boot/dts/freescale/fsl-ls208xa.dtsi | 28 ++++++------------- 4 files changed, 24 insertions(+), 33 deletions(-) -- 2.19.1.568.g152ad8e3369a diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi index 3fed504b5381..c7224c5bb6cc 100644 --- a/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi +++ b/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi @@ -171,8 +171,10 @@ map0 { trip = <&cpu_alert>; cooling-device = - <&cpu0 THERMAL_NO_LIMIT - THERMAL_NO_LIMIT>; + <&cpu0 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, + <&cpu1 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, + <&cpu2 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, + <&cpu3 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>; }; }; }; diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi index 51cbd50012d6..8c94d8279b5e 100644 --- a/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi +++ b/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi @@ -140,8 +140,10 @@ map0 { trip = <&cpu_alert>; cooling-device = - <&cpu0 THERMAL_NO_LIMIT - THERMAL_NO_LIMIT>; + <&cpu0 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, + <&cpu1 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, + <&cpu2 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, + <&cpu3 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>; }; }; }; diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi index a07f612ab56b..7faee0d270d2 100644 --- a/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi +++ b/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi @@ -152,15 +152,14 @@ map0 { trip = <&cpu_alert>; cooling-device = - <&cpu0 THERMAL_NO_LIMIT - THERMAL_NO_LIMIT>; - }; - - map1 { - trip = <&cpu_alert>; - cooling-device = - <&cpu4 THERMAL_NO_LIMIT - THERMAL_NO_LIMIT>; + <&cpu0 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, + <&cpu1 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, + <&cpu2 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, + <&cpu3 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, + <&cpu4 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, + <&cpu5 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, + <&cpu6 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, + <&cpu7 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>; }; }; }; diff --git a/arch/arm64/boot/dts/freescale/fsl-ls208xa.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls208xa.dtsi index d188774a36e8..f11187f7465c 100644 --- a/arch/arm64/boot/dts/freescale/fsl-ls208xa.dtsi +++ b/arch/arm64/boot/dts/freescale/fsl-ls208xa.dtsi @@ -101,26 +101,14 @@ map0 { trip = <&cpu_alert>; cooling-device = - <&cpu0 THERMAL_NO_LIMIT - THERMAL_NO_LIMIT>; - }; - map1 { - trip = <&cpu_alert>; - cooling-device = - <&cpu2 THERMAL_NO_LIMIT - THERMAL_NO_LIMIT>; - }; - map2 { - trip = <&cpu_alert>; - cooling-device = - <&cpu4 THERMAL_NO_LIMIT - THERMAL_NO_LIMIT>; - }; - map3 { - trip = <&cpu_alert>; - cooling-device = - <&cpu6 THERMAL_NO_LIMIT - THERMAL_NO_LIMIT>; + <&cpu0 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, + <&cpu1 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, + <&cpu2 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, + <&cpu3 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, + <&cpu4 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, + <&cpu5 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, + <&cpu6 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, + <&cpu7 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>; }; }; };