From patchwork Thu Jan 31 08:25:13 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Viresh Kumar X-Patchwork-Id: 157131 Delivered-To: patch@linaro.org Received: by 2002:a02:48:0:0:0:0:0 with SMTP id 69csp6924729jaa; Thu, 31 Jan 2019 00:25:32 -0800 (PST) X-Google-Smtp-Source: ALg8bN48ivUtJXKRX01oTYYDKwX5oRyYLlg5D9JnhF1xEB3C/1wAu9x0JnDxmV68gGODcdVQLU9A X-Received: by 2002:a63:bd1a:: with SMTP id a26mr30380140pgf.121.1548923132015; Thu, 31 Jan 2019 00:25:32 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1548923132; cv=none; d=google.com; s=arc-20160816; b=OF+6tpZuY54olpNc13dsIbMLMVWybzPmDInDD8gzgPxl11xDxSDdKl7hxvCKyvvgeH sCh3oqgIl3ArsNhINcRuC1n691ixAX4GtLXuk8md/bxkpjOi14dx+WD5GYNdp73GhgbR KwCqmIoinRSQJUepWpJPDT+emiFD0M+MYbYnMZv1RHZ0+09t43KV3FnngokB9+sanXBl biBAEywV02iHHj25cWdXvFpdGIRzPN5aL9aLMhsyv/WDL7lBGTCkqitFd0S2EZIFZWMM 60WL3XLeiaEfdJV0H9YZ1FmEtwI7g+ectaiL2j4dERFxx3fOSJlYqeDQ4NbZYmxPEqaM 8thQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=kZHVFmOzJU25u9HkbvP1Fa/F6wYGwLMXnctx3Yz3nHM=; b=LHk8xa25W+wVS6rbhd93UC1Adyyl2IhQRoW1mJGNX5x9AaaBpdANpkPX9fJBmUoKNW 2zJwpV4LUP5QYpL63mZODANGql6Et2xwN6jGEQSoQiLrT/iSF3GA6ssu7lZBlv2Pw2+h SwkXY/j0j73fFLNKRDRQ6KWbuBWnNYHzIMNHy+BrcbUVFN9B+TN+7OYggukx5EO+LfHa HGr7yvtu9LLgJWTQPT/Aw0+a0oEWnZqDjFPX6otgeUV0MilbNvNYBVnucJ48PJ7WSg+2 MpywT8/pkFSchCJzFJcYxTiFnDYNadZxwaaWqxBhKnmFHqHYlTtHWIMZGS8rW5fxASpb thnQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=iCUUO0PI; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w7si3714153pgh.560.2019.01.31.00.25.31; Thu, 31 Jan 2019 00:25:32 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=iCUUO0PI; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731613AbfAaIZa (ORCPT + 31 others); Thu, 31 Jan 2019 03:25:30 -0500 Received: from mail-pf1-f195.google.com ([209.85.210.195]:40556 "EHLO mail-pf1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727988AbfAaIZ2 (ORCPT ); Thu, 31 Jan 2019 03:25:28 -0500 Received: by mail-pf1-f195.google.com with SMTP id i12so1151378pfo.7 for ; Thu, 31 Jan 2019 00:25:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=kZHVFmOzJU25u9HkbvP1Fa/F6wYGwLMXnctx3Yz3nHM=; b=iCUUO0PIyoJk5/cvtqGv+Fd5sv2pVJYL0+e52+knivjq+Iuvz/uGWErpsZWgF/E/ap uThiGmiTXiStQuF0xCLw54QgTqMfT0IEJ/2p5ZHk1gG5v33YttwWAsY+qZsRIK6JmwDF cjmdapDO/XGYUWEiTdumO4GsN5tgamZzp2HuE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=kZHVFmOzJU25u9HkbvP1Fa/F6wYGwLMXnctx3Yz3nHM=; b=bH4DEnKxyyuPJDHWvEsoecZ3ts+UKBzW0aEDMadMfrBogGsOZTY9/HGlbnCdvrKQVZ 2Dpz3qEanQOvUNZoZ04/Ls0lS+SgeCPv7YesOqem8xyZTf6K1sn+J/pz7uGXvCNpi9RX GCqCmOGpYc5cqt6TqfbdfWmn644Jk2N917KWBIs+fRTwCq2AaM/nlLjl5pdhPU0k9ADp R230xOLhBtqErXSJuvIFLbPQD+uNfq1gQC89qozCYvXHsQUrUCMKMcIJTKqynG/rN/Lw Bkk8FMBveIamSULzHOpWAsgUUAdFnhikGOkIYl7r0yq+4TLXpaAzB/k4+ZrWHUvaLJ9N uqsA== X-Gm-Message-State: AJcUuker9C50KoF63w2WUL7QpE/KtUJDl7HdSYV2HKWYXgLHzSNWkQH2 /JAhJmK/WknQWKejDNKsvigOVg== X-Received: by 2002:a62:cf84:: with SMTP id b126mr33560188pfg.98.1548923127645; Thu, 31 Jan 2019 00:25:27 -0800 (PST) Received: from localhost ([122.172.102.63]) by smtp.gmail.com with ESMTPSA id s37sm8923021pgm.19.2019.01.31.00.25.25 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 31 Jan 2019 00:25:26 -0800 (PST) From: Viresh Kumar To: Viresh Kumar , Nishanth Menon , Stephen Boyd Cc: Viresh Kumar , linux-pm@vger.kernel.org, Vincent Guittot , Rafael Wysocki , linux-kernel@vger.kernel.org Subject: [PATCH] PM / OPP: Remove unused parameter of _generic_set_opp_clk_only() Date: Thu, 31 Jan 2019 13:55:13 +0530 Message-Id: X-Mailer: git-send-email 2.20.1.321.g9e740568ce00 MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The previous frequency value isn't getting used in the routine _generic_set_opp_clk_only(), drop it. Signed-off-by: Viresh Kumar --- drivers/opp/core.c | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) -- 2.20.1.321.g9e740568ce00 Reviewed-by: Stephen Boyd diff --git a/drivers/opp/core.c b/drivers/opp/core.c index d455b84cce5a..fa15aa8e00b0 100644 --- a/drivers/opp/core.c +++ b/drivers/opp/core.c @@ -533,9 +533,8 @@ static int _set_opp_voltage(struct device *dev, struct regulator *reg, return ret; } -static inline int -_generic_set_opp_clk_only(struct device *dev, struct clk *clk, - unsigned long old_freq, unsigned long freq) +static inline int _generic_set_opp_clk_only(struct device *dev, struct clk *clk, + unsigned long freq) { int ret; @@ -572,7 +571,7 @@ static int _generic_set_opp_regulator(const struct opp_table *opp_table, } /* Change frequency */ - ret = _generic_set_opp_clk_only(dev, opp_table->clk, old_freq, freq); + ret = _generic_set_opp_clk_only(dev, opp_table->clk, freq); if (ret) goto restore_voltage; @@ -586,7 +585,7 @@ static int _generic_set_opp_regulator(const struct opp_table *opp_table, return 0; restore_freq: - if (_generic_set_opp_clk_only(dev, opp_table->clk, freq, old_freq)) + if (_generic_set_opp_clk_only(dev, opp_table->clk, old_freq)) dev_err(dev, "%s: failed to restore old-freq (%lu Hz)\n", __func__, old_freq); restore_voltage: @@ -759,7 +758,7 @@ int dev_pm_opp_set_rate(struct device *dev, unsigned long target_freq) opp->supplies); } else { /* Only frequency scaling */ - ret = _generic_set_opp_clk_only(dev, clk, old_freq, freq); + ret = _generic_set_opp_clk_only(dev, clk, freq); } /* Scaling down? Configure required OPPs after frequency */