From patchwork Thu Dec 4 15:38:50 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ola Liljedahl X-Patchwork-Id: 41940 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-lb0-f198.google.com (mail-lb0-f198.google.com [209.85.217.198]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 9035D2486D for ; Thu, 4 Dec 2014 15:39:23 +0000 (UTC) Received: by mail-lb0-f198.google.com with SMTP id p9sf11100175lbv.1 for ; Thu, 04 Dec 2014 07:39:22 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:delivered-to:from:to:date:message-id:in-reply-to :references:subject:precedence:list-id:list-unsubscribe:list-archive :list-post:list-help:list-subscribe:mime-version:content-type :content-transfer-encoding:errors-to:sender:x-original-sender :x-original-authentication-results:mailing-list; bh=2+HSovIOA8DOdb2BcZlqLQ42B1TtOaLNkYGeKMnMEtI=; b=KqIdxpXXs5G9siqLgSu1tbvaujk1K0u/UABt/MTDpXeJCl4IxpPoLzciI/gY/j+sM3 D4EShqNAOJCvur8+ljDy8hI3XJtZkC9UGfSP1oA9VE51tnlVC7Ra/J++/RNNs41DwwBx ex6kawM5uGBf4/oRvA1sNjShh8MQ1uBKnUfBg9/LhYK1AuH+TuN7sWLShYA16+2dEdkJ VAVNXJiHZPBQKS1flCdNo5fzLpbIsDob4uCqMERmh1cYVJDquxESz494MXfgBpMMbUyP 74ZqYgdzAi68QJeeFlUmKRU7Hmfr2kZMOL/qSq0GsMiIIEPGY96eXXZxC/sz/6IO9GLm hMug== X-Gm-Message-State: ALoCoQlT5uaedJcerIJtewTrE5mQoxaWNZ1gz9apwqBEsAvYmhxZguOCT0Qy03XplwXqFSCScrd3 X-Received: by 10.112.53.39 with SMTP id y7mr2384158lbo.8.1417707562568; Thu, 04 Dec 2014 07:39:22 -0800 (PST) X-BeenThere: patchwork-forward@linaro.org Received: by 10.152.205.10 with SMTP id lc10ls298481lac.22.gmail; Thu, 04 Dec 2014 07:39:22 -0800 (PST) X-Received: by 10.152.88.69 with SMTP id be5mr10264061lab.36.1417707562064; Thu, 04 Dec 2014 07:39:22 -0800 (PST) Received: from mail-lb0-f171.google.com (mail-lb0-f171.google.com. [209.85.217.171]) by mx.google.com with ESMTPS id le3si26290415lac.43.2014.12.04.07.39.22 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 04 Dec 2014 07:39:22 -0800 (PST) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.217.171 as permitted sender) client-ip=209.85.217.171; Received: by mail-lb0-f171.google.com with SMTP id n15so14392367lbi.16 for ; Thu, 04 Dec 2014 07:39:22 -0800 (PST) X-Received: by 10.112.38.4 with SMTP id c4mr10181576lbk.46.1417707561976; Thu, 04 Dec 2014 07:39:21 -0800 (PST) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.112.184.201 with SMTP id ew9csp56584lbc; Thu, 4 Dec 2014 07:39:20 -0800 (PST) X-Received: by 10.170.128.207 with SMTP id u198mr15160598ykb.51.1417707559611; Thu, 04 Dec 2014 07:39:19 -0800 (PST) Received: from ip-10-35-177-41.ec2.internal (lists.linaro.org. [54.225.227.206]) by mx.google.com with ESMTPS id r3si4181309qal.86.2014.12.04.07.39.18 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Thu, 04 Dec 2014 07:39:19 -0800 (PST) Received-SPF: none (google.com: lng-odp-bounces@lists.linaro.org does not designate permitted sender hosts) client-ip=54.225.227.206; Received: from localhost ([127.0.0.1] helo=ip-10-35-177-41.ec2.internal) by ip-10-35-177-41.ec2.internal with esmtp (Exim 4.76) (envelope-from ) id 1XwYUv-0004SC-O7; Thu, 04 Dec 2014 15:39:17 +0000 Received: from mail-lb0-f181.google.com ([209.85.217.181]) by ip-10-35-177-41.ec2.internal with esmtp (Exim 4.76) (envelope-from ) id 1XwYUi-0004PT-W6 for lng-odp@lists.linaro.org; Thu, 04 Dec 2014 15:39:05 +0000 Received: by mail-lb0-f181.google.com with SMTP id l4so4882561lbv.12 for ; Thu, 04 Dec 2014 07:38:59 -0800 (PST) X-Received: by 10.112.189.10 with SMTP id ge10mr9897174lbc.23.1417707539473; Thu, 04 Dec 2014 07:38:59 -0800 (PST) Received: from macmini.lan (84-217-193-77.tn.glocalnet.net. [84.217.193.77]) by mx.google.com with ESMTPSA id zo3sm7411637lbb.10.2014.12.04.07.38.58 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 04 Dec 2014 07:38:58 -0800 (PST) From: Ola Liljedahl To: lng-odp@lists.linaro.org Date: Thu, 4 Dec 2014 16:38:50 +0100 Message-Id: <1417707535-7632-2-git-send-email-ola.liljedahl@linaro.org> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1417707535-7632-1-git-send-email-ola.liljedahl@linaro.org> References: <1417707535-7632-1-git-send-email-ola.liljedahl@linaro.org> X-Topics: patch Subject: [lng-odp] [PATCHv2 1/6] api:odp_atomic.h: Update doxygen comments, renaming of function params X-BeenThere: lng-odp@lists.linaro.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: , List-Help: , List-Subscribe: , MIME-Version: 1.0 Errors-To: lng-odp-bounces@lists.linaro.org Sender: lng-odp-bounces@lists.linaro.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: ola.liljedahl@linaro.org X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.217.171 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 Signed-off-by: Ola Liljedahl Reviewed-by: Bill Fischofer --- (This code contribution is provided under the terms of agreement LES-LTM-21309) Update and unify doxygen comments and function parameter names. platform/linux-generic/include/api/odp_atomic.h | 283 ++++++++++++------------ 1 file changed, 138 insertions(+), 145 deletions(-) diff --git a/platform/linux-generic/include/api/odp_atomic.h b/platform/linux-generic/include/api/odp_atomic.h index 9eebb86..4a5b0b2 100644 --- a/platform/linux-generic/include/api/odp_atomic.h +++ b/platform/linux-generic/include/api/odp_atomic.h @@ -29,21 +29,21 @@ extern "C" { /** - * Atomic unsigned integer 64 bits + * Atomic 64-bit unsigned integer */ typedef struct { uint64_t v; /**< Actual storage for the atomic variable */ #if __GCC_ATOMIC_LLONG_LOCK_FREE < 2 /* Some architectures do not support lock-free operations on 64-bit * data types. We use a spin lock to ensure atomicity. */ - char lock; /**< Spin lock used to ensure atomic access */ + char lock; /**< Spin lock (if needed) used to ensure atomic access */ #endif } odp_atomic_u64_t ODP_ALIGNED(sizeof(uint64_t)); /* Enforce alignement! */ /** - * Atomic unsigned integer 32 bits + * Atomic 32-bit unsigned integer */ typedef struct { uint32_t v; /**< Actual storage for the atomic variable */ @@ -52,170 +52,168 @@ ODP_ALIGNED(sizeof(uint32_t)); /* Enforce alignement! */ /** - * Initialize atomic uint32 + * Initialize atomic uint32 variable * @note Relaxed memory order, cannot be used for synchronization * - * @param ptr An atomic variable - * @param val Value to initialize the variable with + * @param[out] atom Pointer to an atomic uint32 variable + * @param val Value to initialize the variable with */ -static inline void odp_atomic_init_u32(odp_atomic_u32_t *ptr, uint32_t val) +static inline void odp_atomic_init_u32(odp_atomic_u32_t *atom, uint32_t val) { - __atomic_store_n(&ptr->v, val, __ATOMIC_RELAXED); + __atomic_store_n(&atom->v, val, __ATOMIC_RELAXED); } /** - * Load value of atomic uint32 + * Load value of atomic uint32 variable * @note Relaxed memory order, cannot be used for synchronization * - * @param ptr An atomic variable + * @param atom Pointer to an atomic uint32 variable * * @return Value of the variable */ -static inline uint32_t odp_atomic_load_u32(odp_atomic_u32_t *ptr) +static inline uint32_t odp_atomic_load_u32(odp_atomic_u32_t *atom) { - return __atomic_load_n(&ptr->v, __ATOMIC_RELAXED); + return __atomic_load_n(&atom->v, __ATOMIC_RELAXED); } /** - * Store value to atomic uint32 + * Store value to atomic uint32 variable * @note Relaxed memory order, cannot be used for synchronization * - * @param ptr An atomic variable - * @param new_value Store new_value to a variable + * @param[out] atom Pointer to an atomic uint32 variable + * @param val Value to store in the variable */ -static inline void odp_atomic_store_u32(odp_atomic_u32_t *ptr, - uint32_t new_value) +static inline void odp_atomic_store_u32(odp_atomic_u32_t *atom, + uint32_t val) { - __atomic_store_n(&ptr->v, new_value, __ATOMIC_RELAXED); + __atomic_store_n(&atom->v, val, __ATOMIC_RELAXED); } /** - * Fetch and add atomic uint32 + * Fetch and add to atomic uint32 variable * @note Relaxed memory order, cannot be used for synchronization * - * @param ptr An atomic variable - * @param value A value to be added to the variable + * @param[in,out] atom Pointer to an atomic uint32 variable + * @param val Value to be added to the variable * - * @return Value of the variable before the operation + * @return Value of the variable before the addition */ -static inline uint32_t odp_atomic_fetch_add_u32(odp_atomic_u32_t *ptr, - uint32_t value) +static inline uint32_t odp_atomic_fetch_add_u32(odp_atomic_u32_t *atom, + uint32_t val) { - return __atomic_fetch_add(&ptr->v, value, __ATOMIC_RELAXED); + return __atomic_fetch_add(&atom->v, val, __ATOMIC_RELAXED); } /** - * Add atomic uint32 + * Add to atomic uint32 variable * @note Relaxed memory order, cannot be used for synchronization * - * @param ptr An atomic variable - * @param value A value to be added to the variable + * @param[in,out] atom Pointer to an atomic uint32 variable + * @param val A value to be added to the variable */ -static inline void odp_atomic_add_u32(odp_atomic_u32_t *ptr, - uint32_t value) +static inline void odp_atomic_add_u32(odp_atomic_u32_t *atom, + uint32_t val) { - (void)__atomic_fetch_add(&ptr->v, value, __ATOMIC_RELAXED); + (void)__atomic_fetch_add(&atom->v, val, __ATOMIC_RELAXED); } /** - * Fetch and subtract uint32 + * Fetch and subtract from atomic uint32 variable * @note Relaxed memory order, cannot be used for synchronization * - * @param ptr An atomic variable - * @param value A value to be sub to the variable + * @param[in,out] atom Pointer to an atomic uint32 variable + * @param val A value to be subracted from the variable * - * @return Value of the variable before the operation + * @return Value of the variable before the subtraction */ -static inline uint32_t odp_atomic_fetch_sub_u32(odp_atomic_u32_t *ptr, - uint32_t value) +static inline uint32_t odp_atomic_fetch_sub_u32(odp_atomic_u32_t *atom, + uint32_t val) { - return __atomic_fetch_sub(&ptr->v, value, __ATOMIC_RELAXED); + return __atomic_fetch_sub(&atom->v, val, __ATOMIC_RELAXED); } /** - * Subtract uint32 + * Subtract from atomic uint32 variable * @note Relaxed memory order, cannot be used for synchronization * - * @param ptr An atomic variable - * @param value A value to be subtract from the variable + * @param[in,out] atom Pointer to an atomic uint32 variable + * @param val Value to be subtracted from the variable */ -static inline void odp_atomic_sub_u32(odp_atomic_u32_t *ptr, - uint32_t value) +static inline void odp_atomic_sub_u32(odp_atomic_u32_t *atom, + uint32_t val) { - (void)__atomic_fetch_sub(&ptr->v, value, __ATOMIC_RELAXED); + (void)__atomic_fetch_sub(&atom->v, val, __ATOMIC_RELAXED); } /** - * Fetch and increment atomic uint32 by 1 + * Fetch and increment atomic uint32 variable * @note Relaxed memory order, cannot be used for synchronization * - * @param ptr An atomic variable + * @param[in,out] atom Pointer to an atomic uint32 variable * - * @return Value of the variable before the operation + * @return Value of the variable before the increment */ -static inline uint32_t odp_atomic_fetch_inc_u32(odp_atomic_u32_t *ptr) +static inline uint32_t odp_atomic_fetch_inc_u32(odp_atomic_u32_t *atom) { #if defined __OCTEON__ uint32_t ret; __asm__ __volatile__ ("syncws"); - __asm__ __volatile__ ("lai %0,(%2)" : "=r" (ret), "+m" (ptr) : - "r" (ptr)); + __asm__ __volatile__ ("lai %0,(%2)" : "=r" (ret), "+m" (atom) : + "r" (atom)); return ret; #else - return __atomic_fetch_add(&ptr->v, 1, __ATOMIC_RELAXED); + return __atomic_fetch_add(&atom->v, 1, __ATOMIC_RELAXED); #endif } /** - * Increment atomic uint32 by 1 + * Increment atomic uint32 variable * @note Relaxed memory order, cannot be used for synchronization * - * @param ptr An atomic variable - * + * @param[in,out] atom Pointer to an atomic uint32 variable */ -static inline void odp_atomic_inc_u32(odp_atomic_u32_t *ptr) +static inline void odp_atomic_inc_u32(odp_atomic_u32_t *atom) { - (void)__atomic_fetch_add(&ptr->v, 1, __ATOMIC_RELAXED); + (void)__atomic_fetch_add(&atom->v, 1, __ATOMIC_RELAXED); } /** - * Fetch and decrement uint32 by 1 + * Fetch and decrement atomic uint32 variable * @note Relaxed memory order, cannot be used for synchronization * - * @param ptr An atomic variable + * @param[in,out] atom Pointer to an atomic uint32 variable * - * @return Value of the variable before the operation + * @return Value of the variable before the subtraction */ -static inline uint32_t odp_atomic_fetch_dec_u32(odp_atomic_u32_t *ptr) +static inline uint32_t odp_atomic_fetch_dec_u32(odp_atomic_u32_t *atom) { - return __atomic_fetch_sub(&ptr->v, 1, __ATOMIC_RELAXED); + return __atomic_fetch_sub(&atom->v, 1, __ATOMIC_RELAXED); } /** - * Decrement atomic uint32 by 1 + * Decrement atomic uint32 variable * @note Relaxed memory order, cannot be used for synchronization * - * @param ptr An atomic variable - * + * @param[in,out] atom Pointer to an atomic uint32 variable */ -static inline void odp_atomic_dec_u32(odp_atomic_u32_t *ptr) +static inline void odp_atomic_dec_u32(odp_atomic_u32_t *atom) { - (void)__atomic_fetch_sub(&ptr->v, 1, __ATOMIC_RELAXED); + (void)__atomic_fetch_sub(&atom->v, 1, __ATOMIC_RELAXED); } /** - * Initialize atomic uint64 + * Initialize atomic uint64 variable * @note Relaxed memory order, cannot be used for synchronization * - * @param ptr An atomic variable - * @param val Value to initialize the variable with + * @param[out] atom Pointer to an atomic uint64 variable + * @param val Value to initialize the variable with */ -static inline void odp_atomic_init_u64(odp_atomic_u64_t *ptr, uint64_t val) +static inline void odp_atomic_init_u64(odp_atomic_u64_t *atom, uint64_t val) { - ptr->v = val; + atom->v = val; #if __GCC_ATOMIC_LLONG_LOCK_FREE < 2 - __atomic_clear(&ptr->lock, __ATOMIC_RELAXED); + __atomic_clear(&atom->lock, __ATOMIC_RELAXED); #endif } @@ -223,195 +221,190 @@ static inline void odp_atomic_init_u64(odp_atomic_u64_t *ptr, uint64_t val) /** * @internal * Helper macro for lock-based atomic operations on 64-bit integers - * @param ptr Pointer to the 64-bit atomic variable + * @param[in,out] atom Pointer to the 64-bit atomic variable * @param expr Expression used update the variable. * @return The old value of the variable. */ -#define ATOMIC_OP(ptr, expr) \ +#define ATOMIC_OP(atom, expr) \ ({ \ uint64_t old_val; \ /* Loop while lock is already taken, stop when lock becomes clear */ \ - while (__atomic_test_and_set(&(ptr)->lock, __ATOMIC_ACQUIRE)) \ + while (__atomic_test_and_set(&(atom)->lock, __ATOMIC_ACQUIRE)) \ (void)0; \ - old_val = (ptr)->v; \ + old_val = (atom)->v; \ (expr); /* Perform whatever update is desired */ \ - __atomic_clear(&(ptr)->lock, __ATOMIC_RELEASE); \ + __atomic_clear(&(atom)->lock, __ATOMIC_RELEASE); \ old_val; /* Return old value */ \ }) #endif /** - * Load value of atomic uint64 + * Load value of atomic uint64 variable * @note Relaxed memory order, cannot be used for synchronization * - * @param ptr An atomic variable + * @param atom Pointer to an atomic uint64 variable * - * @return atomic uint64 value + * @return Value of the variable */ -static inline uint64_t odp_atomic_load_u64(odp_atomic_u64_t *ptr) +static inline uint64_t odp_atomic_load_u64(odp_atomic_u64_t *atom) { #if __GCC_ATOMIC_LLONG_LOCK_FREE < 2 - return ATOMIC_OP(ptr, (void)0); + return ATOMIC_OP(atom, (void)0); #else - return __atomic_load_n(&ptr->v, __ATOMIC_RELAXED); + return __atomic_load_n(&atom->v, __ATOMIC_RELAXED); #endif } /** - * Store value to atomic uint64 + * Store value to atomic uint64 variable * @note Relaxed memory order, cannot be used for synchronization * - * @param ptr An atomic variable - * @param new_value Store new_value to a variable - * - * @note The operation is not synchronized with other threads + * @param[out] atom Pointer to an atomic uint64 variable + * @param val Value to store in the variable */ -static inline void odp_atomic_store_u64(odp_atomic_u64_t *ptr, - uint64_t new_value) +static inline void odp_atomic_store_u64(odp_atomic_u64_t *atom, + uint64_t val) { #if __GCC_ATOMIC_LLONG_LOCK_FREE < 2 - (void)ATOMIC_OP(ptr, ptr->v = new_value); + (void)ATOMIC_OP(atom, atom->v = val); #else - __atomic_store_n(&ptr->v, new_value, __ATOMIC_RELAXED); + __atomic_store_n(&atom->v, val, __ATOMIC_RELAXED); #endif } /** - * Fetch and add atomic uint64 + * Fetch and add to atomic uint64 variable * @note Relaxed memory order, cannot be used for synchronization * - * @param ptr An atomic variable - * @param value A value to be added to the variable + * @param[in,out] atom Pointer to an atomic uint64 variable + * @param val Value to be added to the variable * - * @return Value of the variable before the operation + * @return Value of the variable before the addition */ -static inline uint64_t odp_atomic_fetch_add_u64(odp_atomic_u64_t *ptr, - uint64_t value) +static inline uint64_t odp_atomic_fetch_add_u64(odp_atomic_u64_t *atom, + uint64_t val) { #if __GCC_ATOMIC_LLONG_LOCK_FREE < 2 - return ATOMIC_OP(ptr, ptr->v += value); + return ATOMIC_OP(atom, atom->v += val); #else - return __atomic_fetch_add(&ptr->v, value, __ATOMIC_RELAXED); + return __atomic_fetch_add(&atom->v, val, __ATOMIC_RELAXED); #endif } /** - * Add atomic uint64 + * Add to atomic uint64 variable * @note Relaxed memory order, cannot be used for synchronization * - * @param ptr An atomic variable - * @param value A value to be added to the variable + * @param[in,out] atom Pointer to an atomic uint64 variable + * @param val Value to be added to the variable * */ -static inline void odp_atomic_add_u64(odp_atomic_u64_t *ptr, uint64_t value) +static inline void odp_atomic_add_u64(odp_atomic_u64_t *atom, uint64_t val) { #if __GCC_ATOMIC_LLONG_LOCK_FREE < 2 - (void)ATOMIC_OP(ptr, ptr->v += value); + (void)ATOMIC_OP(atom, atom->v += val); #else - (void)__atomic_fetch_add(&ptr->v, value, __ATOMIC_RELAXED); + (void)__atomic_fetch_add(&atom->v, val, __ATOMIC_RELAXED); #endif } /** - * Fetch and subtract atomic uint64 + * Fetch and subtract from atomic uint64 variable * @note Relaxed memory order, cannot be used for synchronization * - * @param ptr An atomic variable - * @param value A value to be subtracted from the variable + * @param[in,out] atom Pointer to an atomic uint64 variable + * @param val Value to be subtracted from the variable * - * @return Value of the variable before the operation + * @return Value of the variable before the subtraction */ -static inline uint64_t odp_atomic_fetch_sub_u64(odp_atomic_u64_t *ptr, - uint64_t value) +static inline uint64_t odp_atomic_fetch_sub_u64(odp_atomic_u64_t *atom, + uint64_t val) { #if __GCC_ATOMIC_LLONG_LOCK_FREE < 2 - return ATOMIC_OP(ptr, ptr->v -= value); + return ATOMIC_OP(atom, atom->v -= val); #else - return __atomic_fetch_sub(&ptr->v, value, __ATOMIC_RELAXED); + return __atomic_fetch_sub(&atom->v, val, __ATOMIC_RELAXED); #endif } /** - * Subtract atomic uint64 + * Subtract from atomic uint64 variable * @note Relaxed memory order, cannot be used for synchronization * - * @param ptr An atomic variable - * @param value A value to be subtracted from the variable - * + * @param[in,out] atom Pointer to an atomic uint64 variable + * @param val Value to be subtracted from the variable */ -static inline void odp_atomic_sub_u64(odp_atomic_u64_t *ptr, uint64_t value) +static inline void odp_atomic_sub_u64(odp_atomic_u64_t *atom, uint64_t val) { #if __GCC_ATOMIC_LLONG_LOCK_FREE < 2 - (void)ATOMIC_OP(ptr, ptr->v -= value); + (void)ATOMIC_OP(atom, atom->v -= val); #else - (void)__atomic_fetch_sub(&ptr->v, value, __ATOMIC_RELAXED); + (void)__atomic_fetch_sub(&atom->v, val, __ATOMIC_RELAXED); #endif } /** - * Fetch and increment atomic uint64 by 1 + * Fetch and increment atomic uint64 variable * @note Relaxed memory order, cannot be used for synchronization * - * @param ptr An atomic variable + * @param[in,out] atom Pointer to an atomic uint64 variable * - * @return Value of the variable before the operation + * @return Value of the variable before the increment */ -static inline uint64_t odp_atomic_fetch_inc_u64(odp_atomic_u64_t *ptr) +static inline uint64_t odp_atomic_fetch_inc_u64(odp_atomic_u64_t *atom) { #if __GCC_ATOMIC_LLONG_LOCK_FREE < 2 - return ATOMIC_OP(ptr, ptr->v++); + return ATOMIC_OP(atom, atom->v++); #else - return __atomic_fetch_add(&ptr->v, 1, __ATOMIC_RELAXED); + return __atomic_fetch_add(&atom->v, 1, __ATOMIC_RELAXED); #endif } /** - * Increment atomic uint64 by 1 + * Increment atomic uint64 variable * @note Relaxed memory order, cannot be used for synchronization * - * @param ptr An atomic variable - * + * @param[in,out] atom Pointer to an atomic uint64 variable */ -static inline void odp_atomic_inc_u64(odp_atomic_u64_t *ptr) +static inline void odp_atomic_inc_u64(odp_atomic_u64_t *atom) { #if __GCC_ATOMIC_LLONG_LOCK_FREE < 2 - (void)ATOMIC_OP(ptr, ptr->v++); + (void)ATOMIC_OP(atom, atom->v++); #else - (void)__atomic_fetch_add(&ptr->v, 1, __ATOMIC_RELAXED); + (void)__atomic_fetch_add(&atom->v, 1, __ATOMIC_RELAXED); #endif } /** - * Fetch and decrement atomic uint64 by 1 + * Fetch and decrement atomic uint64 variable * @note Relaxed memory order, cannot be used for synchronization * - * @param ptr An atomic variable + * @param[in,out] atom Pointer to an atomic uint64 variable * - * @return Value of the variable before the operation + * @return Value of the variable before the decrement */ -static inline uint64_t odp_atomic_fetch_dec_u64(odp_atomic_u64_t *ptr) +static inline uint64_t odp_atomic_fetch_dec_u64(odp_atomic_u64_t *atom) { #if __GCC_ATOMIC_LLONG_LOCK_FREE < 2 - return ATOMIC_OP(ptr, ptr->v--); + return ATOMIC_OP(atom, atom->v--); #else - return __atomic_fetch_sub(&ptr->v, 1, __ATOMIC_RELAXED); + return __atomic_fetch_sub(&atom->v, 1, __ATOMIC_RELAXED); #endif } /** - * Decrement atomic uint64 by 1 + * Decrement atomic uint64 variable * @note Relaxed memory order, cannot be used for synchronization * - * @param ptr An atomic variable - * + * @param[in,out] atom Pointer to an atomic uint64 variable */ -static inline void odp_atomic_dec_u64(odp_atomic_u64_t *ptr) +static inline void odp_atomic_dec_u64(odp_atomic_u64_t *atom) { #if __GCC_ATOMIC_LLONG_LOCK_FREE < 2 - (void)ATOMIC_OP(ptr, ptr->v--); + (void)ATOMIC_OP(atom, atom->v--); #else - (void)__atomic_fetch_sub(&ptr->v, 1, __ATOMIC_RELAXED); + (void)__atomic_fetch_sub(&atom->v, 1, __ATOMIC_RELAXED); #endif }