From patchwork Thu Aug 20 19:18:14 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mike Holmes X-Patchwork-Id: 52603 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-la0-f71.google.com (mail-la0-f71.google.com [209.85.215.71]) by patches.linaro.org (Postfix) with ESMTPS id B596322E4F for ; Thu, 20 Aug 2015 19:19:04 +0000 (UTC) Received: by lagz9 with SMTP id z9sf14457859lag.3 for ; Thu, 20 Aug 2015 12:19:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:delivered-to:delivered-to:from:to:date :message-id:in-reply-to:references:subject:precedence:list-id :list-unsubscribe:list-archive:list-post:list-help:list-subscribe :mime-version:content-type:content-transfer-encoding:errors-to :sender:x-original-sender:x-original-authentication-results :mailing-list; bh=S8IZ74tOqSO61wjSXsFHVOSyhW96GwmW2fcsES9HSHQ=; b=hjxTPZW3OVXzaDvDIppCm4i7Tprxx92wTljhjqBUhQmvVVMwDDIZOOTvuktstHz0RU VWehYmNb5WCE93DbOHp4T42DQii7JZRALj9ujOKpzwISjydyuLuU+yt27PuSEz3GLlSM WDnsfGKErmYeKIJj8oa5H8Bdo7YzpBjcKED1LBbbRtFDW6zPDnWWgVtJwbOWZY8fC16T GK9XJ6gBNJ0NcmzX9wQE/EhWFN2Wcgu8oOan7XM4xP6F8b/W8qfV1J1K5MlErAQHKNwB +F0kZVQpX9xtJX/aktmUTyAZNtChHyeGnpoR86bf1qvZ6w1LiV7xlxG5Dho3isCz7zr5 AJHQ== X-Gm-Message-State: ALoCoQkdQa7koOznpgwGEm6YJWllLpJKH3JCMSP90BCiu/o3oQw2vFzWD0MUFihrbfsLWMxA6lgl X-Received: by 10.112.90.225 with SMTP id bz1mr1254603lbb.12.1440098343621; Thu, 20 Aug 2015 12:19:03 -0700 (PDT) X-BeenThere: patchwork-forward@linaro.org Received: by 10.152.9.133 with SMTP id z5ls199858laa.5.gmail; Thu, 20 Aug 2015 12:19:03 -0700 (PDT) X-Received: by 10.152.18.137 with SMTP id w9mr4266953lad.23.1440098343474; Thu, 20 Aug 2015 12:19:03 -0700 (PDT) Received: from mail-lb0-f182.google.com (mail-lb0-f182.google.com. [209.85.217.182]) by mx.google.com with ESMTPS id lm12si2841914lac.61.2015.08.20.12.19.03 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 20 Aug 2015 12:19:03 -0700 (PDT) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.217.182 as permitted sender) client-ip=209.85.217.182; Received: by lbbpu9 with SMTP id pu9so30219481lbb.3 for ; Thu, 20 Aug 2015 12:19:03 -0700 (PDT) X-Received: by 10.152.28.193 with SMTP id d1mr4263418lah.72.1440098343377; Thu, 20 Aug 2015 12:19:03 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.112.162.200 with SMTP id yc8csp189791lbb; Thu, 20 Aug 2015 12:19:02 -0700 (PDT) X-Received: by 10.194.60.11 with SMTP id d11mr8604538wjr.143.1440098342023; Thu, 20 Aug 2015 12:19:02 -0700 (PDT) Received: from lists.linaro.org (lists.linaro.org. [54.225.227.206]) by mx.google.com with ESMTP id hc8si10189932wjc.30.2015.08.20.12.18.59; Thu, 20 Aug 2015 12:19:02 -0700 (PDT) Received-SPF: pass (google.com: domain of lng-odp-bounces@lists.linaro.org designates 54.225.227.206 as permitted sender) client-ip=54.225.227.206; Received: by lists.linaro.org (Postfix, from userid 109) id 2FD616211B; Thu, 20 Aug 2015 19:18:59 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on ip-10-142-244-252.ec2.internal X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, URIBL_BLOCKED autolearn=disabled version=3.4.0 Received: from ip-10-142-244-252.ec2.internal (localhost [127.0.0.1]) by lists.linaro.org (Postfix) with ESMTP id CD06262114; Thu, 20 Aug 2015 19:18:25 +0000 (UTC) X-Original-To: lng-odp@lists.linaro.org Delivered-To: lng-odp@lists.linaro.org Received: by lists.linaro.org (Postfix, from userid 109) id C9D8962115; Thu, 20 Aug 2015 19:18:22 +0000 (UTC) Received: from mail-qg0-f46.google.com (mail-qg0-f46.google.com [209.85.192.46]) by lists.linaro.org (Postfix) with ESMTPS id 4C05662114 for ; Thu, 20 Aug 2015 19:18:21 +0000 (UTC) Received: by qgj62 with SMTP id 62so34187476qgj.2 for ; Thu, 20 Aug 2015 12:18:21 -0700 (PDT) X-Received: by 10.140.144.11 with SMTP id 11mr9129568qhq.46.1440098301043; Thu, 20 Aug 2015 12:18:21 -0700 (PDT) Received: from localhost.localdomain (c-98-221-136-245.hsd1.nj.comcast.net. [98.221.136.245]) by smtp.gmail.com with ESMTPSA id e196sm2821408qka.40.2015.08.20.12.18.20 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 20 Aug 2015 12:18:20 -0700 (PDT) From: Mike Holmes To: lng-odp@lists.linaro.org Date: Thu, 20 Aug 2015 15:18:14 -0400 Message-Id: <1440098294-24278-2-git-send-email-mike.holmes@linaro.org> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1440098294-24278-1-git-send-email-mike.holmes@linaro.org> References: <1440098294-24278-1-git-send-email-mike.holmes@linaro.org> X-Topics: patch Subject: [lng-odp] [PATCH 2/2] validation: add test on unused retvals X-BeenThere: lng-odp@lists.linaro.org X-Mailman-Version: 2.1.16 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: , List-Help: , List-Subscribe: , MIME-Version: 1.0 Errors-To: lng-odp-bounces@lists.linaro.org Sender: "lng-odp" X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: mike.holmes@linaro.org X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.217.182 as permitted sender) smtp.mailfrom=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 Fix unused return codes by testing for validity Signed-off-by: Mike Holmes Reviewed-by: Bill Fischofer --- test/validation/classification/odp_classification_tests.c | 1 + test/validation/common/mask_common.c | 1 + 2 files changed, 2 insertions(+) diff --git a/test/validation/classification/odp_classification_tests.c b/test/validation/classification/odp_classification_tests.c index 0e0c4eb..a312dc9 100644 --- a/test/validation/classification/odp_classification_tests.c +++ b/test/validation/classification/odp_classification_tests.c @@ -407,6 +407,7 @@ void configure_cls_pmr_chain(void) retval = odp_cos_set_queue(cos_list[CLS_PMR_CHAIN_DST], queue_list[CLS_PMR_CHAIN_DST]); + CU_ASSERT(retval == 0); parse_ipv4_string(CLS_PMR_CHAIN_SADDR, &addr, &mask); pmr_list[CLS_PMR_CHAIN_SRC] = odp_pmr_create(ODP_PMR_SIP_ADDR, &addr, diff --git a/test/validation/common/mask_common.c b/test/validation/common/mask_common.c index fce7725..9b1a23f 100644 --- a/test/validation/common/mask_common.c +++ b/test/validation/common/mask_common.c @@ -145,6 +145,7 @@ MASK_TESTFUNC(to_from_str) str_sz = _odp_mask_to_str(&mask, buf_out, stringlen(TEST_MASK_0) + 1); + CU_ASSERT(str_sz == (int32_t)stringlen(TEST_MASK_0) + 1); CU_ASSERT_NSTRING_EQUAL(buf_out, TEST_MASK_0, stringlen(TEST_MASK_0) + 1);