From patchwork Thu Sep 3 00:07:15 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bill Fischofer X-Patchwork-Id: 52997 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-la0-f72.google.com (mail-la0-f72.google.com [209.85.215.72]) by patches.linaro.org (Postfix) with ESMTPS id 403DD23002 for ; Thu, 3 Sep 2015 00:08:11 +0000 (UTC) Received: by laeb10 with SMTP id b10sf10303270lae.1 for ; Wed, 02 Sep 2015 17:08:10 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:delivered-to:delivered-to:from:to:date :message-id:in-reply-to:references:subject:precedence:list-id :list-unsubscribe:list-archive:list-post:list-help:list-subscribe :mime-version:content-type:content-transfer-encoding:errors-to :sender:x-original-sender:x-original-authentication-results :mailing-list; bh=YoARQkxRd3Owydk2Gs4lQvrKD5ZGXe0CwbeiBcgRlU4=; b=OdKcm/wihuGUG8OB61uKghkgf072Ywr494g7jist3u0QPaHNZWNTM0QwzaJcwL6nX5 pP1me+tBVvqTIWc62OikGkDz4o2jrdBVf760E9Iur2qhofMeNWxxjwbYJ6/VH1w2V1Tu yXkM5XMA7HaDTvuH+jxh5+3+9G/quK8RY+3mwyB95yI/pmy7scpAsbNnqK3/BLHWEj/H YY9ROnBm09EiMwnw0bOwGJYQf+IvvWFoSu/vkweosTwxnp5CbsX+7vJASzQfzMeLHbZ4 GUm/O9A21QosLptiDEJxV9mBkJ1LuMMyyRmj1l24xX9Q1QpgvE1vYuV7lC5aeyM8qVNt EOCw== X-Gm-Message-State: ALoCoQlD02t6+66CAFMhpWk+9xPp22ZQL6Lq1xS4kmjzFiQW2yKCyIBvCLUjMZHZ3lFykC007+KY X-Received: by 10.112.139.65 with SMTP id qw1mr9758329lbb.24.1441238890207; Wed, 02 Sep 2015 17:08:10 -0700 (PDT) X-BeenThere: patchwork-forward@linaro.org Received: by 10.152.5.1 with SMTP id o1ls162611lao.12.gmail; Wed, 02 Sep 2015 17:08:10 -0700 (PDT) X-Received: by 10.152.4.98 with SMTP id j2mr17825946laj.67.1441238890050; Wed, 02 Sep 2015 17:08:10 -0700 (PDT) Received: from mail-la0-f43.google.com (mail-la0-f43.google.com. [209.85.215.43]) by mx.google.com with ESMTPS id q7si15417370lae.90.2015.09.02.17.08.10 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 02 Sep 2015 17:08:10 -0700 (PDT) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.215.43 as permitted sender) client-ip=209.85.215.43; Received: by lamp12 with SMTP id p12so16949291lam.0 for ; Wed, 02 Sep 2015 17:08:10 -0700 (PDT) X-Received: by 10.112.199.133 with SMTP id jk5mr19473229lbc.32.1441238889954; Wed, 02 Sep 2015 17:08:09 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.112.164.42 with SMTP id yn10csp909383lbb; Wed, 2 Sep 2015 17:08:09 -0700 (PDT) X-Received: by 10.140.201.7 with SMTP id w7mr24331231qha.46.1441238889114; Wed, 02 Sep 2015 17:08:09 -0700 (PDT) Received: from lists.linaro.org (lists.linaro.org. [54.225.227.206]) by mx.google.com with ESMTP id e133si2729654qhc.24.2015.09.02.17.08.08; Wed, 02 Sep 2015 17:08:09 -0700 (PDT) Received-SPF: pass (google.com: domain of lng-odp-bounces@lists.linaro.org designates 54.225.227.206 as permitted sender) client-ip=54.225.227.206; Received: by lists.linaro.org (Postfix, from userid 109) id 58DA761A05; Thu, 3 Sep 2015 00:08:08 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on ip-10-142-244-252 X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, URIBL_BLOCKED autolearn=disabled version=3.4.0 Received: from [127.0.0.1] (localhost [127.0.0.1]) by lists.linaro.org (Postfix) with ESMTP id B53DB61A02; Thu, 3 Sep 2015 00:07:35 +0000 (UTC) X-Original-To: lng-odp@lists.linaro.org Delivered-To: lng-odp@lists.linaro.org Received: by lists.linaro.org (Postfix, from userid 109) id 5AD7761A02; Thu, 3 Sep 2015 00:07:28 +0000 (UTC) Received: from mail-ob0-f176.google.com (mail-ob0-f176.google.com [209.85.214.176]) by lists.linaro.org (Postfix) with ESMTPS id 5F3D961A00 for ; Thu, 3 Sep 2015 00:07:27 +0000 (UTC) Received: by obcts10 with SMTP id ts10so22403474obc.1 for ; Wed, 02 Sep 2015 17:07:27 -0700 (PDT) X-Received: by 10.182.114.233 with SMTP id jj9mr22978975obb.22.1441238846880; Wed, 02 Sep 2015 17:07:26 -0700 (PDT) Received: from Ubuntu15.localdomain (cpe-24-28-70-239.austin.res.rr.com. [24.28.70.239]) by smtp.gmail.com with ESMTPSA id k5sm15601814oev.16.2015.09.02.17.07.26 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 02 Sep 2015 17:07:26 -0700 (PDT) From: Bill Fischofer To: lng-odp@lists.linaro.org, maxim.uvarov@linaro.org Date: Wed, 2 Sep 2015 19:07:15 -0500 Message-Id: <1441238841-25105-2-git-send-email-bill.fischofer@linaro.org> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1441238841-25105-1-git-send-email-bill.fischofer@linaro.org> References: <1441238841-25105-1-git-send-email-bill.fischofer@linaro.org> X-Topics: patch Subject: [lng-odp] [PATCH 1/7] linux-generic: schedule: correct schedule group handling X-BeenThere: lng-odp@lists.linaro.org X-Mailman-Version: 2.1.16 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: , List-Help: , List-Subscribe: , MIME-Version: 1.0 Errors-To: lng-odp-bounces@lists.linaro.org Sender: "lng-odp" X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: bill.fischofer@linaro.org X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.215.43 as permitted sender) smtp.mailfrom=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 Correct the range check on odp_schedule_group_destroy() and the associated handling of scheduler group names. Signed-off-by: Bill Fischofer --- platform/linux-generic/odp_schedule.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/platform/linux-generic/odp_schedule.c b/platform/linux-generic/odp_schedule.c index dc2d75f..d2543ad 100644 --- a/platform/linux-generic/odp_schedule.c +++ b/platform/linux-generic/odp_schedule.c @@ -178,7 +178,7 @@ int odp_schedule_init_global(void) odp_spinlock_init(&sched->grp_lock); for (i = 0; i < ODP_CONFIG_SCHED_GRPS; i++) { - memset(&sched->sched_grp[i].name, 0, ODP_SCHED_GROUP_NAME_LEN); + memset(sched->sched_grp[i].name, 0, ODP_SCHED_GROUP_NAME_LEN); sched->sched_grp[i].mask = thread_sched_grp_mask(i); } @@ -685,10 +685,10 @@ int odp_schedule_group_destroy(odp_schedule_group_t group) odp_spinlock_lock(&sched->grp_lock); if (group < ODP_CONFIG_SCHED_GRPS && - group > _ODP_SCHED_GROUP_NAMED && + group >= _ODP_SCHED_GROUP_NAMED && sched->sched_grp[group].name[0] != 0) { odp_thrmask_zero(sched->sched_grp[group].mask); - memset(&sched->sched_grp[group].name, 0, + memset(sched->sched_grp[group].name, 0, ODP_SCHED_GROUP_NAME_LEN); ret = 0; } else {