From patchwork Tue Nov 10 04:20:04 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bill Fischofer X-Patchwork-Id: 56276 Delivered-To: patch@linaro.org Received: by 10.112.155.196 with SMTP id vy4csp549599lbb; Mon, 9 Nov 2015 20:20:59 -0800 (PST) X-Received: by 10.50.79.229 with SMTP id m5mr24419123igx.6.1447129259747; Mon, 09 Nov 2015 20:20:59 -0800 (PST) Return-Path: Received: from lists.linaro.org (lists.linaro.org. [54.225.227.206]) by mx.google.com with ESMTP id a20si2305865ign.64.2015.11.09.20.20.59; Mon, 09 Nov 2015 20:20:59 -0800 (PST) Received-SPF: pass (google.com: domain of lng-odp-bounces@lists.linaro.org designates 54.225.227.206 as permitted sender) client-ip=54.225.227.206; Authentication-Results: mx.google.com; spf=pass (google.com: domain of lng-odp-bounces@lists.linaro.org designates 54.225.227.206 as permitted sender) smtp.mailfrom=lng-odp-bounces@lists.linaro.org; dkim=neutral (body hash did not verify) header.i=@linaro_org.20150623.gappssmtp.com Received: by lists.linaro.org (Postfix, from userid 109) id 2E08A61CF7; Tue, 10 Nov 2015 04:20:59 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on ip-10-142-244-252 X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_BL_SPAMCOP_NET, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, T_DKIM_INVALID, URIBL_BLOCKED autolearn=disabled version=3.4.0 Received: from [127.0.0.1] (localhost [127.0.0.1]) by lists.linaro.org (Postfix) with ESMTP id 4FFF361CDF; Tue, 10 Nov 2015 04:20:28 +0000 (UTC) X-Original-To: lng-odp@lists.linaro.org Delivered-To: lng-odp@lists.linaro.org Received: by lists.linaro.org (Postfix, from userid 109) id 227E261CB3; Tue, 10 Nov 2015 04:20:25 +0000 (UTC) Received: from mail-pa0-f47.google.com (mail-pa0-f47.google.com [209.85.220.47]) by lists.linaro.org (Postfix) with ESMTPS id 2EB7C61CB1 for ; Tue, 10 Nov 2015 04:20:24 +0000 (UTC) Received: by pacdm15 with SMTP id dm15so197097156pac.3 for ; Mon, 09 Nov 2015 20:20:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro_org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=gIWo/Q4zKa4xX1eF7YM9gdMf0JR2qIRT9BO7pbVzaIk=; b=LQxMawVsUsXF7FcsUaZsayALjNPllX2I/va7o9ACmRg180SEw3ePnTMoMNKNfDZKWK zmNLMThaL7/bX74f6V1k2GsyGsSYQUK1tWsNMnA2VrF05E4CnbcFaESAn+E/HxEPiljt R1gX7DVaHk2i5z5BR7wsLQspBQ7StJp56t2K9/skN8GLMlQt+rn6jX3/rWzY0s8R2TNg W3/TnmsVlRdO3hEULyLrfFksdsBlLf1RwY2rjZrAlSWGdSOm2dvq7rZFUcPB3CDmjtai xY9MPmPls5JCt7yXEfZTTabCd5cUZw+p4crtAg1EkhtX8wPiwrKE5pgrv8ogzlxWS58c LgTw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=gIWo/Q4zKa4xX1eF7YM9gdMf0JR2qIRT9BO7pbVzaIk=; b=EQv9k21SF2tjggGEVmaJxMoMpq/QQUvdZGf7u0PHy+An5uJb8zxSa/BuEhCWskt7o1 qbwHIy4cid9oP6vsIJewSxaj+zV80cgxYEAUjn2KQ6b9ZCNg/cCIjJuoqViXuWq03t9J APibz2FOpDd1NB6h8mlYTB5aoIvxDcDZ8V1aZ/1upTO15kQTe2Q7CIv4wdFG9whOj42M Gm+By/pI9LHjeD7AM6HdKqPNdE0qNPyj6NVyPzvc5rYAwRKa+iBPk3VSKmYYbWIziu+x w7SaLPzxW40hwTSkQVXRg3j4XzmQky54OMvbH0QO31Y/uvyGyJMhrj3RvxKOZQW6NXyQ vZKg== X-Gm-Message-State: ALoCoQm/cWyaL8W6EpRqHxZnZhFb6ni8DMbVcIfbb3HmCL0uYteB4lZN7O4SADliKHVjVG7EnOQx X-Received: by 10.66.248.106 with SMTP id yl10mr2365782pac.73.1447129223514; Mon, 09 Nov 2015 20:20:23 -0800 (PST) Received: from Ubuntu15.localdomain ([40.139.248.3]) by smtp.gmail.com with ESMTPSA id fl5sm1137315pbd.70.2015.11.09.20.20.22 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 09 Nov 2015 20:20:22 -0800 (PST) From: Bill Fischofer To: lng-odp@lists.linaro.org Date: Mon, 9 Nov 2015 20:20:04 -0800 Message-Id: <1447129211-9095-2-git-send-email-bill.fischofer@linaro.org> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1447129211-9095-1-git-send-email-bill.fischofer@linaro.org> References: <1447129211-9095-1-git-send-email-bill.fischofer@linaro.org> X-Topics: patch Subject: [lng-odp] [API-NEXT PATCHv3 1/8] linux-generic: schedule: move ordered lock routines to odp_schedule.c X-BeenThere: lng-odp@lists.linaro.org X-Mailman-Version: 2.1.16 Precedence: list List-Id: "The OpenDataPlane \(ODP\) List" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: lng-odp-bounces@lists.linaro.org Sender: "lng-odp" Move the odp_schedule_order_lock() and odp_schedule_order_unlock() routines from odp_queue.c to odp_schedule.c Signed-off-by: Bill Fischofer --- platform/linux-generic/odp_queue.c | 31 ------------------------ platform/linux-generic/odp_schedule.c | 45 ++++++++++++++++++++++++++++++----- 2 files changed, 39 insertions(+), 37 deletions(-) diff --git a/platform/linux-generic/odp_queue.c b/platform/linux-generic/odp_queue.c index 1c15e17..2071870 100644 --- a/platform/linux-generic/odp_queue.c +++ b/platform/linux-generic/odp_queue.c @@ -22,7 +22,6 @@ #include #include #include -#include #ifdef USE_TICKETLOCK #include @@ -1015,33 +1014,3 @@ int release_order(queue_entry_t *origin_qe, uint64_t order, UNLOCK(&origin_qe->s.lock); return 0; } - -void odp_schedule_order_lock(unsigned lock_index) -{ - queue_entry_t *origin_qe; - uint64_t *sync; - - get_sched_sync(&origin_qe, &sync, lock_index); - if (!origin_qe || lock_index >= origin_qe->s.param.sched.lock_count) - return; - - /* Wait until we are in order. Note that sync_out will be incremented - * both by unlocks as well as order resolution, so we're OK if only - * some events in the ordered flow need to lock. - */ - while (*sync > odp_atomic_load_u64(&origin_qe->s.sync_out[lock_index])) - odp_spin(); -} - -void odp_schedule_order_unlock(unsigned lock_index) -{ - queue_entry_t *origin_qe; - uint64_t *sync; - - get_sched_sync(&origin_qe, &sync, lock_index); - if (!origin_qe || lock_index >= origin_qe->s.param.sched.lock_count) - return; - - /* Release the ordered lock */ - odp_atomic_fetch_inc_u64(&origin_qe->s.sync_out[lock_index]); -} diff --git a/platform/linux-generic/odp_schedule.c b/platform/linux-generic/odp_schedule.c index 6df8073..195240e 100644 --- a/platform/linux-generic/odp_schedule.c +++ b/platform/linux-generic/odp_schedule.c @@ -22,6 +22,7 @@ #include #include +#include odp_thrmask_t sched_mask_all; @@ -793,6 +794,44 @@ void odp_schedule_prefetch(int num ODP_UNUSED) { } +void odp_schedule_order_lock(unsigned lock_index) +{ + queue_entry_t *origin_qe; + uint64_t sync, sync_out; + + origin_qe = sched_local.origin_qe; + if (!origin_qe || lock_index >= origin_qe->s.param.sched.lock_count) + return; + + sync = sched_local.sync[lock_index]; + sync_out = odp_atomic_load_u64(&origin_qe->s.sync_out[lock_index]); + ODP_ASSERT(sync >= sync_out); + + /* Wait until we are in order. Note that sync_out will be incremented + * both by unlocks as well as order resolution, so we're OK if only + * some events in the ordered flow need to lock. + */ + while (sync != sync_out) { + odp_spin(); + sync_out = + odp_atomic_load_u64(&origin_qe->s.sync_out[lock_index]); + } +} + +void odp_schedule_order_unlock(unsigned lock_index) +{ + queue_entry_t *origin_qe; + + origin_qe = sched_local.origin_qe; + if (!origin_qe || lock_index >= origin_qe->s.param.sched.lock_count) + return; + ODP_ASSERT(sched_local.sync[lock_index] == + odp_atomic_load_u64(&origin_qe->s.sync_out[lock_index])); + + /* Release the ordered lock */ + odp_atomic_fetch_inc_u64(&origin_qe->s.sync_out[lock_index]); +} + void sched_enq_called(void) { sched_local.enq_called = 1; @@ -804,12 +843,6 @@ void get_sched_order(queue_entry_t **origin_qe, uint64_t *order) *order = sched_local.order; } -void get_sched_sync(queue_entry_t **origin_qe, uint64_t **sync, uint32_t ndx) -{ - *origin_qe = sched_local.origin_qe; - *sync = &sched_local.sync[ndx]; -} - void sched_order_resolved(odp_buffer_hdr_t *buf_hdr) { if (buf_hdr)