From patchwork Fri Jan 8 16:35:40 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Zoltan Kiss X-Patchwork-Id: 59381 Delivered-To: patch@linaro.org Received: by 10.112.130.2 with SMTP id oa2csp662958lbb; Fri, 8 Jan 2016 08:36:02 -0800 (PST) X-Received: by 10.140.102.14 with SMTP id v14mr79853920qge.48.1452270962512; Fri, 08 Jan 2016 08:36:02 -0800 (PST) Return-Path: Received: from lists.linaro.org (lists.linaro.org. [54.225.227.206]) by mx.google.com with ESMTP id t80si3201408qki.10.2016.01.08.08.36.02; Fri, 08 Jan 2016 08:36:02 -0800 (PST) Received-SPF: pass (google.com: domain of lng-odp-bounces@lists.linaro.org designates 54.225.227.206 as permitted sender) client-ip=54.225.227.206; Authentication-Results: mx.google.com; spf=pass (google.com: domain of lng-odp-bounces@lists.linaro.org designates 54.225.227.206 as permitted sender) smtp.mailfrom=lng-odp-bounces@lists.linaro.org; dkim=neutral (body hash did not verify) header.i=@linaro.org Received: by lists.linaro.org (Postfix, from userid 109) id D98416176A; Fri, 8 Jan 2016 16:36:01 +0000 (UTC) Authentication-Results: lists.linaro.org; dkim=fail reason="verification failed; unprotected key" header.d=linaro.org header.i=@linaro.org header.b=DCXw70zH; dkim-adsp=none (unprotected policy); dkim-atps=neutral X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on ip-10-142-244-252 X-Spam-Level: X-Spam-Status: No, score=-2.5 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, T_DKIM_INVALID, URIBL_BLOCKED autolearn=disabled version=3.4.0 Received: from [127.0.0.1] (localhost [127.0.0.1]) by lists.linaro.org (Postfix) with ESMTP id 83E6D6172C; Fri, 8 Jan 2016 16:35:57 +0000 (UTC) X-Original-To: lng-odp@lists.linaro.org Delivered-To: lng-odp@lists.linaro.org Received: by lists.linaro.org (Postfix, from userid 109) id 39EAB615C9; Fri, 8 Jan 2016 16:35:56 +0000 (UTC) Received: from mail-wm0-f54.google.com (mail-wm0-f54.google.com [74.125.82.54]) by lists.linaro.org (Postfix) with ESMTPS id 541E6615C9 for ; Fri, 8 Jan 2016 16:35:55 +0000 (UTC) Received: by mail-wm0-f54.google.com with SMTP id f206so179688522wmf.0 for ; Fri, 08 Jan 2016 08:35:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:subject:date:message-id; bh=oPwGCYINFl32SSr93mEVI9ReCYMR3eJsk/ufDzURiH8=; b=DCXw70zHrAXdjnhfW/wqNmaSs7xm9be1lrCHt/+dI7NLuiMwBmGZe7+XhHEJa9v+fv Vs465NCWkcRDSEj8+2FriVVafoL+ZgZ4vlE8y3XiLlsKnw1b4t5RVt1jlSoFrPDLWix3 l6KgdZ4H5SARUgwlHTkqiBMqdZl5HeWtvQx68= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:subject:date:message-id; bh=oPwGCYINFl32SSr93mEVI9ReCYMR3eJsk/ufDzURiH8=; b=WwBmmNifTrbe904tWtw3LRd6mF5kVb8u4vNnQLgZEyT/ln4od1oPIvHtAsCPalTbe/ UVT6t++rMHsGFSPYKTGY1Z43Gblk5bdibl2W+jBglGj3zO7sd0fBUJpWgW9Osglhmvr9 3V4n1pxCVgEou4or6kQo33tR7fsslxeJNlOq6Lt1u/YYbsjuavVCB3vWxHt80PdHsWQm eIMpxWyNXNTULejmcU26495GNYeaGFjSwwpyIzj69VcSxy5e9Nw7jvxiOrwNHZT961HP HC4OnYhtwRmKGwSKGzEGd6pBLCsaajjcFvob7nRIU0o7Ekhmrs96ehjHJQfSozg8MH1s ODOQ== X-Gm-Message-State: ALoCoQkdoP9Og7Qj6+Qa/YC9bF5V07SNN9R0x9GxgE8ArG0VGjeFKS/4/tu1oe6UlXuOonmnyio4cJ5tCFkQ5bx/9u63IUaH9A== X-Received: by 10.28.128.215 with SMTP id b206mr25770039wmd.52.1452270954496; Fri, 08 Jan 2016 08:35:54 -0800 (PST) Received: from localhost.localdomain ([195.11.233.227]) by smtp.googlemail.com with ESMTPSA id 193sm19245358wmg.16.2016.01.08.08.35.53 for (version=TLSv1/SSLv3 cipher=OTHER); Fri, 08 Jan 2016 08:35:53 -0800 (PST) From: Zoltan Kiss To: lng-odp@lists.linaro.org Date: Fri, 8 Jan 2016 16:35:40 +0000 Message-Id: <1452270940-8973-1-git-send-email-zoltan.kiss@linaro.org> X-Mailer: git-send-email 1.9.1 X-Topics: patch Subject: [lng-odp] [API-NEXT PATCH] Revert "api: pool: add packet user area initializer for pool creation parameters" X-BeenThere: lng-odp@lists.linaro.org X-Mailman-Version: 2.1.16 Precedence: list List-Id: "The OpenDataPlane \(ODP\) List" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: lng-odp-bounces@lists.linaro.org Sender: "lng-odp" This reverts commit 798c450fc41ee4195977a5af855dbc98d8aaec16. The use case is not strong enough for this feature. Signed-off-by: Zoltan Kiss --- include/odp/api/packet.h | 3 --- include/odp/api/pool.h | 26 -------------------------- 2 files changed, 29 deletions(-) diff --git a/include/odp/api/packet.h b/include/odp/api/packet.h index 8651a47..9c63b5f 100644 --- a/include/odp/api/packet.h +++ b/include/odp/api/packet.h @@ -93,9 +93,6 @@ extern "C" { * @note The default headroom and tailroom used for packets is specified by * the ODP_CONFIG_PACKET_HEADROOM and ODP_CONFIG_PACKET_TAILROOM defines in * odp_config.h. - * @note Data changed in user area might be preserved by the platform from - * previous usage of the buffer, so values preset in uarea_init() are not - * guaranteed. */ odp_packet_t odp_packet_alloc(odp_pool_t pool, uint32_t len); diff --git a/include/odp/api/pool.h b/include/odp/api/pool.h index 01f770f..2e79a55 100644 --- a/include/odp/api/pool.h +++ b/include/odp/api/pool.h @@ -21,7 +21,6 @@ extern "C" { #include -#include /** @defgroup odp_pool ODP POOL * Operations on a pool. @@ -42,23 +41,6 @@ extern "C" { #define ODP_POOL_NAME_LEN 32 /** - * Packet user area initializer callback function for pools. - * - * @param pkt Handle of the packet - * @param uarea_init_arg Opaque pointer defined in odp_pool_param_t - * - * @note If the application specifies this pointer, it expects that every buffer - * is initialized exactly once with it when the underlying memory is allocated. - * It is not called from odp_packet_alloc(), unless the platform chooses to - * allocate the memory at that point. Applications can only assume that this - * callback is called once before the packet is first used. Any subsequent - * change to the user area might be preserved after odp_packet_free() is called, - * so applications should take care of (re)initialization if they change data - * preset by this function. - */ -typedef void (odp_packet_uarea_init_t)(odp_packet_t pkt, void *uarea_init_arg); - -/** * Pool parameters * Used to communicate pool creation options. */ @@ -100,14 +82,6 @@ typedef struct odp_pool_param_t { /** User area size in bytes. Specify as 0 if no user area is needed. */ uint32_t uarea_size; - - /** Initialize every packet's user area at allocation - time. Use NULL if no initialization needed. */ - odp_packet_uarea_init_t *uarea_init; - - /** Opaque pointer passed to packet user area - constructor. */ - void *uarea_init_arg; } pkt; struct { /** Number of timeouts in the pool */