From patchwork Mon Feb 22 22:46:38 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: gary.robertson@linaro.org X-Patchwork-Id: 62641 Delivered-To: patch@linaro.org Received: by 10.112.43.199 with SMTP id y7csp1514937lbl; Mon, 22 Feb 2016 14:47:54 -0800 (PST) X-Received: by 10.140.93.166 with SMTP id d35mr37183816qge.29.1456181274280; Mon, 22 Feb 2016 14:47:54 -0800 (PST) Return-Path: Received: from lists.linaro.org (lists.linaro.org. [54.225.227.206]) by mx.google.com with ESMTP id u5si8686753qkl.103.2016.02.22.14.47.54; Mon, 22 Feb 2016 14:47:54 -0800 (PST) Received-SPF: pass (google.com: domain of lng-odp-bounces@lists.linaro.org designates 54.225.227.206 as permitted sender) client-ip=54.225.227.206; Authentication-Results: mx.google.com; spf=pass (google.com: domain of lng-odp-bounces@lists.linaro.org designates 54.225.227.206 as permitted sender) smtp.mailfrom=lng-odp-bounces@lists.linaro.org Received: by lists.linaro.org (Postfix, from userid 109) id E6D8661773; Mon, 22 Feb 2016 22:47:53 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on ip-10-142-244-252 X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, URIBL_BLOCKED autolearn=disabled version=3.4.0 Received: from [127.0.0.1] (localhost [127.0.0.1]) by lists.linaro.org (Postfix) with ESMTP id 2BEED619D8; Mon, 22 Feb 2016 22:47:32 +0000 (UTC) X-Original-To: lng-odp@lists.linaro.org Delivered-To: lng-odp@lists.linaro.org Received: by lists.linaro.org (Postfix, from userid 109) id 50D61619D8; Mon, 22 Feb 2016 22:47:27 +0000 (UTC) Received: from mail-ob0-f180.google.com (mail-ob0-f180.google.com [209.85.214.180]) by lists.linaro.org (Postfix) with ESMTPS id A377C6175C for ; Mon, 22 Feb 2016 22:47:13 +0000 (UTC) Received: by mail-ob0-f180.google.com with SMTP id jq7so179770023obb.0 for ; Mon, 22 Feb 2016 14:47:13 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=difia0qzycoVT6VxyXEDNYMLp7zcIOY61/NQ6Lt5wyc=; b=kSEtp1GrhS+OAip4zV8bUSgzpmE+RRMQPdiKH9C7j1FrJLHcMG9OsglR190mOYCQez uoUsu2hxYhC33MbGsVjZKoGdf9oe//+XYhFwlam6O46hfHnz3zeYmqURnYc8uUBbGoAB uoIrhUqxUHYodSBFXB+nArcWy0cjrK2vsUYrSa2b+x1wq0StdBCjWvG2o8YyAGDx+wnn i44QP4AamQ3keLVNUXR/rK3mZdzYWdeZVfNv0ro7EedFeVt8YDSxCCdY7p3E1u4dVAgZ nzhCTc41wPSGNuO3WYs6kd1rJSdAUBUp2Q8DoRPqUrMT2IRHfGLM6XGIwln4KhaGHouP b7hQ== X-Gm-Message-State: AG10YOSXyaZg4KuLSHGIvZsopsVNwqpzbr514gJd38hpGRoGe+S5luxsE+vgSoY3YToIf31Itt0= X-Received: by 10.182.153.10 with SMTP id vc10mr24717466obb.10.1456181233162; Mon, 22 Feb 2016 14:47:13 -0800 (PST) Received: from honkintosh.cybertech.lan (65-120-133-114.dia.static.qwest.net. [65.120.133.114]) by smtp.googlemail.com with ESMTPSA id tu11sm18045413oec.13.2016.02.22.14.47.09 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 22 Feb 2016 14:47:12 -0800 (PST) From: "Gary S. Robertson" To: mike.holmes@linaro.org, bill.fischofer@linaro.org, maxim.uvarov@linaro.org, anders.roxell@linaro.org, petri.savolainen@linaro.org Date: Mon, 22 Feb 2016 16:46:38 -0600 Message-Id: <1456181199-29634-2-git-send-email-gary.robertson@linaro.org> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1456181199-29634-1-git-send-email-gary.robertson@linaro.org> References: <1456181199-29634-1-git-send-email-gary.robertson@linaro.org> X-Topics: patch Cc: lng-odp@lists.linaro.org Subject: [lng-odp] [PATCH V3 1/2] linux-generic: Correct worker count calculation in tests X-BeenThere: lng-odp@lists.linaro.org X-Mailman-Version: 2.1.16 Precedence: list List-Id: "The OpenDataPlane \(ODP\) List" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: lng-odp-bounces@lists.linaro.org Sender: "lng-odp" During the process of addressing Linaro BUG 2027 which relates to inaccurate reporting of available CPUs by ODP linux-generic when running atop a kernel compiled with NO_HZ_FULL support, a number of instances were encountered in the validation and performance test software where incorrect methods were used to determine the proper (or maximum) number of worker threads to create. The use of odp_cpu_count() for this purpose is incorrect and deprecated... odp_cpumask_default_worker() should always be used to determine the set and number of CPUs available for creating worker threads. The use of odp_cpu_count() for this purpose in conjunction with the correct means of determining available CPUs resulted in some tests hanging in calls to odp_barrier_wait() as the barriers were initialized to expect threads on ALL CPUs rather than on worker CPUs alone... and there were too few worker threads created to satisfy the barriers. The changes below correct all instances I could find of this depecated technique and allowed all tests to complete successfully with the BUG 2027 patch applied. (BTW they also run correctly without that patch after the application of the modifications included here.) Signed-off-by: Gary S. Robertson --- test/performance/odp_atomic.c | 9 ++++++--- test/validation/cpumask/cpumask.c | 2 +- test/validation/shmem/shmem.c | 5 ++++- test/validation/timer/timer.c | 16 +++++++++------- 4 files changed, 20 insertions(+), 12 deletions(-) diff --git a/test/performance/odp_atomic.c b/test/performance/odp_atomic.c index 067329b..7e2e22f 100644 --- a/test/performance/odp_atomic.c +++ b/test/performance/odp_atomic.c @@ -303,6 +303,8 @@ int odp_test_thread_exit(pthrd_arg *arg) /** test init globals and call odp_init_global() */ int odp_test_global_init(void) { + odp_cpumask_t unused; + memset(thread_tbl, 0, sizeof(thread_tbl)); if (odp_init_global(NULL, NULL)) { @@ -310,7 +312,8 @@ int odp_test_global_init(void) return -1; } - num_workers = odp_cpu_count(); + num_workers = odp_cpumask_default_worker(&unused, 0); + /* force to max CPU count */ if (num_workers > MAX_WORKERS) num_workers = MAX_WORKERS; @@ -378,7 +381,7 @@ int main(int argc, char *argv[]) goto err_exit; } if (test_type < TEST_MIX || test_type > TEST_MAX || - pthrdnum > odp_cpu_count() || pthrdnum < 0) { + pthrdnum > num_workers || pthrdnum < 0) { usage(); goto err_exit; } @@ -386,7 +389,7 @@ int main(int argc, char *argv[]) } if (pthrdnum == 0) - pthrdnum = odp_cpu_count(); + pthrdnum = num_workers; test_atomic_init(); test_atomic_store(); diff --git a/test/validation/cpumask/cpumask.c b/test/validation/cpumask/cpumask.c index 2419f47..1bb8f8d 100644 --- a/test/validation/cpumask/cpumask.c +++ b/test/validation/cpumask/cpumask.c @@ -67,7 +67,7 @@ void cpumask_test_odp_cpumask_def(void) mask_count = odp_cpumask_count(&mask); CU_ASSERT(mask_count == num_control); - CU_ASSERT(num_control == 1); + CU_ASSERT(num_control >= 1); CU_ASSERT(num_worker <= available_cpus); CU_ASSERT(num_worker > 0); } diff --git a/test/validation/shmem/shmem.c b/test/validation/shmem/shmem.c index 08425e6..be8bd6f 100644 --- a/test/validation/shmem/shmem.c +++ b/test/validation/shmem/shmem.c @@ -6,6 +6,8 @@ #include #include +#include + #include "shmem.h" #define ALIGE_SIZE (128) @@ -52,6 +54,7 @@ void shmem_test_odp_shm_sunnyday(void) pthrd_arg thrdarg; odp_shm_t shm; test_shared_data_t *test_shared_data; + odp_cpumask_t unused; shm = odp_shm_reserve(TESTNAME, sizeof(test_shared_data_t), ALIGE_SIZE, 0); @@ -70,7 +73,7 @@ void shmem_test_odp_shm_sunnyday(void) test_shared_data->foo = TEST_SHARE_FOO; test_shared_data->bar = TEST_SHARE_BAR; - thrdarg.numthrds = odp_cpu_count(); + thrdarg.numthrds = odp_cpumask_default_worker(&unused, 0); if (thrdarg.numthrds > MAX_WORKERS) thrdarg.numthrds = MAX_WORKERS; diff --git a/test/validation/timer/timer.c b/test/validation/timer/timer.c index 004670a..bee3e8d 100644 --- a/test/validation/timer/timer.c +++ b/test/validation/timer/timer.c @@ -15,6 +15,7 @@ #include #include +#include #include "odp_cunit_common.h" #include "test_debug.h" #include "timer.h" @@ -41,12 +42,6 @@ static odp_atomic_u32_t ndelivtoolate; * caches may make this number lower than the capacity of the pool */ static odp_atomic_u32_t timers_allocated; -/** @private min() function */ -static int min(int a, int b) -{ - return a < b ? a : b; -} - /* @private Timer helper structure */ struct test_timer { odp_timer_t tim; /* Timer handle */ @@ -457,10 +452,17 @@ void timer_test_odp_timer_all(void) int rc; odp_pool_param_t params; odp_timer_pool_param_t tparam; + odp_cpumask_t unused; + /* Reserve at least one core for running other processes so the timer * test hopefully can run undisturbed and thus get better timing * results. */ - int num_workers = min(odp_cpu_count() - 1, MAX_WORKERS); + int num_workers = odp_cpumask_default_worker(&unused, 0); + + /* force to max CPU count */ + if (num_workers > MAX_WORKERS) + num_workers = MAX_WORKERS; + /* On a single-CPU machine run at least one thread */ if (num_workers < 1) num_workers = 1;