From patchwork Wed Apr 27 00:17:14 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bill Fischofer X-Patchwork-Id: 66753 Delivered-To: patch@linaro.org Received: by 10.140.93.198 with SMTP id d64csp1899223qge; Tue, 26 Apr 2016 17:17:26 -0700 (PDT) X-Received: by 10.50.22.65 with SMTP id b1mr7092794igf.39.1461716246773; Tue, 26 Apr 2016 17:17:26 -0700 (PDT) Return-Path: Received: from lists.linaro.org (lists.linaro.org. [54.225.227.206]) by mx.google.com with ESMTP id pz3si26010357igc.8.2016.04.26.17.17.26; Tue, 26 Apr 2016 17:17:26 -0700 (PDT) Received-SPF: pass (google.com: domain of lng-odp-bounces@lists.linaro.org designates 54.225.227.206 as permitted sender) client-ip=54.225.227.206; Authentication-Results: mx.google.com; spf=pass (google.com: domain of lng-odp-bounces@lists.linaro.org designates 54.225.227.206 as permitted sender) smtp.mailfrom=lng-odp-bounces@lists.linaro.org; dmarc=pass (p=NONE dis=NONE) header.from=linaro.org Received: by lists.linaro.org (Postfix, from userid 109) id 013FE610D4; Wed, 27 Apr 2016 00:17:25 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on ip-10-142-244-252 X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, URIBL_BLOCKED autolearn=disabled version=3.4.0 Received: from [127.0.0.1] (localhost [127.0.0.1]) by lists.linaro.org (Postfix) with ESMTP id D00B460ACB; Wed, 27 Apr 2016 00:17:21 +0000 (UTC) X-Original-To: lng-odp@lists.linaro.org Delivered-To: lng-odp@lists.linaro.org Received: by lists.linaro.org (Postfix, from userid 109) id DE39861069; Wed, 27 Apr 2016 00:17:19 +0000 (UTC) Received: from mail-ob0-f181.google.com (mail-ob0-f181.google.com [209.85.214.181]) by lists.linaro.org (Postfix) with ESMTPS id 056F960765 for ; Wed, 27 Apr 2016 00:17:18 +0000 (UTC) Received: by mail-ob0-f181.google.com with SMTP id n10so13422903obb.2 for ; Tue, 26 Apr 2016 17:17:17 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=KnGo8ZxaURjYEuLKiEkT5WATpUTYNoX2k52Zr1Xh+Tw=; b=L7RgsEXUc2t5wPpYW8GjqC1Da+rN2YiSz80e6xgOLx3E7E1hbTFSoeheTg6u4DbKOV vbNEK83EQIppxuOq3cd5ZQWDidLdxFhVm751eGzABxBvhx5JMSfvHp31c0XFQlkRTbhP 01JF/7iMWXB+MTwcJnLWdaKwwHMAzyMu9adslvPi2hOxV486Z4zETyiUmRl8pxtOlNn/ wTNQ4MfNWChtg2EpeqIB3eq8p3InSmzJ+pcMyUelRmjgyTJxSTQNaek31n7Nou+IYOdJ YQbl0YmdVBCd6PCZ7pqBBZQ7n6Zlgyu+PgXr+CppGNRlu8kAhbplU0VoJ3JEzpKRVBqy 5qFQ== X-Gm-Message-State: AOPr4FVyMoQ4l0AXsmch52CzEA/89AFb1Wh2wgq2a6gfeSQDFH/oDuzNqoAeaOc53EslA0drZqY= X-Received: by 10.182.75.134 with SMTP id c6mr2410500obw.29.1461716237424; Tue, 26 Apr 2016 17:17:17 -0700 (PDT) Received: from Ubuntu15.localdomain (cpe-66-68-129-43.austin.res.rr.com. [66.68.129.43]) by smtp.gmail.com with ESMTPSA id fi5sm527891oeb.5.2016.04.26.17.17.16 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 26 Apr 2016 17:17:16 -0700 (PDT) From: Bill Fischofer To: lng-odp@lists.linaro.org Date: Tue, 26 Apr 2016 19:17:14 -0500 Message-Id: <1461716234-31105-1-git-send-email-bill.fischofer@linaro.org> X-Mailer: git-send-email 2.5.0 X-Topics: patch Subject: [lng-odp] [API-NEXT PATCH] validation: packet: add missing error flag tests X-BeenThere: lng-odp@lists.linaro.org X-Mailman-Version: 2.1.16 Precedence: list List-Id: "The OpenDataPlane \(ODP\) List" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: lng-odp-bounces@lists.linaro.org Sender: "lng-odp" Add touch tests for the following APIs: odp_packet_has_l2_error() odp_packet_has_l3_error() odp_packet_has_l4_error() Signed-off-by: Bill Fischofer Reviewed-by: Balasubramanian Manoharan --- test/validation/packet/packet.c | 15 ++++++++++++--- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/test/validation/packet/packet.c b/test/validation/packet/packet.c index 4b9da46..180250a 100644 --- a/test/validation/packet/packet.c +++ b/test/validation/packet/packet.c @@ -627,12 +627,21 @@ void packet_test_error_flags(void) int err; /** - * The packet have not been classified so it doesn't have error flag - * properly set. Just check that function return one of allowed values. - * @todo: check classified packet when classifier is added in place. + * The packet have not been classified so it doesn't have error flags + * properly set. Just check that functions return one of allowed values. + * @todo: try with known good and bad packets. */ err = odp_packet_has_error(pkt); CU_ASSERT(err == 0 || err == 1); + + err = odp_packet_has_l2_error(pkt); + CU_ASSERT(err == 0 || err == 1); + + err = odp_packet_has_l3_error(pkt); + CU_ASSERT(err == 0 || err == 1); + + err = odp_packet_has_l4_error(pkt); + CU_ASSERT(err == 0 || err == 1); } struct packet_metadata {