From patchwork Fri Aug 25 10:00:05 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Github ODP bot X-Patchwork-Id: 110977 Delivered-To: patch@linaro.org Received: by 10.37.128.210 with SMTP id c18csp723476ybm; Fri, 25 Aug 2017 03:02:41 -0700 (PDT) X-Received: by 10.237.59.207 with SMTP id s15mr13454084qte.340.1503655361568; Fri, 25 Aug 2017 03:02:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1503655361; cv=none; d=google.com; s=arc-20160816; b=S9K7BXnLFQ1LTr2RDnzW+EwQvuDoFuot7cGPrWGIdTtRydrbpCviiYBnl6XDvO/3rt 8hEH9T8m9QRq7+pnwaxbjLD++ku+RsrVGQcgkTEjYb+4koBvGai9hHZxfXiSHGie+/Rf 1W3kQ9nlezxbPKJ8Ucv+LMf1cPqK1JOb3OZPi0yvokmDyCfsD6rcLguTZkruuCU6wDLa s/2gn/1uxzs59qDdcQuyfAa0c8zzI1x96a3rQokZDcsqD32lzHCgv1fkoOQhsNW4+FjL G2wYdmEHwHMOudIjBIvQ2WoEFswX3nI601anUAZZ6qpp8EdB01YbsE+oaDnxBXsGey7U i5zQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject:github-pr-num :references:in-reply-to:message-id:date:to:from:delivered-to :arc-authentication-results; bh=Bksx4h8o/ky9tpWbJZjwXuiwcZWTjJTgd+wcd1sbP88=; b=ixAlbaaGVkM7T4rDeBGoKjSlN2z0uFRRx1ewi9dWFeHfqlt3B7Z3MJ+80BF96Vmpc2 oFiaucTVH/tiROb8SIEGd+SlZxAliaXasHYW1LbsVNwA0ffeDS+QrNLzCtuHjiHb2B9u BRY0mG5W+fGMiXdriPlXdAhZhZ3aRbYLE2NfaKwP5G49J+bHRoEd7SyWaNwDdGs4B5sS VwMwIXbg2uGXqy2kkNupLmYhbihd5jv4jpjUKKAt0SvWtbXz046KXEBRbi+SU0Gi9EjT 6sWFaQBqdBzKpO8e73u+n1yA8YuggUMwRIR1ar/PwBYFuAyqxiXyEccjQ1VrUbEMOVCw NWaA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of lng-odp-bounces@lists.linaro.org designates 54.225.227.206 as permitted sender) smtp.mailfrom=lng-odp-bounces@lists.linaro.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=yandex.ru Return-Path: Received: from lists.linaro.org (lists.linaro.org. [54.225.227.206]) by mx.google.com with ESMTP id r70si5679655qki.51.2017.08.25.03.02.41; Fri, 25 Aug 2017 03:02:41 -0700 (PDT) Received-SPF: pass (google.com: domain of lng-odp-bounces@lists.linaro.org designates 54.225.227.206 as permitted sender) client-ip=54.225.227.206; Authentication-Results: mx.google.com; spf=pass (google.com: domain of lng-odp-bounces@lists.linaro.org designates 54.225.227.206 as permitted sender) smtp.mailfrom=lng-odp-bounces@lists.linaro.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=yandex.ru Received: by lists.linaro.org (Postfix, from userid 109) id 3AD8465BFF; Fri, 25 Aug 2017 10:02:41 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on ip-10-142-244-252 X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,URIBL_BLOCKED autolearn=disabled version=3.4.0 Received: from [127.0.0.1] (localhost [127.0.0.1]) by lists.linaro.org (Postfix) with ESMTP id A1CF465C07; Fri, 25 Aug 2017 10:00:51 +0000 (UTC) X-Original-To: lng-odp@lists.linaro.org Delivered-To: lng-odp@lists.linaro.org Received: by lists.linaro.org (Postfix, from userid 109) id 1310E65BF8; Fri, 25 Aug 2017 10:00:33 +0000 (UTC) Received: from forward101p.mail.yandex.net (forward101p.mail.yandex.net [77.88.28.101]) by lists.linaro.org (Postfix) with ESMTPS id CC0FA65BF4 for ; Fri, 25 Aug 2017 10:00:29 +0000 (UTC) Received: from mxback13g.mail.yandex.net (mxback13g.mail.yandex.net [IPv6:2a02:6b8:0:1472:2741:0:8b7:92]) by forward101p.mail.yandex.net (Yandex) with ESMTP id A659A6A8357F for ; Fri, 25 Aug 2017 13:00:26 +0300 (MSK) Received: from smtp2j.mail.yandex.net (smtp2j.mail.yandex.net [2a02:6b8:0:801::ac]) by mxback13g.mail.yandex.net (nwsmtp/Yandex) with ESMTP id FnFaxqyBAB-0QTWGU2B; Fri, 25 Aug 2017 13:00:26 +0300 Received: by smtp2j.mail.yandex.net (nwsmtp/Yandex) with ESMTPSA id irVIP3ZZaC-0QriH6Qa; Fri, 25 Aug 2017 13:00:26 +0300 (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (Client certificate not present) From: Github ODP bot To: lng-odp@lists.linaro.org Date: Fri, 25 Aug 2017 13:00:05 +0300 Message-Id: <1503655207-26292-2-git-send-email-odpbot@yandex.ru> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1503655207-26292-1-git-send-email-odpbot@yandex.ru> References: <1503655207-26292-1-git-send-email-odpbot@yandex.ru> Github-pr-num: 132 Subject: [lng-odp] [PATCH v5 1/3] helper: chksum: odph_chksum returns value in network byte order X-BeenThere: lng-odp@lists.linaro.org X-Mailman-Version: 2.1.16 Precedence: list List-Id: "The OpenDataPlane \(ODP\) List" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: lng-odp-bounces@lists.linaro.org Sender: "lng-odp" From: Dmitry Eremin-Solenikov All examples and usecases assumed network byte order for odph_chksum() return value. Instead of changing this convention, rather document that odph_chksum returns value in network byte order. Signed-off-by: Dmitry Eremin-Solenikov --- /** Email created from pull request 132 (lumag:fix-checksum) ** https://github.com/Linaro/odp/pull/132 ** Patch: https://github.com/Linaro/odp/pull/132.patch ** Base sha: 8705e548f330d23173283fcca62f4afb835a6380 ** Merge commit sha: 7ad532c561535935fe0e51774755fcd4c5bb7ebc **/ helper/include/odp/helper/chksum.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/helper/include/odp/helper/chksum.h b/helper/include/odp/helper/chksum.h index 520e9275..1bf950c8 100644 --- a/helper/include/odp/helper/chksum.h +++ b/helper/include/odp/helper/chksum.h @@ -40,7 +40,7 @@ typedef enum { * @param buffer calculate chksum for buffer * @param len buffer length * - * @return checksum value in host cpu order + * @return checksum value in network order */ static inline odp_u16sum_t odph_chksum(void *buffer, int len) {