From patchwork Tue Oct 10 14:00:14 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Github ODP bot X-Patchwork-Id: 115404 Delivered-To: patch@linaro.org Received: by 10.140.22.163 with SMTP id 32csp3793292qgn; Tue, 10 Oct 2017 07:03:53 -0700 (PDT) X-Google-Smtp-Source: AOwi7QCHPwyYBXljtpXI24kmNz/rVZItHFMg9Hpizb2y7ZZtQLrGC0my5bRf7mKmxnaTi+7+OStY X-Received: by 10.36.204.137 with SMTP id x131mr10254038itf.94.1507644232954; Tue, 10 Oct 2017 07:03:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1507644232; cv=none; d=google.com; s=arc-20160816; b=hstLTAPv8Qvp/ewtwP7oyOFDUhvAtnJNRbyi4QLBVc1E+kmIzBM1pr54k2e+HTOtcc 7SC66KbXJb1h6Q44LFx86obI1HBSurWPPKQaBMT5yywal/rVZ8qktS4hDaH8vxq5Q/KB 5trtFwnjl9gemrRl8UJ+5FrS7QzmP7egtLs37kL8pn1Cia7e7XVXtJRmCW8dNuObeinV ABMlspdPjt3rAjJ66UMqakUsaeMPHZ30fSb/7nTICdlS5K7V/l4Iv7XjZgaAttE2P3Je nO2XbQtlrfbLSTxhoVVMgciKKal1wUPSteGXFDu6XlQvvourR7FvH54C9JniN2gL8M7v GAmQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject:github-pr-num :references:in-reply-to:message-id:date:to:from:delivered-to :arc-authentication-results; bh=nqu+oy6Ym/zUjGWyLGNRGJE4RXeiER5Lo5Y41CBvy98=; b=yNcwSO8Dvuj5XnvDaUbM/dg5mORa8ZYU1E93H2/KV2RUF8jdw29gqggF3yT0Sa/YO3 L55zQ3dQBZfqnN0DISvotmhRRUnZsDlLxqPH24IH8sG4O0nbZX4mtJ8YOAvBX+/suB8v 793HpEqH492/1uC96STU6jY0vPc3XdORBxmO0vaMpCsq0cbJHi7NVHle5Y8v6JEiPup/ aFD3kPuEDxDEQfNDNNBRRQkW6TtQzkaPH2bldhMM4Wy7XwPG5veliQ6uNV7u3/cprVVU hIHEjPj2l5wtFv0wh98A+NHXY6UUytzR4Add7ttUbudwLdv0iUi/xksxbYMsX9ZoNfN4 T1WA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of lng-odp-bounces@lists.linaro.org designates 54.197.127.237 as permitted sender) smtp.mailfrom=lng-odp-bounces@lists.linaro.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=yandex.ru Return-Path: Received: from lists.linaro.org (ec2-54-197-127-237.compute-1.amazonaws.com. [54.197.127.237]) by mx.google.com with ESMTP id u2si8378392ioe.239.2017.10.10.07.03.50; Tue, 10 Oct 2017 07:03:52 -0700 (PDT) Received-SPF: pass (google.com: domain of lng-odp-bounces@lists.linaro.org designates 54.197.127.237 as permitted sender) client-ip=54.197.127.237; Authentication-Results: mx.google.com; spf=pass (google.com: domain of lng-odp-bounces@lists.linaro.org designates 54.197.127.237 as permitted sender) smtp.mailfrom=lng-odp-bounces@lists.linaro.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=yandex.ru Received: by lists.linaro.org (Postfix, from userid 109) id 276E162875; Tue, 10 Oct 2017 14:03:50 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on ip-10-142-244-252 X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,URIBL_BLOCKED autolearn=disabled version=3.4.0 Received: from [127.0.0.1] (localhost [127.0.0.1]) by lists.linaro.org (Postfix) with ESMTP id C2D4E60D44; Tue, 10 Oct 2017 14:01:07 +0000 (UTC) X-Original-To: lng-odp@lists.linaro.org Delivered-To: lng-odp@lists.linaro.org Received: by lists.linaro.org (Postfix, from userid 109) id 374F360D2C; Tue, 10 Oct 2017 14:00:55 +0000 (UTC) Received: from forward102j.mail.yandex.net (forward102j.mail.yandex.net [5.45.198.243]) by lists.linaro.org (Postfix) with ESMTPS id 60F11606B4 for ; Tue, 10 Oct 2017 14:00:46 +0000 (UTC) Received: from mxback16j.mail.yandex.net (mxback16j.mail.yandex.net [IPv6:2a02:6b8:0:1619::92]) by forward102j.mail.yandex.net (Yandex) with ESMTP id 815895604032 for ; Tue, 10 Oct 2017 17:00:43 +0300 (MSK) Received: from smtp3o.mail.yandex.net (smtp3o.mail.yandex.net [2a02:6b8:0:1a2d::27]) by mxback16j.mail.yandex.net (nwsmtp/Yandex) with ESMTP id riBPwnUf3n-0h9Cnrfi; Tue, 10 Oct 2017 17:00:43 +0300 Received: by smtp3o.mail.yandex.net (nwsmtp/Yandex) with ESMTPSA id VhNutoZVyT-0guOYAFe; Tue, 10 Oct 2017 17:00:42 +0300 (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (Client certificate not present) From: Github ODP bot To: lng-odp@lists.linaro.org Date: Tue, 10 Oct 2017 17:00:14 +0300 Message-Id: <1507644014-13917-3-git-send-email-odpbot@yandex.ru> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1507644014-13917-1-git-send-email-odpbot@yandex.ru> References: <1507644014-13917-1-git-send-email-odpbot@yandex.ru> Github-pr-num: 188 Subject: [lng-odp] [PATCH v6 2/2] test: make odp_pktio_perf more scalable X-BeenThere: lng-odp@lists.linaro.org X-Mailman-Version: 2.1.16 Precedence: list List-Id: "The OpenDataPlane \(ODP\) List" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: lng-odp-bounces@lists.linaro.org Sender: "lng-odp" From: Ola Liljedahl Amortise overhead of atomic increment over multiple packets so to minimise this scalability bottleneck. Signed-off-by: Ola Liljedahl Reviewed-by: Brian Brooks Jira: ENTNET-487 Change-Id: Idefb23da5d9b9b9c2c82eb46533cdf82dc19442e --- /** Email created from pull request 188 (WonderfulVoid:master) ** https://github.com/Linaro/odp/pull/188 ** Patch: https://github.com/Linaro/odp/pull/188.patch ** Base sha: 3bacbfd55edf76b897a4b2e5c62b59ca6fa95331 ** Merge commit sha: 63cba8b410fd2e58a1d373bea42a956639022782 **/ test/common_plat/performance/odp_pktio_perf.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/test/common_plat/performance/odp_pktio_perf.c b/test/common_plat/performance/odp_pktio_perf.c index e13a850a3..b749ee9b9 100644 --- a/test/common_plat/performance/odp_pktio_perf.c +++ b/test/common_plat/performance/odp_pktio_perf.c @@ -167,14 +167,13 @@ static test_globals_t *gbl_args; /* * Generate a single test packet for transmission. */ -static odp_packet_t pktio_create_packet(void) +static odp_packet_t pktio_create_packet(uint32_t seq) { odp_packet_t pkt; odph_ethhdr_t *eth; odph_ipv4hdr_t *ip; odph_udphdr_t *udp; char *buf; - uint16_t seq; uint32_t offset; pkt_head_t pkt_hdr; size_t payload_len; @@ -209,7 +208,6 @@ static odp_packet_t pktio_create_packet(void) ODPH_IPV4HDR_LEN); ip->ttl = 128; ip->proto = ODPH_IPPROTO_UDP; - seq = odp_atomic_fetch_inc_u32(&ip_seq); ip->id = odp_cpu_to_be_16(seq); ip->chksum = 0; odph_ipv4_csum_update(pkt); @@ -261,9 +259,11 @@ static int pktio_pkt_has_magic(odp_packet_t pkt) static int alloc_packets(odp_packet_t *pkt_tbl, int num_pkts) { int n; + uint16_t seq; + seq = odp_atomic_fetch_add_u32(&ip_seq, num_pkts); for (n = 0; n < num_pkts; ++n) { - pkt_tbl[n] = pktio_create_packet(); + pkt_tbl[n] = pktio_create_packet(seq + n); if (pkt_tbl[n] == ODP_PACKET_INVALID) break; }