From patchwork Tue Oct 17 19:00:00 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Github ODP bot X-Patchwork-Id: 116158 Delivered-To: patch@linaro.org Received: by 10.140.22.163 with SMTP id 32csp5237449qgn; Tue, 17 Oct 2017 12:03:12 -0700 (PDT) X-Google-Smtp-Source: AOwi7QCcUPSN5GHJoaVdnA8oSXZ/8AxO8jEj3p+cFbTBNXHta8C3yr2yNj6GSNfCnsbXLEfDCp5r X-Received: by 10.55.198.209 with SMTP id s78mr18192713qkl.143.1508266992749; Tue, 17 Oct 2017 12:03:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1508266992; cv=none; d=google.com; s=arc-20160816; b=yKMNyDrqCcVgsPzkyJK+Jq3unPKl4GNdnHAs6HJZgc//VS9ycRByMiyYU9qVMJqG4k kPlJFbGq2CnAYZF357qvOQbCBUsDAJM4Zsz/ghUtCP/+oyWAmgNE3vyzfKdLG3HBeQ1Q k5mVmF8VOWdgWIuzPX4j/KVhqC7RNy8ZOPQhhztiv56uMyXgNP0vVJB/BRSk7PpJra9S v/Vu08EL+/s4Xfa/BmU7wSJYUgpBiRNnoM/1bzzNybRzexhKq4YDlbMhj8qLxrFN53OB QE/fUMac3Ntv/XLUkLsYmBpwS24BiF00/XvjpRbJq3im8LA06HQ3UFJEoc78w9nUFO2O STYA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject:github-pr-num :references:in-reply-to:message-id:date:to:from:delivered-to :arc-authentication-results; bh=2BY2qdsyllwA84b78xIHv/Pdb9yYJ/61UModPGtk2c4=; b=RcIjrrNGMlb2OKrb3S5bjb4hp2h9BHnE9d37/fF6Jef//cuAEpGzUs/IynVr5crXn7 Hc9pABBWtoYpVSR+48LzFNdNZMzFbIKjc+uwsVNs9o04a0e41uoHJZoiUr8C6U+rW1QR gcKn05AhMO9kq2Lohnwif8E3rPBjjm2OBJniu4UqE2872ZYvY+/ERAsbZMHAhyclyAti 7Io87lnujWCvYYp78TZMJvGF76hqPwunt5vQ3pptV/hbn/pkl9/zZKqLRCphytBkzYd+ bGjRFhDPDpSnoA4d3kvTLoCmaC/Pxjg/F2iYoRPq+mLCz7De7SE+3mPXPXk9ivim1g0y t4cw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of lng-odp-bounces@lists.linaro.org designates 54.197.127.237 as permitted sender) smtp.mailfrom=lng-odp-bounces@lists.linaro.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=yandex.ru Return-Path: Received: from lists.linaro.org (ec2-54-197-127-237.compute-1.amazonaws.com. [54.197.127.237]) by mx.google.com with ESMTP id k28si3306964qkh.430.2017.10.17.12.03.06; Tue, 17 Oct 2017 12:03:12 -0700 (PDT) Received-SPF: pass (google.com: domain of lng-odp-bounces@lists.linaro.org designates 54.197.127.237 as permitted sender) client-ip=54.197.127.237; Authentication-Results: mx.google.com; spf=pass (google.com: domain of lng-odp-bounces@lists.linaro.org designates 54.197.127.237 as permitted sender) smtp.mailfrom=lng-odp-bounces@lists.linaro.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=yandex.ru Received: by lists.linaro.org (Postfix, from userid 109) id 6471562AE9; Tue, 17 Oct 2017 19:03:06 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on ip-10-142-244-252 X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,URIBL_BLOCKED autolearn=disabled version=3.4.0 Received: from [127.0.0.1] (localhost [127.0.0.1]) by lists.linaro.org (Postfix) with ESMTP id 02D43628FE; Tue, 17 Oct 2017 19:00:27 +0000 (UTC) X-Original-To: lng-odp@lists.linaro.org Delivered-To: lng-odp@lists.linaro.org Received: by lists.linaro.org (Postfix, from userid 109) id 169E2628DF; Tue, 17 Oct 2017 19:00:19 +0000 (UTC) Received: from forward103p.mail.yandex.net (forward103p.mail.yandex.net [77.88.28.106]) by lists.linaro.org (Postfix) with ESMTPS id DD84C61E02 for ; Tue, 17 Oct 2017 19:00:14 +0000 (UTC) Received: from mxback13j.mail.yandex.net (mxback13j.mail.yandex.net [IPv6:2a02:6b8:0:1619::88]) by forward103p.mail.yandex.net (Yandex) with ESMTP id 52E382183F2A for ; Tue, 17 Oct 2017 22:00:13 +0300 (MSK) Received: from smtp2p.mail.yandex.net (smtp2p.mail.yandex.net [2a02:6b8:0:1472:2741:0:8b6:7]) by mxback13j.mail.yandex.net (nwsmtp/Yandex) with ESMTP id j4FWPVjLvz-0DE8e4wO; Tue, 17 Oct 2017 22:00:13 +0300 Received: by smtp2p.mail.yandex.net (nwsmtp/Yandex) with ESMTPSA id QgPN3KZgI2-0CuWY5L3; Tue, 17 Oct 2017 22:00:12 +0300 (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (Client certificate not present) From: Github ODP bot To: lng-odp@lists.linaro.org Date: Tue, 17 Oct 2017 22:00:00 +0300 Message-Id: <1508266806-12588-5-git-send-email-odpbot@yandex.ru> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1508266806-12588-1-git-send-email-odpbot@yandex.ru> References: <1508266806-12588-1-git-send-email-odpbot@yandex.ru> Github-pr-num: 235 Subject: [lng-odp] [PATCH v2 4/10] configure: cleanup per-platform if X-BeenThere: lng-odp@lists.linaro.org X-Mailman-Version: 2.1.16 Precedence: list List-Id: "The OpenDataPlane \(ODP\) List" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: lng-odp-bounces@lists.linaro.org Sender: "lng-odp" From: Dmitry Eremin-Solenikov Move setting IMPLEMENTATION_NAME to platform configure.m4. Use AS_IF instead of handcoded if. Use AC_MSG_ERROR instead of echo & exit. Signed-off-by: Dmitry Eremin-Solenikov --- /** Email created from pull request 235 (lumag:plat-def-2) ** https://github.com/Linaro/odp/pull/235 ** Patch: https://github.com/Linaro/odp/pull/235.patch ** Base sha: ec0c3145fcafa09ae3a79875e7e07dd4794583cc ** Merge commit sha: 9783e8a21510c37c97bc377ad9b5b2f83aa4b842 **/ configure.ac | 12 +++--------- platform/linux-generic/m4/configure.m4 | 2 ++ 2 files changed, 5 insertions(+), 9 deletions(-) diff --git a/configure.ac b/configure.ac index 442c85db4..c419df0f6 100644 --- a/configure.ac +++ b/configure.ac @@ -165,15 +165,9 @@ AC_SUBST([with_platform]) ########################################################################## # Run platform specific checks and settings ########################################################################## -IMPLEMENTATION_NAME="" -if test "${with_platform}" = "linux-generic"; -then - m4_include([./platform/linux-generic/m4/configure.m4]) - IMPLEMENTATION_NAME="odp-linux" -else - echo "UNSUPPORTED PLATFORM: ${with_platform}" - exit 1 -fi +AS_IF([test "${with_platform}" = "linux-generic"], + [m4_include([./platform/linux-generic/m4/configure.m4])], + [AC_MSG_ERROR([UNSUPPORTED PLATFORM: ${with_platform}])]) AC_DEFINE_UNQUOTED([IMPLEMENTATION_NAME], ["$IMPLEMENTATION_NAME"], [Define to the name of the implementation]) diff --git a/platform/linux-generic/m4/configure.m4 b/platform/linux-generic/m4/configure.m4 index 68a270d89..5d7ad35a1 100644 --- a/platform/linux-generic/m4/configure.m4 +++ b/platform/linux-generic/m4/configure.m4 @@ -1,3 +1,5 @@ +IMPLEMENTATION_NAME="odp-linux" + ODP_VISIBILITY ODP_ATOMIC