From patchwork Mon Jan 15 13:00:07 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Github ODP bot X-Patchwork-Id: 124519 Delivered-To: patch@linaro.org Received: by 10.46.64.148 with SMTP id r20csp662072lje; Mon, 15 Jan 2018 05:05:59 -0800 (PST) X-Google-Smtp-Source: ACJfBotYExgZwUAkVxDOQUd/5+io5stw7GufVIRi+DD2xecNLWRKthTEV0gONqp4PmBHqvFe4MMB X-Received: by 10.237.52.162 with SMTP id x31mr7570087qtd.6.1516021559578; Mon, 15 Jan 2018 05:05:59 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1516021559; cv=none; d=google.com; s=arc-20160816; b=w7rOM80TL+0d2E4IBChbfTAGQ2YXCulLcuc0Pb7zUZXtpu1QnRl0cvMYslUecto/E+ PqGvOk6i/LSFEnLGjv8KZtyiAWxy+ZiImCz0S0PaFiFyNzB6OHI+1SwiymbPYp/HRTzk k21BpbwjIMH8n48M7W25f1JZLGqqgQc6cXmkRBrFwMUD7uaaVbZoMUGKw2vhSICG3j7z rP2ghtrTsiiADyavsbYSRHDfgRUx99qn2HYXXHG7hH6yrVGDakS1wytWWkMZjhD33yAD hag3tbiCxHmZyHNfZfH0BwWZDFyOM2krMmG4VGmSp7ftZsrOGT/qf7G+EUTfZ6HVZxT4 lOZw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject:github-pr-num :references:in-reply-to:message-id:date:to:from:delivered-to :arc-authentication-results; bh=qbcPNmYnbvxa6aJaNeNSXAblgIyPbeEcLPqIu9LYty8=; b=sBx6UUaMKMJ3yMzOFk/rKMkdqIrMFiTaFzlpEApF90/kKqlB9qbJMPpQ35gAxf8vdZ H9dW226WN3i89/Rxzs/kqZfPn6fAT4pSiIFEJBa1txDlaaBACvwzKcjignNP4L/O8i3O rS6pMf0PXVRp2uAGTE0bTMKdvCdXNcFwE40sj4RegklnkIPz45h+sE/6n9XER7YbxvPc 9tUjaMTV7XAq4+VHik9VgVGFbLaflTRM86y6ibUAnwQS3dw+NMGSCAF7M/gov3h/dR4x M06qfnXKTSufwRqij3rcdGsGac3FCH2E+CGjJRzx9nUvFxUW+oyYdT/jlEev1FZHEH5F sn7Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of lng-odp-bounces@lists.linaro.org designates 54.197.127.237 as permitted sender) smtp.mailfrom=lng-odp-bounces@lists.linaro.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=yandex.ru Return-Path: Received: from lists.linaro.org (ec2-54-197-127-237.compute-1.amazonaws.com. [54.197.127.237]) by mx.google.com with ESMTP id m42si3511326qtf.9.2018.01.15.05.05.59; Mon, 15 Jan 2018 05:05:59 -0800 (PST) Received-SPF: pass (google.com: domain of lng-odp-bounces@lists.linaro.org designates 54.197.127.237 as permitted sender) client-ip=54.197.127.237; Authentication-Results: mx.google.com; spf=pass (google.com: domain of lng-odp-bounces@lists.linaro.org designates 54.197.127.237 as permitted sender) smtp.mailfrom=lng-odp-bounces@lists.linaro.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=yandex.ru Received: by lists.linaro.org (Postfix, from userid 109) id 384FA617AD; Mon, 15 Jan 2018 13:05:59 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on ip-10-142-244-252 X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2 autolearn=disabled version=3.4.0 Received: from [127.0.0.1] (localhost [127.0.0.1]) by lists.linaro.org (Postfix) with ESMTP id 0BDE060956; Mon, 15 Jan 2018 13:03:56 +0000 (UTC) X-Original-To: lng-odp@lists.linaro.org Delivered-To: lng-odp@lists.linaro.org Received: by lists.linaro.org (Postfix, from userid 109) id 679C2617B9; Mon, 15 Jan 2018 13:03:47 +0000 (UTC) Received: from forward100p.mail.yandex.net (forward100p.mail.yandex.net [77.88.28.100]) by lists.linaro.org (Postfix) with ESMTPS id 0A2F16152C for ; Mon, 15 Jan 2018 13:00:15 +0000 (UTC) Received: from mxback8g.mail.yandex.net (mxback8g.mail.yandex.net [IPv6:2a02:6b8:0:1472:2741:0:8b7:169]) by forward100p.mail.yandex.net (Yandex) with ESMTP id BF88751018BD for ; Mon, 15 Jan 2018 16:00:13 +0300 (MSK) Received: from smtp3o.mail.yandex.net (smtp3o.mail.yandex.net [2a02:6b8:0:1a2d::27]) by mxback8g.mail.yandex.net (nwsmtp/Yandex) with ESMTP id iGpuSJV8Dl-0Dta8vB3; Mon, 15 Jan 2018 16:00:13 +0300 Received: by smtp3o.mail.yandex.net (nwsmtp/Yandex) with ESMTPSA id Bnqb3pkuSH-0D1q8rpJ; Mon, 15 Jan 2018 16:00:13 +0300 (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (Client certificate not present) From: Github ODP bot To: lng-odp@lists.linaro.org Date: Mon, 15 Jan 2018 16:00:07 +0300 Message-Id: <1516021209-8997-5-git-send-email-odpbot@yandex.ru> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1516021209-8997-1-git-send-email-odpbot@yandex.ru> References: <1516021209-8997-1-git-send-email-odpbot@yandex.ru> Github-pr-num: 388 Subject: [lng-odp] [PATCH API-NEXT v2 4/6] api: packet: initialize user ptr to NULL X-BeenThere: lng-odp@lists.linaro.org X-Mailman-Version: 2.1.16 Precedence: list List-Id: "The OpenDataPlane \(ODP\) List" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: lng-odp-bounces@lists.linaro.org Sender: "lng-odp" From: Petri Savolainen Require that implementation initializes the pointer value to NULL. Application can use the pointer more robustly when it can tell if the pointer has been set previously or not. Signed-off-by: Petri Savolainen --- /** Email created from pull request 388 (psavol:next-user-ptr-init) ** https://github.com/Linaro/odp/pull/388 ** Patch: https://github.com/Linaro/odp/pull/388.patch ** Base sha: 6303c7d0e98fafe0f14c8c4dd9989b3b7633ebf4 ** Merge commit sha: 76bd874ba5677533132a4c0a39c8e5cf9049a9af **/ include/odp/api/spec/packet.h | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/include/odp/api/spec/packet.h b/include/odp/api/spec/packet.h index 3655f5899..8aca552f6 100644 --- a/include/odp/api/spec/packet.h +++ b/include/odp/api/spec/packet.h @@ -1341,7 +1341,10 @@ int odp_packet_input_index(odp_packet_t pkt); /** * User context pointer * - * Return previously stored user context pointer. + * Return previously stored user context pointer. If not otherwise documented, + * the pointer value is maintained over packet manipulating operations. + * Implementation initializes the pointer value to NULL during new packet + * creation (e.g. alloc and packet input) and reset. * * @param pkt Packet handle * @@ -1357,10 +1360,10 @@ void *odp_packet_user_ptr(odp_packet_t pkt); * value of type intptr_t. ODP may use the pointer for data prefetching, but * must ignore any invalid addresses. * - * @param pkt Packet handle - * @param ctx User context pointer + * @param pkt Packet handle + * @param user_ptr User context pointer */ -void odp_packet_user_ptr_set(odp_packet_t pkt, const void *ctx); +void odp_packet_user_ptr_set(odp_packet_t pkt, const void *user_ptr); /** * User area address