From patchwork Thu Nov 14 11:56:23 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: kim-phillips X-Patchwork-Id: 21496 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-gg0-f197.google.com (mail-gg0-f197.google.com [209.85.161.197]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 3DA6823FDD for ; Thu, 14 Nov 2013 11:56:29 +0000 (UTC) Received: by mail-gg0-f197.google.com with SMTP id e5sf2804609ggk.0 for ; Thu, 14 Nov 2013 03:56:28 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:delivered-to:date:from:to:cc:subject:message-id :in-reply-to:references:mime-version:x-original-sender :x-original-authentication-results:precedence:mailing-list:list-id :list-post:list-help:list-archive:list-unsubscribe:content-type :content-transfer-encoding; bh=cGnRKMvR250DlXYMqIx6VmjF0vQgdKexCZ7ajOKNDUY=; b=KiJY1jknN2uwU09tCDCXDVlV8TGKFLqlq/SPqFzQg1VLdme+KIgZoLYC1vYTQVtr/u 65M3ncu3NmS91m8vfkbyxXAMTxt8z5nJEQUL6eLkpXV9eqEV2L8glApwWgIAddguyBs6 DYMRD75yNpKxd0slTiXMyF+W3zLQl4yxnzD74UkaYGVo+u+HbY3+U+HBGGP5tLtUhqXG KbLyc6W3gUHKvGdlkxmvsOkE4totIAX8w0Zqyk4nxTp2aLy8AVvnU63bZtx4R9jjOmVI ogL9UxMGm1mxslT0ImRmvYjnvWT+bl1udH7ltb1JPVQwF8wEslTFgXzn1IS9PDz8pMvn R/HQ== X-Gm-Message-State: ALoCoQn/4QHoiCLH1GNkudyn5uVndXGSOseTPq82BwBSN4z4L68GG96O3lFeMIs/unU9Rz4vnezg X-Received: by 10.236.129.194 with SMTP id h42mr555732yhi.11.1384430188579; Thu, 14 Nov 2013 03:56:28 -0800 (PST) X-BeenThere: patchwork-forward@linaro.org Received: by 10.49.83.72 with SMTP id o8ls1044785qey.0.gmail; Thu, 14 Nov 2013 03:56:28 -0800 (PST) X-Received: by 10.52.244.109 with SMTP id xf13mr319708vdc.81.1384430188481; Thu, 14 Nov 2013 03:56:28 -0800 (PST) Received: from mail-ve0-f180.google.com (mail-ve0-f180.google.com [209.85.128.180]) by mx.google.com with ESMTPS id ch11si16952058ved.63.2013.11.14.03.56.28 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 14 Nov 2013 03:56:28 -0800 (PST) Received-SPF: neutral (google.com: 209.85.128.180 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) client-ip=209.85.128.180; Received: by mail-ve0-f180.google.com with SMTP id db12so1731912veb.11 for ; Thu, 14 Nov 2013 03:56:28 -0800 (PST) X-Received: by 10.58.210.39 with SMTP id mr7mr442262vec.18.1384430188373; Thu, 14 Nov 2013 03:56:28 -0800 (PST) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patches@linaro.org Received: by 10.220.174.196 with SMTP id u4csp310055vcz; Thu, 14 Nov 2013 03:56:27 -0800 (PST) X-Received: by 10.205.15.72 with SMTP id pt8mr1167720bkb.17.1384430187033; Thu, 14 Nov 2013 03:56:27 -0800 (PST) Received: from mail-bk0-f45.google.com (mail-bk0-f45.google.com [209.85.214.45]) by mx.google.com with ESMTPS id rk5si479921bkb.79.2013.11.14.03.56.26 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 14 Nov 2013 03:56:26 -0800 (PST) Received-SPF: neutral (google.com: 209.85.214.45 is neither permitted nor denied by best guess record for domain of kim.phillips@linaro.org) client-ip=209.85.214.45; Received: by mail-bk0-f45.google.com with SMTP id r7so984301bkg.18 for ; Thu, 14 Nov 2013 03:56:26 -0800 (PST) X-Received: by 10.205.73.7 with SMTP id yq7mr821739bkb.164.1384430186172; Thu, 14 Nov 2013 03:56:26 -0800 (PST) Received: from ntel ([2.29.127.85]) by mx.google.com with ESMTPSA id zl3sm2725244bkb.4.2013.11.14.03.56.24 for (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 14 Nov 2013 03:56:25 -0800 (PST) Date: Thu, 14 Nov 2013 11:56:23 +0000 From: Kim Phillips To: mike.holmes@linaro.org Cc: lng-odp@linaro.org, maxim.uvarov@linaro.org, patches@linaro.org, petri.savolainen@linaro.org Subject: Re: [lng-odp] [PATCH] Added initial ODP files Message-Id: <20131114115623.bebfcd6b64f65da9e63a8bc1@linaro.org> In-Reply-To: <32f51075-e74a-4236-b84f-4cdd06d06cee@linaro.org> References: <1384273939-25340-1-git-send-email-maxim.uvarov@linaro.org> <20131113120056.a38c4d372f35aa2da1306401@linaro.org> <32f51075-e74a-4236-b84f-4cdd06d06cee@linaro.org> X-Mailer: Sylpheed 3.4.0beta5 (GTK+ 2.24.20; x86_64-pc-linux-gnu) Mime-Version: 1.0 X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: kim.phillips@linaro.org X-Original-Authentication-Results: mx.google.com; spf=neutral (google.com: 209.85.128.180 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Precedence: list Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org List-ID: X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , On Wed, 13 Nov 2013 09:18:44 -0800 (PST) Mike Holmes wrote: > On Wednesday, November 13, 2013 7:00:56 AM UTC-5, Kim Phillips wrote: > > > > On Tue, 12 Nov 2013 20:32:19 +0400 > > Maxim Uvarov > wrote: > > > > > create mode 100644 odp/test/odp_test_api.c > > > > so everything goes under odp/? is there a reason this doesn't go under > > the root directory? The header files have arch-independence built-in, > > and so should belong under a generic include directory, such as > > ${ODP_ROOT}/include. > > > > There is a document that is aimed at migrating the current structure to > what we want it to be. where? Even so, why can't we start with this patch? After all, patches supercede/override documents, IMO :) > > > +SOURCE_TOOLTIPS = YES > > > > this gives me: > > > > Warning: ignoring unsupported tag `SOURCE_TOOLTIPS =' at line 928, > > file Doxyfile > > > > So to avoid things like that, can we reduce this humungous file to only > > assign the necessary settings, and leave all the rest to their defaults? > > > In long association with doxygen, it warns about many things, it quietly > does a good job of working anyway. if it's issuing warnings it's not quiet. Our objective should be *zero* warnings, and this type of warning can easily be suppressed, so we should aim to silence it. > I believe we should maintain our > definition in full and file to keep pace with the latest version of doxygen > and put the full definition in git. that's just it: I'm assuming I'm using a different version of doxygen than the one used to generate the doxygen configuration file - something users shouldn't have to care about. > I do not think we want to start fussing over tool flags in this file, I > think the config should be taken as updated by doxygen its self when you > run an old config on a new version of the tool. I'm not fussing over tool flags themselves, rather how to gen a config file. Done some experimenting: should be a matter of: that would be in need of constant updating, and still issuing warnings depending on users particular doxygen versions. Kim diff --git a/odp/arch/linux-generic/Makefile b/odp/arch/linux-generic/Makefile index e86aebc..7c82c43 100644 --- a/odp/arch/linux-generic/Makefile +++ b/odp/arch/linux-generic/Makefile @@ -103,7 +103,11 @@ clean: rm -rf $(DOC_DIR) -$(DOC_FILE): ./Doxyfile ./odp.h +$(DOC_FILE): ./odp.h + doxygen -g + echo PROJECT_NAME = "OpenDataPlane API" >> Doxyfile + echo QUIET = YES >> Doxyfile + # blah, blah...rest of odp specific configs go here doxygen there, that's *much* simpler than adding a 2000 line static Doxyfile