From patchwork Wed Oct 12 18:42:14 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Mike Holmes X-Patchwork-Id: 77586 Delivered-To: patch@linaro.org Received: by 10.140.97.247 with SMTP id m110csp571552qge; Wed, 12 Oct 2016 11:43:07 -0700 (PDT) X-Received: by 10.200.43.233 with SMTP id n38mr2498564qtn.139.1476297787849; Wed, 12 Oct 2016 11:43:07 -0700 (PDT) Return-Path: Received: from lists.linaro.org (lists.linaro.org. [54.225.227.206]) by mx.google.com with ESMTP id p63si1793982qka.60.2016.10.12.11.43.07; Wed, 12 Oct 2016 11:43:07 -0700 (PDT) Received-SPF: pass (google.com: domain of lng-odp-bounces@lists.linaro.org designates 54.225.227.206 as permitted sender) client-ip=54.225.227.206; Authentication-Results: mx.google.com; spf=pass (google.com: domain of lng-odp-bounces@lists.linaro.org designates 54.225.227.206 as permitted sender) smtp.mailfrom=lng-odp-bounces@lists.linaro.org; dmarc=pass (p=NONE dis=NONE) header.from=linaro.org Received: by lists.linaro.org (Postfix, from userid 109) id 81BDE60878; Wed, 12 Oct 2016 18:43:07 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on ip-10-142-244-252 X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL autolearn=disabled version=3.4.0 Received: from [127.0.0.1] (localhost [127.0.0.1]) by lists.linaro.org (Postfix) with ESMTP id 2B953609DB; Wed, 12 Oct 2016 18:42:47 +0000 (UTC) X-Original-To: lng-odp@lists.linaro.org Delivered-To: lng-odp@lists.linaro.org Received: by lists.linaro.org (Postfix, from userid 109) id 1100C60862; Wed, 12 Oct 2016 18:42:43 +0000 (UTC) Received: from mail-it0-f47.google.com (mail-it0-f47.google.com [209.85.214.47]) by lists.linaro.org (Postfix) with ESMTPS id DB607616DA for ; Wed, 12 Oct 2016 18:42:35 +0000 (UTC) Received: by mail-it0-f47.google.com with SMTP id o19so62959849ito.1 for ; Wed, 12 Oct 2016 11:42:35 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=IJiFyTKo8vvKcKXmRBuNsFkNBBiGhbz3emB4dYuCYKs=; b=JI6J+yuhSyUr2s7sXpT6GTrn6QdpVf79PND1sJ41+N15a59ijb86bhaRrNg8HW7ygr VDMFMI5Ltm6SLi8yiNQSafGaJapHTwvKBsnS7qSTWb/kA3e/Uf7TXtf8uzIKwe5Yli6S 7yxcBTWSbuhBL9wiaCUV3l2Kmfsh7C0o1/AqHZnyhejiRJ4KXBn67P+OpcyD30VQxc2X VFhlf2XJHabiZ7PRfZoH4bMTflUthOwIqbOJz/uvBRE87rF07N6gwkuQzqRWhJJu2j8E /PfDsOvb2geREF1ePG5Lyr/JZpxsD6XT6cETw9SayZzBh2rZvKJfbsXRhz0S52TBwk9g XyWA== X-Gm-Message-State: AA6/9RldZ734S4Xsa/dkux/PHMbV7eOSBcbbc775M7b7c0BQeKsVaIdbVg6OTJ643iivbUmr+wIEInk563ylFPC+fYU= X-Received: by 10.36.53.130 with SMTP id k124mr3926155ita.38.1476297755355; Wed, 12 Oct 2016 11:42:35 -0700 (PDT) MIME-Version: 1.0 Received: by 10.79.98.194 with HTTP; Wed, 12 Oct 2016 11:42:14 -0700 (PDT) In-Reply-To: <57E3EB9F.6090306@linaro.org> References: <1473788140-27294-1-git-send-email-mike.holmes@linaro.org> <57E3EB9F.6090306@linaro.org> From: Mike Holmes Date: Wed, 12 Oct 2016 14:42:14 -0400 Message-ID: To: Maxim Uvarov X-Content-Filtered-By: Mailman/MimeDel 2.1.16 X-Topics: patch Cc: lng-odp Subject: Re: [lng-odp] [PATCH] example: generator: actually use specified default X-BeenThere: lng-odp@lists.linaro.org X-Mailman-Version: 2.1.16 Precedence: list List-Id: "The OpenDataPlane \(ODP\) List" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: lng-odp-bounces@lists.linaro.org Sender: "lng-odp" On 22 September 2016 at 10:33, Maxim Uvarov wrote: > Reverted this patch due to have issues with performance/odp_l2fwd The patch is correct I think, the intended default is not being honored. If the odp_l2fwd app depends on the incorrect behavior and actually requires a flood, that needs a patch to specify the behavior it actually needs. I did not see the failure on my platform, so I cannot confirm this, but I think this will do it I will post the pair as a new series. > > > Maxim. > > On 09/14/16 05:50, Bill Fischofer wrote: > >> On Tue, Sep 13, 2016 at 12:35 PM, Mike Holmes >> wrote: >> >> The help states default is 1000ms. 0 for flood mode, however the >>> default was incorrectly set to zero. >>> >>> Signed-off-by: Mike Holmes >>> >>> Reviewed-by: Bill Fischofer >> >> >> --- >>> example/generator/odp_generator.c | 1 + >>> 1 file changed, 1 insertion(+) >>> >>> diff --git a/example/generator/odp_generator.c b/example/generator/odp_ >>> generator.c >>> index b0053b9..48d7f5f 100644 >>> --- a/example/generator/odp_generator.c >>> +++ b/example/generator/odp_generator.c >>> @@ -946,6 +946,7 @@ static void parse_args(int argc, char *argv[], >>> appl_args_t *appl_args) >>> appl_args->number = -1; >>> appl_args->payload = 56; >>> appl_args->timeout = -1; >>> + appl_args->interval = DEFAULT_PKT_INTERVAL; >>> >>> opterr = 0; /* do not issue errors on helper options */ >>> >>> -- >>> 2.7.4 >>> >>> >>> > -- Mike Holmes Program Manager - Linaro Networking Group Linaro.org *│ *Open source software for ARM SoCs "Work should be fun and collaborative, the rest follows" diff --git a/test/common_plat/performance/odp_l2fwd_run.sh b/test/common_plat/performance/odp_l2fwd_run.sh index e64aa47..757cf53 100755 --- a/test/common_plat/performance/odp_l2fwd_run.sh +++ b/test/common_plat/performance/odp_l2fwd_run.sh @@ -32,6 +32,8 @@ TEST_SKIPPED=77 PLATFORM_VALIDATION=${TEST_SRC_DIR}/../../$ODP_PLATFORM/validation +FLOOD_MODE=0 + # Use installed pktio env or for make check take it from platform directory if [ -f "./pktio_env" ]; then . ./pktio_env @@ -66,7 +68,7 @@ run_l2fwd() #@todo: limit odp_generator to cores #https://bugs.linaro.org/show_bug.cgi?id=1398 - (odp_generator${EXEEXT} -I $IF0 \ + (odp_generator${EXEEXT} --interval $FLOOD_MODE -I $IF0 \ --srcip 192.168.0.1 --dstip 192.168.0.2 \ -m u 2>&1 > /dev/null) \ 2>&1 > /dev/null &