From patchwork Thu May 14 15:55:45 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mike Holmes X-Patchwork-Id: 48511 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-la0-f72.google.com (mail-la0-f72.google.com [209.85.215.72]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id C430E21411 for ; Thu, 14 May 2015 15:55:57 +0000 (UTC) Received: by lagr1 with SMTP id r1sf4867446lag.3 for ; Thu, 14 May 2015 08:55:56 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:delivered-to:delivered-to:mime-version :in-reply-to:references:date:message-id:from:to:content-type:cc :subject:precedence:list-id:list-unsubscribe:list-archive:list-post :list-help:list-subscribe:errors-to:sender:x-original-sender :x-original-authentication-results:mailing-list; bh=cNfd4X1TBMaN+8hEQb+157YxQ0FWj4HNaxggJ0puUbg=; b=FQ+DtHwW1SZoV4I+5cOHP8VXR1UkDV93NHSkhTAhkT7pOlHpDpAJc9l66/r+LsESYV LTH1ArAT8jcpqyVbK3lHH6V+PnY8XeVUxFxtCw/juEd93qxLiqd2i9mlt5n1ejxdMTzI NTUGaXEt8cWOSnzJtuh5m/yrBFwHHlsp9ckMdX1dJwv0OOd+VYudjBqNf4ZuCu5/r4yc P8ZJ6rpw6WVGSXw2qU5ajgTuiEQarLth7wVKAuCOfksIJ7lq3dOmvEzgISxHZksILUkr tTFz2bjz8M/WYcQzuuvBXGCRpy8rP+IoP5m6fxrwl1i1pN+B8XShUrpGUYajrQVBUCd9 qVQw== X-Gm-Message-State: ALoCoQnkG6PBTsAPxdUBoyLNPMuT/oOXTJqgtGgCTWpYM9fPbbvGMlwimQBnoAQvE/Ka/pyIDaUM X-Received: by 10.180.216.12 with SMTP id om12mr9591794wic.1.1431618956781; Thu, 14 May 2015 08:55:56 -0700 (PDT) X-BeenThere: patchwork-forward@linaro.org Received: by 10.152.245.43 with SMTP id xl11ls436981lac.21.gmail; Thu, 14 May 2015 08:55:56 -0700 (PDT) X-Received: by 10.112.204.6 with SMTP id ku6mr3733920lbc.73.1431618956604; Thu, 14 May 2015 08:55:56 -0700 (PDT) Received: from mail-la0-f43.google.com (mail-la0-f43.google.com. [209.85.215.43]) by mx.google.com with ESMTPS id g2si14806472laa.128.2015.05.14.08.55.56 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 14 May 2015 08:55:56 -0700 (PDT) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.215.43 as permitted sender) client-ip=209.85.215.43; Received: by laat2 with SMTP id t2so74053996laa.1 for ; Thu, 14 May 2015 08:55:56 -0700 (PDT) X-Received: by 10.112.199.133 with SMTP id jk5mr3859877lbc.32.1431618956419; Thu, 14 May 2015 08:55:56 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.112.108.230 with SMTP id hn6csp1365781lbb; Thu, 14 May 2015 08:55:55 -0700 (PDT) X-Received: by 10.140.164.6 with SMTP id k6mr6580453qhk.15.1431618954540; Thu, 14 May 2015 08:55:54 -0700 (PDT) Received: from lists.linaro.org (lists.linaro.org. [54.225.227.206]) by mx.google.com with ESMTP id i206si23462882qhc.13.2015.05.14.08.55.53; Thu, 14 May 2015 08:55:54 -0700 (PDT) Received-SPF: pass (google.com: domain of lng-odp-bounces@lists.linaro.org designates 54.225.227.206 as permitted sender) client-ip=54.225.227.206; Received: by lists.linaro.org (Postfix, from userid 109) id 5DBDD61FE7; Thu, 14 May 2015 15:55:53 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on ip-10-142-244-252.ec2.internal X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,HTML_MESSAGE, RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,URIBL_BLOCKED autolearn=disabled version=3.4.0 Received: from ip-10-142-244-252.ec2.internal (localhost [127.0.0.1]) by lists.linaro.org (Postfix) with ESMTP id 34F8A61FD0; Thu, 14 May 2015 15:55:51 +0000 (UTC) X-Original-To: lng-odp@lists.linaro.org Delivered-To: lng-odp@lists.linaro.org Received: by lists.linaro.org (Postfix, from userid 109) id 6132561FE5; Thu, 14 May 2015 15:55:48 +0000 (UTC) Received: from mail-ob0-f179.google.com (mail-ob0-f179.google.com [209.85.214.179]) by lists.linaro.org (Postfix) with ESMTPS id 54CDA61FD0 for ; Thu, 14 May 2015 15:55:46 +0000 (UTC) Received: by obfe9 with SMTP id e9so56094729obf.1 for ; Thu, 14 May 2015 08:55:45 -0700 (PDT) MIME-Version: 1.0 X-Received: by 10.60.37.166 with SMTP id z6mr4157608oej.63.1431618945850; Thu, 14 May 2015 08:55:45 -0700 (PDT) Received: by 10.76.71.40 with HTTP; Thu, 14 May 2015 08:55:45 -0700 (PDT) In-Reply-To: <1431618231-883-1-git-send-email-zoltan.kiss@linaro.org> References: <1431618231-883-1-git-send-email-zoltan.kiss@linaro.org> Date: Thu, 14 May 2015 11:55:45 -0400 Message-ID: From: Mike Holmes To: Zoltan Kiss X-Topics: patch Cc: lng-odp Subject: Re: [lng-odp] [PATCH] generic: external EXTRA_FLAGS overwrites script default X-BeenThere: lng-odp@lists.linaro.org X-Mailman-Version: 2.1.16 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: , List-Help: , List-Subscribe: , Errors-To: lng-odp-bounces@lists.linaro.org Sender: "lng-odp" X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: mike.holmes@linaro.org X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.215.43 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 Patches for the check-odp scrips are easier to identify if we use --subject-prefix="check-odp PATCH" I locally added a PERF_TEST flag in the environment to disable PERF, not fully tested but attached for consideration since it works in a way aligned with all the other flags to the script. On 14 May 2015 at 11:43, Zoltan Kiss wrote: > The previous patch just added the values defined by the caller, this patch > changes behaviour to overwrite the script default entirely. Not everyone > wants > the perf tests to run on make check. > > Signed-off-by: Zoltan Kiss > --- > helper/generic | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/helper/generic b/helper/generic > index aa1b10a..1dbb41f 100644 > --- a/helper/generic > +++ b/helper/generic > @@ -3,7 +3,7 @@ > export SRCDIR=${ROOT_DIR}/src > export BUILDDIR=${ROOT_DIR}/build > export LOGDIR=${ROOT_DIR}/log > -export EXTRA_FLAGS="${EXTRA_FLAGS} --enable-test-perf" > +export EXTRA_FLAGS="${EXTRA_FLAGS:- --enable-test-perf}" > > mkdir -p ${SRCDIR} > mkdir -p ${BUILDDIR} > -- > 1.9.1 > > _______________________________________________ > lng-odp mailing list > lng-odp@lists.linaro.org > https://lists.linaro.org/mailman/listinfo/lng-odp > >From fb7274ef5bd95e08136b1178eb72c009fe733702 Mon Sep 17 00:00:00 2001 From: Mike Holmes Date: Thu, 14 May 2015 11:53:58 -0400 Subject: [PATCH] optional perf testing Signed-off-by: Mike Holmes --- build.sh | 1 + helper/generic | 3 +++ 2 files changed, 4 insertions(+) diff --git a/build.sh b/build.sh index 2f69bc0..58ff1b0 100755 --- a/build.sh +++ b/build.sh @@ -93,6 +93,7 @@ usage() { echo -e "\tCLANG:\t\t build with clang, default: 0" echo -e "\tEXIT_ON_ERROR:\t bail out on error, default: 1" echo -e "\tCPP_TEST:\t enable cpp test, default: 0" + echo -e "\tPERF_TEST:\t enable perf test, default: 1" echo -e "\tDISTCHECK:\tset to 1 to enable DISTCHECK build, default: 0" echo -e "\tE_VALGRIND:\t run Valgrind, default: 0" ${PLATFORM_SHORT}_usage diff --git a/helper/generic b/helper/generic index aa1b10a..9d428a1 100644 --- a/helper/generic +++ b/helper/generic @@ -3,7 +3,10 @@ export SRCDIR=${ROOT_DIR}/src export BUILDDIR=${ROOT_DIR}/build export LOGDIR=${ROOT_DIR}/log +export PERF_TEST="${PERF_TEST:-1}" +if [[ ${PERF_TEST} -eq 1 ]]; then export EXTRA_FLAGS="${EXTRA_FLAGS} --enable-test-perf" +fi mkdir -p ${SRCDIR} mkdir -p ${BUILDDIR} -- 2.1.4