From patchwork Thu Nov 24 20:12:51 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anders Roxell X-Patchwork-Id: 83991 Delivered-To: patch@linaro.org Received: by 10.140.20.101 with SMTP id 92csp227325qgi; Thu, 24 Nov 2016 12:13:02 -0800 (PST) X-Received: by 10.55.6.11 with SMTP id 11mr3291462qkg.29.1480018382830; Thu, 24 Nov 2016 12:13:02 -0800 (PST) Return-Path: Received: from lists.linaro.org (lists.linaro.org. [54.225.227.206]) by mx.google.com with ESMTP id p11si15885950qte.219.2016.11.24.12.13.02; Thu, 24 Nov 2016 12:13:02 -0800 (PST) Received-SPF: pass (google.com: domain of lng-odp-bounces@lists.linaro.org designates 54.225.227.206 as permitted sender) client-ip=54.225.227.206; Authentication-Results: mx.google.com; spf=pass (google.com: domain of lng-odp-bounces@lists.linaro.org designates 54.225.227.206 as permitted sender) smtp.mailfrom=lng-odp-bounces@lists.linaro.org; dmarc=pass (p=NONE dis=NONE) header.from=linaro.org Received: by lists.linaro.org (Postfix, from userid 109) id 58271611FE; Thu, 24 Nov 2016 20:13:02 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on ip-10-142-244-252 X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2 autolearn=disabled version=3.4.0 Received: from [127.0.0.1] (localhost [127.0.0.1]) by lists.linaro.org (Postfix) with ESMTP id 3D8D160CAD; Thu, 24 Nov 2016 20:12:58 +0000 (UTC) X-Original-To: lng-odp@lists.linaro.org Delivered-To: lng-odp@lists.linaro.org Received: by lists.linaro.org (Postfix, from userid 109) id 1EC8660CAE; Thu, 24 Nov 2016 20:12:56 +0000 (UTC) Received: from mail-io0-f176.google.com (mail-io0-f176.google.com [209.85.223.176]) by lists.linaro.org (Postfix) with ESMTPS id A2E4760C93 for ; Thu, 24 Nov 2016 20:12:52 +0000 (UTC) Received: by mail-io0-f176.google.com with SMTP id j65so94672269iof.0 for ; Thu, 24 Nov 2016 12:12:52 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=O4V+8FL0czCz9jfJPoY1MvzB54feMv88zeBubnnynOU=; b=IkaDVqiaxTL8fSLcBcnTJr3OvgWS4Ui/7FyKuqQHbO8c730pH/OwL8Ol8SSOWqpaNj VLGa9CZRLyghxpImHRVEGQPSE8OowlxEG1PPVSzxKLtJBSZ/tsMH/olxXHpvsVIK3Cro nBJ5ZjTmBcoNpm0jNdGnDTsLR3IUxS9PlEi3fMNCU2Jf615kkjhwUPfD8Wmx2A5eYtxe 2LXh79puSaZF6Jc+CjzG4f9QQW2orsl0KnGhYvgutnXBxGiVW4f1WA6YYCKTO0cVVEHR 88oNaDjsr2GIjZc8+fl81ZhREif3APWf2BOfDRx63Mxf6a+rrDFr3T0fuspZf0u/N/FN 9zNg== X-Gm-Message-State: AKaTC01qi5o3bAE48e4C06sKkmtMSC/WGY3giIETg53EJ1DCQaFMQE5bWYFoE/WCMu9tjhiT//BThzICz2zFlm2tVX8= X-Received: by 10.36.150.134 with SMTP id z128mr3577577itd.62.1480018372010; Thu, 24 Nov 2016 12:12:52 -0800 (PST) MIME-Version: 1.0 Received: by 10.107.9.31 with HTTP; Thu, 24 Nov 2016 12:12:51 -0800 (PST) In-Reply-To: <1480003389-19250-2-git-send-email-maxim.uvarov@linaro.org> References: <1480003389-19250-1-git-send-email-maxim.uvarov@linaro.org> <1480003389-19250-2-git-send-email-maxim.uvarov@linaro.org> From: Anders Roxell Date: Thu, 24 Nov 2016 21:12:51 +0100 Message-ID: To: Maxim Uvarov Cc: lng-odp-forward Subject: Re: [lng-odp] [PATCHv6 1/3] configure.ac: disable shared library for non abi compat mode X-BeenThere: lng-odp@lists.linaro.org X-Mailman-Version: 2.1.16 Precedence: list List-Id: "The OpenDataPlane \(ODP\) List" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: lng-odp-bounces@lists.linaro.org Sender: "lng-odp" On 24 November 2016 at 17:03, Maxim Uvarov wrote: > original configure.ac enables abi compat mode by default, > even without --enable-abi-compat provided. And has broken > logic to disable abi compat mode. Correct logic to build abi > compat mode and option to disable it. Shared library is not > needed for non abi compat mode, so turn it off. > > Signed-off-by: Maxim Uvarov > --- > configure.ac | 9 ++++++--- > 1 file changed, 6 insertions(+), 3 deletions(-) > > diff --git a/configure.ac b/configure.ac > index be5a292..7cb0c7a 100644 > --- a/configure.ac > +++ b/configure.ac > @@ -241,16 +241,19 @@ ODP_CFLAGS="$ODP_CFLAGS -DODP_DEBUG=$ODP_DEBUG" > ODP_ABI_COMPAT=1 > abi_compat=yes > AC_ARG_ENABLE([abi-compat], > - [ --enable-abi-compat build all targets in ABI compatible mode (default=yes)], > + [ --disable-abi-compat disable build all targets in ABI compatible mode (default=no)], > [if test "x$enableval" = "xyes"; then > ODP_ABI_COMPAT=1 > - abi_compat=yes > else > ODP_ABI_COMPAT=0 > - abi_compat=no > fi]) > AC_SUBST(ODP_ABI_COMPAT) > > +if test $ODP_ABI_COMPAT -eq 0; then > + enable_shared=no > + abi_compat=no > +fi > + > ########################################################################## > # Default warning setup > ########################################################################## > -- > 2.7.1.250.gff4ea60 > I think it should look something like this: $ git df AC_SUBST(ODP_ABI_COMPAT) @@ -336,6 +334,7 @@ AC_MSG_RESULT([ static libraries: ${enable_static} shared libraries: ${enable_shared} ABI compatible: ${abi_compat} + ODP_ABI_COMPAT: ${ODP_ABI_COMPAT} cunit: ${cunit_support} test_vald: ${test_vald} test_perf: ${test_perf} diff --git a/configure.ac b/configure.ac index be5a292..7becc2a 100644 --- a/configure.ac +++ b/configure.ac @@ -241,13 +241,11 @@ ODP_CFLAGS="$ODP_CFLAGS -DODP_DEBUG=$ODP_DEBUG" ODP_ABI_COMPAT=1 abi_compat=yes AC_ARG_ENABLE([abi-compat], - [ --enable-abi-compat build all targets in ABI compatible mode (default=yes)], - [if test "x$enableval" = "xyes"; then - ODP_ABI_COMPAT=1 - abi_compat=yes - else + [ --disable-abi-compat disables ABI compatible mode, enables inline code in header files], + [if test "x$enableval" = "xno"; then ODP_ABI_COMPAT=0 abi_compat=no + enable_shared=no fi])