From patchwork Tue Jul 12 07:44:25 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yi He X-Patchwork-Id: 71788 Delivered-To: patch@linaro.org Received: by 10.140.29.52 with SMTP id a49csp330865qga; Tue, 12 Jul 2016 00:44:36 -0700 (PDT) X-Received: by 10.55.102.85 with SMTP id a82mr1087384qkc.173.1468309476314; Tue, 12 Jul 2016 00:44:36 -0700 (PDT) Return-Path: Received: from lists.linaro.org (lists.linaro.org. [54.225.227.206]) by mx.google.com with ESMTP id n4si780737qkb.188.2016.07.12.00.44.35; Tue, 12 Jul 2016 00:44:36 -0700 (PDT) Received-SPF: pass (google.com: domain of lng-odp-bounces@lists.linaro.org designates 54.225.227.206 as permitted sender) client-ip=54.225.227.206; Authentication-Results: mx.google.com; spf=pass (google.com: domain of lng-odp-bounces@lists.linaro.org designates 54.225.227.206 as permitted sender) smtp.mailfrom=lng-odp-bounces@lists.linaro.org; dmarc=pass (p=NONE dis=NONE) header.from=linaro.org Received: by lists.linaro.org (Postfix, from userid 109) id AA53F687BA; Tue, 12 Jul 2016 07:44:35 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on ip-10-142-244-252 X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, URIBL_BLOCKED autolearn=disabled version=3.4.0 Received: from [127.0.0.1] (localhost [127.0.0.1]) by lists.linaro.org (Postfix) with ESMTP id 349736853D; Tue, 12 Jul 2016 07:44:31 +0000 (UTC) X-Original-To: lng-odp@lists.linaro.org Delivered-To: lng-odp@lists.linaro.org Received: by lists.linaro.org (Postfix, from userid 109) id 0DC27687A8; Tue, 12 Jul 2016 07:44:29 +0000 (UTC) Received: from mail-oi0-f43.google.com (mail-oi0-f43.google.com [209.85.218.43]) by lists.linaro.org (Postfix) with ESMTPS id BF04D6853A for ; Tue, 12 Jul 2016 07:44:26 +0000 (UTC) Received: by mail-oi0-f43.google.com with SMTP id r2so11103036oih.2 for ; Tue, 12 Jul 2016 00:44:26 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=1GY4IiouQQ2uYBznS3XKghSRcpHppgfHGruo+Hhcd3A=; b=kLWUkS1zz7i3fINw1GgvWmFRmbWob4QZgocX74o/J1RAc5RKsNXBWt0QVrz9FYzZHt cuNy1zQ/fRaZi3LMOez/R+s3vCizGQ8ybMMZjLjKYyTz494eyUMupRk+dQh6sHNHH+BH YTBX3lkZqcVVjZJNgTm/FApWS1vTnRIpGNXtywD994dzyanQ1rbDfiYqCvbVlGoljacw 7d1rEZcBKTJz2hr8WLvZkNvQd0O9ZUG6U6Jq7KUZmbgsW1qFnoKjPFk1Z5aCs7+D9fs9 f44nlEB6eHeNkWlciWDNicbNqFMj8uGU+DQvRKa5vUF/O0clCZ5GyiZX3MXO8kIr5sCm 5kBQ== X-Gm-Message-State: ALyK8tKIvo4tC6skz1hHpZpVEdunx7FPsUwW5gK1aRilBJmUsEyrl+8hrdXyLTk9fqBfl7qaN7IoQcutyvc/aHMehXM= X-Received: by 10.202.85.87 with SMTP id j84mr12414984oib.203.1468309466263; Tue, 12 Jul 2016 00:44:26 -0700 (PDT) MIME-Version: 1.0 Received: by 10.202.180.84 with HTTP; Tue, 12 Jul 2016 00:44:25 -0700 (PDT) In-Reply-To: <1468250807-23566-3-git-send-email-christophe.milard@linaro.org> References: <1468250807-23566-1-git-send-email-christophe.milard@linaro.org> <1468250807-23566-3-git-send-email-christophe.milard@linaro.org> From: Yi He Date: Tue, 12 Jul 2016 15:44:25 +0800 Message-ID: To: Christophe Milard X-Content-Filtered-By: Mailman/MimeDel 2.1.16 X-Topics: patch Cc: lng-odp Subject: Re: [lng-odp] [PATCH 2/4] validation: moving api validation tests to prepare for new interfaces X-BeenThere: lng-odp@lists.linaro.org X-Mailman-Version: 2.1.16 Precedence: list List-Id: "The OpenDataPlane \(ODP\) List" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: lng-odp-bounces@lists.linaro.org Sender: "lng-odp" Hi, Christophe, This patch by its own misses one line change which will fail in 'make check': On 11 July 2016 at 23:26, Christophe Milard wrote: > API tests are now moved to test/all-platforms/validation/api > (from test/validation), > The reason for this move is two folded: > * Moving down validation to all-plaform/validation disambiguates > all-platforms - minor but just in case the submit message. meaning - in below? the meanning of validation (which up to now was referring to both > platform agnostic tests and to the set of tests to pass to be ODP > compatible). Now things in test/all-platforms/ are platform agnostic. > So test/all-platforms/validation/* are platform agnostic things for the > valitation tests, as much as test/all-platforms/performance are > validation. platform agnostic things for the performance tests. > * creating the api directory under "validation" simply enable adding > other interfaces (such as future drv) as part of the validation tests Signed-off-by: Christophe Milard > --- > ... > 161 files changed, 91 insertions(+), 75 deletions(-) > create mode 100644 test/all-platforms/Makefile.am > rename test/{validation => all-platforms}/common/Makefile.am (100%) > rename test/{validation => all-platforms}/common/mask_common.c (100%) > rename test/{validation => all-platforms}/common/mask_common.h (100%) > rename test/{validation => all-platforms}/common/odp_cunit_common.c (100%) > rename test/{validation => all-platforms}/common/odp_cunit_common.h > (100%) 'common' in validation actually holds the unit testing framework (cunit) encapsulation which would be better utilized by all test programs, what do you think? currently not all test programs utilize the testing framework, is that deliberately? Shall this 'common' module to be lifted into top level and named like: 'test/framework/cunit' and can also put that lonely test_debug.h header into it since it looks like belongs to a testing framework. This can be a separate item for future also. latterly better testing framework can be evaluated for needed features like multi-threading and mocker support. ...... > diff --git a/test/all-platforms/Makefile.am > b/test/all-platforms/Makefile.am > new file mode 100644 > index 0000000..af78bb6 > --- /dev/null > +++ b/test/all-platforms/Makefile.am > @@ -0,0 +1,7 @@ > +SUBDIRS = > + > +if cunit_support > +SUBDIRS += common +endif > +SUBDIRS += common validation? For that validation need to be with cunit enabled Also is that possible to write as below to eliminate one level Makefile.am?? Then all-platforms/validation/Makefile.am can be removed. +SUBDIRES += common validation/api > + > +SUBDIRS += performance miscellaneous validation > +SUBDIRS += performance miscellaneous diff --git a/test/all-platforms/performance/odp_l2fwd_run.sh b/test/all-platforms/performance/odp_l2fwd_run.sh index a33bbeb..2f390e4 100755 --- a/test/all-platforms/performance/odp_l2fwd_run.sh +++ b/test/all-platforms/performance/odp_l2fwd_run.sh @@ -25,7 +25,7 @@ TEST_DIR="${TEST_DIR:-$PWD}" # directory where test sources are, including scripts TEST_SRC_DIR=$(dirname $0) -PATH=$TEST_DIR:$TEST_DIR/../../example/generator:$PATH +PATH=$TEST_DIR:$TEST_DIR/../../../example/generator:$PATH and some comments below: