From patchwork Tue Apr 14 18:29:35 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Russell King \(Oracle\)" X-Patchwork-Id: 221179 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6EF5CC2BA19 for ; Tue, 14 Apr 2020 18:29:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3A15320575 for ; Tue, 14 Apr 2020 18:29:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b="vp/gdevq" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2503993AbgDNS3y (ORCPT ); Tue, 14 Apr 2020 14:29:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47990 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S2503988AbgDNS3w (ORCPT ); Tue, 14 Apr 2020 14:29:52 -0400 X-Greylist: delayed 7146 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Tue, 14 Apr 2020 11:29:51 PDT Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [IPv6:2001:4d48:ad52:3201:214:fdff:fe10:1be6]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 69ACFC061A0C for ; Tue, 14 Apr 2020 11:29:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:Content-Type:MIME-Version: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=qT7pq56eGRVJyi38PZK7i3UNqcN9dLDa3yh7cY9BxYI=; b=vp/gdevqsipZ7cr0lo2UKXAIl puqj32rZlg0ZQLasuzFZ2i28ZZECqFp6RSf9zEM/nySVs1yvkhvHp+pp1JixcgNHuMn01eZVfyvqj 7sMB1vTlLrzFLkjwKR4iQatn5Dfq7MpQ4y7uCuHCL4TZO0dQcWcebbr8Ka4AUlA/rXmG+aYh4mV2Y gSJKIy5dW/Pm+HK6Xok3cVKnBfrEKl2X6uP3ML/fRtqEFOYESzPnhDxIxaqeQWJrzTBAtelngs7g2 4lIE0qWk5muLvPN2eUgPQC9XrHh5yBn2Kl8YylVJze6ZwDJTtNpiHzyBnjZhAraokXRAd1RDw0xtJ guJR5bxQQ==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:50056) by pandora.armlinux.org.uk with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jOQJY-0001PP-Ho; Tue, 14 Apr 2020 19:29:40 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.92) (envelope-from ) id 1jOQJT-0008Kq-Og; Tue, 14 Apr 2020 19:29:35 +0100 Date: Tue, 14 Apr 2020 19:29:35 +0100 From: Russell King - ARM Linux admin To: Andrew Lunn , Florian Fainelli , Heiner Kallweit Cc: "David S. Miller" , Matteo Croce , netdev@vger.kernel.org Subject: [PATCH net 0/2] Fix 88x3310 leaving power save mode Message-ID: <20200414182935.GY25745@shell.armlinux.org.uk> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.10.1 (2018-07-13) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Hi, This series fixes a problem with the 88x3310 PHY on Macchiatobin coming out of powersave mode noticed by Matteo Croce. It seems that certain PHY firmwares do not properly exit powersave mode, resulting in a fibre link not coming up. The solution appears to be to soft-reset the PHY after clearing the powersave bit. We add support for reporting the PHY firmware version to the kernel log, and use it to trigger this new behaviour if we have v0.3.x.x or more recent firmware on the PHY. This, however, is a guess as the firmware revision documentation does not mention this issue, and we know that v0.2.1.0 works without this fix but v0.3.3.0 and later does not. drivers/net/phy/marvell10g.c | 39 ++++++++++++++++++++++++++++++++++++--- 1 file changed, 36 insertions(+), 3 deletions(-)