| Message ID | 20201204170235.84387-1-andraprs@amazon.com |
|---|---|
| Headers | show |
| Series | vsock: Add flags field in the vsock address | expand |
Hi Andra, On Fri, Dec 04, 2020 at 07:02:31PM +0200, Andra Paraschiv wrote: >vsock enables communication between virtual machines and the host they are >running on. Nested VMs can be setup to use vsock channels, as the multi >transport support has been available in the mainline since the v5.5 Linux kernel >has been released. > >Implicitly, if no host->guest vsock transport is loaded, all the vsock packets >are forwarded to the host. This behavior can be used to setup communication >channels between sibling VMs that are running on the same host. One example can >be the vsock channels that can be established within AWS Nitro Enclaves >(see Documentation/virt/ne_overview.rst). > >To be able to explicitly mark a connection as being used for a certain use case, >add a flags field in the vsock address data structure. The "svm_reserved1" field >has been repurposed to be the flags field. The value of the flags will then be >taken into consideration when the vsock transport is assigned. This way can >distinguish between different use cases, such as nested VMs / local communication >and sibling VMs. the series seems in a good shape, I left some minor comments. I run my test suite (vsock_test, iperf3, nc) with nested VMs (QEMU/KVM), and everything looks good. Note: I'll be offline today and tomorrow, so I may miss followups. Thanks, Stefano
On 07/12/2020 12:05, Stefano Garzarella wrote: > > Hi Andra, > > On Fri, Dec 04, 2020 at 07:02:31PM +0200, Andra Paraschiv wrote: >> vsock enables communication between virtual machines and the host >> they are >> running on. Nested VMs can be setup to use vsock channels, as the multi >> transport support has been available in the mainline since the v5.5 >> Linux kernel >> has been released. >> >> Implicitly, if no host->guest vsock transport is loaded, all the >> vsock packets >> are forwarded to the host. This behavior can be used to setup >> communication >> channels between sibling VMs that are running on the same host. One >> example can >> be the vsock channels that can be established within AWS Nitro Enclaves >> (see Documentation/virt/ne_overview.rst). >> >> To be able to explicitly mark a connection as being used for a >> certain use case, >> add a flags field in the vsock address data structure. The >> "svm_reserved1" field >> has been repurposed to be the flags field. The value of the flags >> will then be >> taken into consideration when the vsock transport is assigned. This >> way can >> distinguish between different use cases, such as nested VMs / local >> communication >> and sibling VMs. > > the series seems in a good shape, I left some minor comments. > I run my test suite (vsock_test, iperf3, nc) with nested VMs (QEMU/KVM), > and everything looks good. Thanks, Stefano, for review and checking it out for the nested case as well. I'll send out v3 including the addressed feedback and the Rb tags. > > Note: I'll be offline today and tomorrow, so I may miss followups. Ok, np, thanks for the heads-up. Andra Amazon Development Center (Romania) S.R.L. registered office: 27A Sf. Lazar Street, UBC5, floor 2, Iasi, Iasi County, 700045, Romania. Registered in Romania. Registration number J22/2621/2005.
vsock enables communication between virtual machines and the host they are running on. Nested VMs can be setup to use vsock channels, as the multi transport support has been available in the mainline since the v5.5 Linux kernel has been released. Implicitly, if no host->guest vsock transport is loaded, all the vsock packets are forwarded to the host. This behavior can be used to setup communication channels between sibling VMs that are running on the same host. One example can be the vsock channels that can be established within AWS Nitro Enclaves (see Documentation/virt/ne_overview.rst). To be able to explicitly mark a connection as being used for a certain use case, add a flags field in the vsock address data structure. The "svm_reserved1" field has been repurposed to be the flags field. The value of the flags will then be taken into consideration when the vsock transport is assigned. This way can distinguish between different use cases, such as nested VMs / local communication and sibling VMs. Thank you. Andra --- Patch Series Changelog The patch series is built on top of v5.10-rc6. GitHub repo branch for the latest version of the patch series: * https://github.com/andraprs/linux/tree/vsock-flag-sibling-comm-v2 v1 -> v2 * Update the vsock flag naming to "VMADDR_FLAG_TO_HOST". * Use bitwise operators to setup and check the vsock flag. * Set the vsock flag on the receive path in the vsock transport assignment logic. * Merge the checks for the g2h transport assignment in one "if" block. * v1: https://lore.kernel.org/lkml/20201201152505.19445-1-andraprs@amazon.com/ --- Andra Paraschiv (4): vm_sockets: Include flags field in the vsock address data structure vm_sockets: Add VMADDR_FLAG_TO_HOST vsock flag af_vsock: Set VMADDR_FLAG_TO_HOST flag on the receive path af_vsock: Assign the vsock transport considering the vsock address flags include/uapi/linux/vm_sockets.h | 17 ++++++++++++++++- net/vmw_vsock/af_vsock.c | 21 +++++++++++++++++++-- 2 files changed, 35 insertions(+), 3 deletions(-)