| Message ID | 20210225112357.3785911-1-olteanv@gmail.com |
|---|---|
| Headers | show |
| Series | Fixes for NXP ENETC driver | expand |
On Thu, Feb 25, 2021 at 11:29:42AM +0000, Russell King - ARM Linux admin wrote: > On Thu, Feb 25, 2021 at 01:23:57PM +0200, Vladimir Oltean wrote: > > static void enetc_pl_mac_link_up(struct phylink_config *config, > > struct phy_device *phy, unsigned int mode, > > phy_interface_t interface, int speed, > > @@ -945,6 +981,10 @@ static void enetc_pl_mac_link_up(struct phylink_config *config, > > enetc_sched_speed_set(priv, speed); > > > > enetc_mac_enable(&pf->si->hw, true); > > + > > + if (!phylink_autoneg_inband(mode) && > > + phy_interface_mode_is_rgmii(interface)) > > + enetc_force_rgmii_mac(&pf->si->hw, speed, duplex); > > Does it matter that you're forcing the RGMII setup after having enabled > the MAC? Thanks, this is a good point. I had tested only at gigabit on the LS1028A-QDS, but at 10/100 things seem to be broken if I update the speed with the MAC being enabled. I'll send a v2 with this change and also with a build failure fix for patch 4/6.
From: Vladimir Oltean <vladimir.oltean@nxp.com> This contains an assorted set of fixes collected over the past week on the enetc driver. Some are related to VLAN processing, some to physical link settings, some are fixups of previous hardware workarounds. Vladimir Oltean (6): net: enetc: don't overwrite the RSS indirection table when initializing net: enetc: initialize RFS/RSS memories for unused ports too net: enetc: take the MDIO lock only once per NAPI poll cycle net: enetc: fix incorrect TPID when receiving 802.1ad tagged packets net: enetc: don't disable VLAN filtering in IFF_PROMISC mode net: enetc: force the RGMII speed and duplex instead of operating in inband mode drivers/net/ethernet/freescale/enetc/enetc.c | 127 +++++------------- drivers/net/ethernet/freescale/enetc/enetc.h | 5 + .../net/ethernet/freescale/enetc/enetc_cbdr.c | 54 ++++++++ .../net/ethernet/freescale/enetc/enetc_hw.h | 18 ++- .../net/ethernet/freescale/enetc/enetc_pf.c | 103 +++++++++++--- .../net/ethernet/freescale/enetc/enetc_vf.c | 7 + 6 files changed, 202 insertions(+), 112 deletions(-)