From patchwork Mon Mar 15 13:34:49 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alex Elder X-Patchwork-Id: 400437 Delivered-To: patch@linaro.org Received: by 2002:a02:8562:0:0:0:0:0 with SMTP id g89csp3424835jai; Mon, 15 Mar 2021 06:35:53 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzH90m2dIi13Tf6CoFOYP+dmHzNF5E2JEiblZnH1rWtdLm2hSqU8d5QJmmzCsWKSi6HLAPR X-Received: by 2002:a17:906:144d:: with SMTP id q13mr22582123ejc.458.1615815353796; Mon, 15 Mar 2021 06:35:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1615815353; cv=none; d=google.com; s=arc-20160816; b=bsOIaciaRJWYtnH7DwcuDSP2MoiojO+af1SHccJ/IK5OSfdFPDxMGe9Chj+pt1Eri8 WlhJirA7oAqQSXqM4AEt4RcvLF3QZbPJPR8L0prYfvfMHihwEd6uVsUN6fZHWJdYic91 pCljlzm18a/StLzUP4bctfqZEmVMUH7jwqGVsSdfrr6SL1V0a8hljyYoJ0c25DBmdbQ7 B6dsUerpvBJ83Uk9owoC5Zx7pMO3novL91vpelFc+FbkumkY4YtWJr86njZiaxt6WS5e sjd8w0vXuNOtgo0JGdl/th3lav1ZE6+/xLvEOsMNkJFplhNxWX9hZXOGnUh0wdEJff14 rDGg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=SPNmMCei7+pSoUpF832oIo6Tpa5YlCYD81Jhp4gH57I=; b=OOBinjhIuLzDgTY5Kjn2sHMGgxwF8LQC66vVvdf0lmHvxbqk70jxLn94tPfbWhasYw gftc/h9Xv6RQyTfG7e92DyHny4T+uzL6iNIY63agMCWLXh2dNm3aOAQaGM9YXI/GTrxJ 9S3s82ymB3XAVT3mN0MUUN8U40TMIdqtMLC3jnswHFFad+zA0nJvVu0A02dKky1kfMk5 H8OmRlXM7ygrGlvSR0ANwk2JWgwcFriGPqQo799tBitKDFQk4GoIa0hF5KmN5FRdI/Hh ttVccy/zMm+k4aUtPHi31PXXtFirF+JxRRFTPhfFAbPR5nyK1rF56SYW7WDnv/Q8iaAm PVHg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=quc2p6iK; spf=pass (google.com: domain of netdev-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=netdev-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id s18si11097004edr.249.2021.03.15.06.35.53; Mon, 15 Mar 2021 06:35:53 -0700 (PDT) Received-SPF: pass (google.com: domain of netdev-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=quc2p6iK; spf=pass (google.com: domain of netdev-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=netdev-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229510AbhCONfN (ORCPT + 8 others); Mon, 15 Mar 2021 09:35:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39266 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229579AbhCONe7 (ORCPT ); Mon, 15 Mar 2021 09:34:59 -0400 Received: from mail-il1-x12c.google.com (mail-il1-x12c.google.com [IPv6:2607:f8b0:4864:20::12c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B3435C06174A for ; Mon, 15 Mar 2021 06:34:59 -0700 (PDT) Received: by mail-il1-x12c.google.com with SMTP id g9so9357591ilc.3 for ; Mon, 15 Mar 2021 06:34:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=SPNmMCei7+pSoUpF832oIo6Tpa5YlCYD81Jhp4gH57I=; b=quc2p6iK1+m/vt3w6Xu+p8fIIKtRq0fzSxA7ABwq5EUvvJMj90FDYo1ksXbRhtg4Ho mKQsUpSUngRGKMw+y6NvH3kRtHFzo9LEBnAsX7H+16Dt3vVVBGYIAQ/Wu/y+PLLOPFUC f9iK6TB9pd7PlHEMvYxudVxzov8XUmQWpvc/vU9LCVFz9GbPz3VXsa7xr9NtDavCFna7 BGEia+HOqTVMMOW6UV6LDt5Lch7dBC5vCgPW2wOiWslOkxZvwpMJ8OAsg3VwAsTpiVKr RXoMP++eSlq9Pg8exo0dmb3oDNes/NEsTwEH9MjE4TVjZGbfyL6sFnbT6BkC1fvWpn5U cZkg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=SPNmMCei7+pSoUpF832oIo6Tpa5YlCYD81Jhp4gH57I=; b=nwKB3P3wVKQFaTrK0qlpmCNNDAdrYpWOwwgvfHe6UGP2QTUcW2QeW+fonPAbY7zeA8 xjd1uoMeFA3HtyQAG2vnuXdy+MZerwcLgSALtIlGrTUgAteMh1Z80xL6ikfO5hbZI9XG y3Jknq9eWa9FY+VKqJH+uSfvXKfpIxD5HRHVuPXqaSRZvmuIE9QPoS+TIq8Y4MN9YJXq RAxIGIH7M7tecwFfy6ad/YJYH+vbtwIacteQE5g50bnZKWx/GugNf+FlBMeVOdpKsfXh eroNht/M8eTk7/fpO9cFXcdI3mLB7r2AQZGSdUZLl6EyeAwQuMYd8msMyNfFwsvJobL3 7j+A== X-Gm-Message-State: AOAM533b7ppN5ckx+F0+fbj6KQUuTPbj9044Q1xTMo7LB5Q5RQXCbxJI /MdCFcCwv1aJUQYqef6voTKbCA== X-Received: by 2002:a92:b70c:: with SMTP id k12mr12423418ili.60.1615815299104; Mon, 15 Mar 2021 06:34:59 -0700 (PDT) Received: from localhost.localdomain (c-73-185-129-58.hsd1.mn.comcast.net. [73.185.129.58]) by smtp.gmail.com with ESMTPSA id o23sm7127672ioo.24.2021.03.15.06.34.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Mar 2021 06:34:58 -0700 (PDT) From: Alex Elder To: subashab@codeaurora.org, stranche@codeaurora.org, davem@davemloft.net, kuba@kernel.org Cc: sharathv@codeaurora.org, bjorn.andersson@linaro.org, evgreen@chromium.org, cpratapa@codeaurora.org, David.Laight@ACULAB.COM, olteanv@gmail.com, elder@kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH net-next v4 0/6] net: qualcomm: rmnet: stop using C bit-fields Date: Mon, 15 Mar 2021 08:34:49 -0500 Message-Id: <20210315133455.1576188-1-elder@linaro.org> X-Mailer: git-send-email 2.27.0 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org The main reason for version 4 of this series is that a bug was introduced in version 3, and that is fixed. But a nice note from Vladimir Oltean got me thinking about the necessity of using accessors defined in , and I concluded there was no need. So this version simplifies things further, using bitwise AND and OR operators (rather than, e.g., u8_get_bits()) to access all values encoded in bit fields. This version has been tested using IPv4 with checksum offload enabled and disabled. Traffic over the link included ICMP (ping), UDP (iperf), and TCP (wget). Version 3 of this series used BIT() rather than GENMASK() to define single-bit masks, and bitwise AND operators to access them. Version 2 fixed bugs in the way the value written into the header was computed in version 1. The series was first posted here: https://lore.kernel.org/netdev/20210304223431.15045-1-elder@linaro.org/ -Alex Alex Elder (6): net: qualcomm: rmnet: mark trailer field endianness net: qualcomm: rmnet: simplify some byte order logic net: qualcomm: rmnet: kill RMNET_MAP_GET_*() accessor macros net: qualcomm: rmnet: use masks instead of C bit-fields net: qualcomm: rmnet: don't use C bit-fields in rmnet checksum trailer net: qualcomm: rmnet: don't use C bit-fields in rmnet checksum header .../ethernet/qualcomm/rmnet/rmnet_handlers.c | 10 +-- .../net/ethernet/qualcomm/rmnet/rmnet_map.h | 12 ---- .../qualcomm/rmnet/rmnet_map_command.c | 11 +++- .../ethernet/qualcomm/rmnet/rmnet_map_data.c | 60 ++++++++--------- include/linux/if_rmnet.h | 65 +++++++++---------- 5 files changed, 69 insertions(+), 89 deletions(-) -- 2.27.0 Reviewed-by: Alexander Duyck