From patchwork Mon Mar 29 08:52:07 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Leon Romanovsky X-Patchwork-Id: 411215 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, INCLUDES_PATCH, MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 18988C433F2 for ; Mon, 29 Mar 2021 08:55:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E4F5961919 for ; Mon, 29 Mar 2021 08:55:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234235AbhC2Iyz (ORCPT ); Mon, 29 Mar 2021 04:54:55 -0400 Received: from mail.kernel.org ([198.145.29.99]:44254 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235925AbhC2IwV (ORCPT ); Mon, 29 Mar 2021 04:52:21 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id C875F60234; Mon, 29 Mar 2021 08:52:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1617007941; bh=bnIpIUBP9foWuS6GWuh658ubcN4zIR62dG1B5nzt4Vs=; h=From:To:Cc:Subject:Date:From; b=TIACr9zravvWNwhA8tbFm3rNdZBpRzHdsjYdS5O/gjIgU1B4DbknJia2ZyeguojR7 iFwvWRR6E7Gx8/FfmHeSetD1wAdOLNRGX8g+vTqrRFviKMtozJzL1/+z6aBKI5TB5U N5/C4fQEiAe8ziOepCUt6q1LiLD9uULC3gu40AiuNaiDCNh9gN/+pbdajIzzH2nU/N TVzmTfUX4d1xYQtaqCsCEjawUivAUO36Zu91jJtFjwjQh3qfst/JDLV6efI2JueP1v mhLQd/SJXvThpFFZ5CfWhyM6jE8aHNGOodw3g4PUkK/2oLs/Vm+LYyA+PhBp2bMgf/ cYB5S16Dp6mjw== From: Leon Romanovsky To: Doug Ledford , Jason Gunthorpe Cc: Leon Romanovsky , "David S. Miller" , Devesh Sharma , Jakub Kicinski , linux-rdma@vger.kernel.org, Michael Chan , Naresh Kumar PBS , netdev@vger.kernel.org, Selvin Xavier , Somnath Kotur , Sriharsha Basavapatna Subject: [PATCH rdma-next v1 0/5] Get rid of custom made module dependency Date: Mon, 29 Mar 2021 11:52:07 +0300 Message-Id: <20210329085212.257771-1-leon@kernel.org> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Leon Romanovsky Changelog: v1: * Go much deeper and removed useless ULP indirection v0: https://lore.kernel.org/linux-rdma/20210324142524.1135319-1-leon@kernel.org ----------------------------------------------------------------------- The following series fixes issue spotted in [1], where bnxt_re driver messed with module reference counting in order to implement symbol dependency of bnxt_re and bnxt modules. All of this is done, when in upstream we have only one ULP user of that bnxt module. The simple declaration of exported symbol would do the trick. This series removes that custom module_get/_put, which is not supposed to be in the driver from the beginning and get rid of nasty indirection logic that isn't relevant for the upstream code. Such small changes allow us to simplify the bnxt code and my hope that Devesh will continue where I stopped and remove struct bnxt_ulp_ops too. Thanks [1] https://lore.kernel.org/linux-rdma/20210324142524.1135319-1-leon@kernel.org Leon Romanovsky (5): RDMA/bnxt_re: Depend on bnxt ethernet driver and not blindly select it RDMA/bnxt_re: Create direct symbolic link between bnxt modules RDMA/bnxt_re: Get rid of custom module reference counting net/bnxt: Remove useless check of non-existent ULP id net/bnxt: Use direct API instead of useless indirection drivers/infiniband/hw/bnxt_re/Kconfig | 4 +- drivers/infiniband/hw/bnxt_re/main.c | 93 ++----- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 4 +- drivers/net/ethernet/broadcom/bnxt/bnxt.h | 1 - drivers/net/ethernet/broadcom/bnxt/bnxt_ulp.c | 240 +++++++----------- drivers/net/ethernet/broadcom/bnxt/bnxt_ulp.h | 32 +-- 6 files changed, 118 insertions(+), 256 deletions(-)