mbox series

[net-next,v6,0/6] remove compat_alloc_user_space()

Message ID 20210722142903.213084-1-arnd@kernel.org
Headers show
Series remove compat_alloc_user_space() | expand

Message

Arnd Bergmann July 22, 2021, 2:28 p.m. UTC
From: Arnd Bergmann <arnd@arndb.de>


This is the fifth version of my series, now spanning four patches
instead of two, with a new approach for handling struct ifreq
compatibility after I realized that my earlier approach introduces
additional problems.

The idea here is to always push down the compat conversion
deeper into the call stack: rather than pretending to be
native mode with a modified copy of the original data on
the user space stack, have the code that actually works on
the data understand the difference between native and compat
versions.

I have spent a long time looking at all drivers that implement
an ndo_do_ioctl callback to verify that my assumptions are
correct. This has led to a series of ~30 additional patches
that I am not including here but will post separately, fixing
a number of bugs in SIOCDEVPRIVATE ioctls, removing dead
code, and splitting ndo_do_ioctl into multiple new ndo callbacks
for private and ethernet specific commands.

      Arnd

Link: https://lore.kernel.org/netdev/20201124151828.169152-1-arnd@kernel.org/

Changes in v6:
 - Split out and expand linux/compat.h rework
 - Split ifconf change into two patches
 - Rebase on latest net-next/master

Changes in v5:
 - Rebase to v5.14-rc2
 - Fix a few build issues

Changes in v4:
 - build fix without CONFIG_INET
 - build fix without CONFIG_COMPAT
 - style fixes pointed out by hch

Changes in v3:
 - complete rewrite of the series

Arnd Bergmann (6):
  compat: make linux/compat.h available everywhere
  ethtool: improve compat ioctl handling
  net: socket: rework SIOC?IFMAP ioctls
  net: socket: remove register_gifconf
  net: socket: simplify dev_ifconf handling
  net: socket: rework compat_ifreq_ioctl()

 arch/arm64/include/asm/compat.h   |  14 +-
 arch/mips/include/asm/compat.h    |  24 ++-
 arch/parisc/include/asm/compat.h  |  14 +-
 arch/powerpc/include/asm/compat.h |  11 --
 arch/s390/include/asm/compat.h    |  14 +-
 arch/sparc/include/asm/compat.h   |  14 +-
 arch/x86/include/asm/compat.h     |  14 +-
 arch/x86/include/asm/signal.h     |   1 +
 include/asm-generic/compat.h      |  17 ++
 include/linux/compat.h            |  32 ++--
 include/linux/ethtool.h           |   4 -
 include/linux/inetdevice.h        |   9 +
 include/linux/netdevice.h         |  12 +-
 net/appletalk/ddp.c               |   4 +-
 net/core/dev_ioctl.c              | 153 +++++++++-------
 net/ethtool/ioctl.c               | 136 ++++++++++++--
 net/ieee802154/socket.c           |   4 +-
 net/ipv4/af_inet.c                |   6 +-
 net/ipv4/devinet.c                |   4 +-
 net/qrtr/qrtr.c                   |   4 +-
 net/socket.c                      | 292 +++++++-----------------------
 21 files changed, 352 insertions(+), 431 deletions(-)

-- 
2.29.2

Cc: Al Viro <viro@zeniv.linux.org.uk> 
Cc: Andrew Lunn <andrew@lunn.ch> 
Cc: Christoph Hellwig <hch@lst.de>
Cc: David Ahern <dsahern@kernel.org> 
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Eric Dumazet <edumazet@google.com>
Cc: Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org> 
Cc: Jakub Kicinski <kuba@kernel.org> 
Cc: Kees Cook <keescook@chromium.org> 
Cc: Marco Elver <elver@google.com> 
Cc: linux-kernel@vger.kernel.org 
Cc: linux-arch@vger.kernel.org 
Cc: netdev@vger.kernel.org

Comments

patchwork-bot+netdevbpf@kernel.org July 23, 2021, 2:40 p.m. UTC | #1
Hello:

This series was applied to netdev/net-next.git (refs/heads/master):

On Thu, 22 Jul 2021 16:28:57 +0200 you wrote:
> From: Arnd Bergmann <arnd@arndb.de>

> 

> This is the fifth version of my series, now spanning four patches

> instead of two, with a new approach for handling struct ifreq

> compatibility after I realized that my earlier approach introduces

> additional problems.

> 

> [...]


Here is the summary with links:
  - [net-next,v6,1/6] compat: make linux/compat.h available everywhere
    https://git.kernel.org/netdev/net-next/c/1a33b18b3bd9
  - [net-next,v6,2/6] ethtool: improve compat ioctl handling
    https://git.kernel.org/netdev/net-next/c/dd98d2895de6
  - [net-next,v6,3/6] net: socket: rework SIOC?IFMAP ioctls
    https://git.kernel.org/netdev/net-next/c/709566d79209
  - [net-next,v6,4/6] net: socket: remove register_gifconf
    https://git.kernel.org/netdev/net-next/c/b0e99d03778b
  - [net-next,v6,5/6] net: socket: simplify dev_ifconf handling
    https://git.kernel.org/netdev/net-next/c/876f0bf9d0d5
  - [net-next,v6,6/6] net: socket: rework compat_ifreq_ioctl()
    https://git.kernel.org/netdev/net-next/c/29c4964822aa

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html