mbox series

[net-next,0/4] sfc: EF100 TSO enhancements

Message ID 6e1ea05f-faeb-18df-91ef-572445691d89@solarflare.com
Headers show
Series sfc: EF100 TSO enhancements | expand

Message

Edward Cree Oct. 28, 2020, 8:41 p.m. UTC 
Support TSO over encapsulation (with GSO_PARTIAL), and over VLANs
 (which the code already handled but we didn't advertise).  Also
 correct our handling of IPID mangling.

I couldn't find documentation of exactly what shaped SKBs we can
 get given, so patch #2 is slightly guesswork, but when I tested
 TSO over both underlay and (VxLAN) overlay, the checksums came
 out correctly, so at least in those cases the edits we're making
 must be the right ones.
Similarly, I'm not 100% sure I've correctly understood how FIXEDID
 and MANGLEID are supposed to work in patch #3.

Edward Cree (4):
  sfc: extend bitfield macros to 17 fields
  sfc: implement encap TSO on EF100
  sfc: only use fixed-id if the skb asks for it
  sfc: advertise our vlan features

 drivers/net/ethernet/sfc/bitfield.h  | 42 +++++++++++++++++---
 drivers/net/ethernet/sfc/ef100_nic.c | 17 ++++++--
 drivers/net/ethernet/sfc/ef100_tx.c  | 58 ++++++++++++++++------------
 3 files changed, 84 insertions(+), 33 deletions(-)

Comments

Jakub Kicinski Oct. 31, 2020, 12:45 a.m. UTC | #1 
On Wed, 28 Oct 2020 20:41:21 +0000 Edward Cree wrote:
> Support TSO over encapsulation (with GSO_PARTIAL), and over VLANs

>  (which the code already handled but we didn't advertise).  Also

>  correct our handling of IPID mangling.

> 

> I couldn't find documentation of exactly what shaped SKBs we can

>  get given, so patch #2 is slightly guesswork, but when I tested

>  TSO over both underlay and (VxLAN) overlay, the checksums came

>  out correctly, so at least in those cases the edits we're making

>  must be the right ones.

> Similarly, I'm not 100% sure I've correctly understood how FIXEDID

>  and MANGLEID are supposed to work in patch #3.


Applied, thanks everyone!