mbox series

[ethtool,0/4] add missing message descriptions

Message ID cover.1603142897.git.mkubecek@suse.cz
Headers show
Series add missing message descriptions | expand

Message

Michal Kubecek Oct. 19, 2020, 9:32 p.m. UTC 
Add message descriptions needed for pretty printing of netlink messages
related to recently added features: genetlink policy dumps and pause frame
statistics. First two patches extend pretty printing code with features
used by these descriptions: support for 64-bit numeric attributes and
and enumerated types (shown as symbolic names rather than numeric values).

Michal Kubecek (4):
  netlink: support u32 enumerated types in pretty printing
  netlink: support 64-bit attribute types in pretty printed messages
  netlink: add descriptions for genetlink policy dumps
  netlink: add message descriptions for pause stats

 netlink/desc-ethtool.c  |  7 +++++
 netlink/desc-genlctrl.c | 57 +++++++++++++++++++++++++++++++++++++++++
 netlink/prettymsg.c     | 19 ++++++++++++++
 netlink/prettymsg.h     | 24 +++++++++++++++--
 4 files changed, 105 insertions(+), 2 deletions(-)

Comments

Jakub Kicinski Oct. 20, 2020, 9:51 p.m. UTC | #1 
On Mon, 19 Oct 2020 23:32:37 +0200 (CEST) Michal Kubecek wrote:
> Add message descriptions needed for pretty printing of netlink messages
> related to recently added features: genetlink policy dumps and pause frame
> statistics. First two patches extend pretty printing code with features
> used by these descriptions: support for 64-bit numeric attributes and
> and enumerated types (shown as symbolic names rather than numeric values).

Nice! I haven't crossed checked all the types but FWIW LGTM.