mbox series

[v4,0/3] Add support for mv88e6393x family of Marvell.

Message ID cover.1603690201.git.pavana.sharma@digi.com
Headers show
Series Add support for mv88e6393x family of Marvell. | expand

Message

Pavana Sharma Oct. 26, 2020, 5:52 a.m. UTC 
Hi,

Thanks for the review.
Following is the updated patchset.

The 6393X family has MV88E6191X, MV88E6193X and MV88E6393X products listed in 
Gigabit Ethernet and Gigabit 10G+ Ethernet categories. There are no 6393 devices 
(without X) but there is 6191 device (without X)from a different family.
The product id is listed with the 'X' in the name so I prefer to retain the 
product name 6393X in the driver whereas we can define the family name as
'MV88E6XXX_FAMILY_6393' without 'X'.

The patchset adds support for modes 5GBASE-R, 10GBASE-R and USXGMII on 
ports 0, 9 and 10.

Tested on MV88E6193X device.

Pavana

Pavana Sharma (3):
  Add support for mv88e6393x family of Marvell.
  Add phy interface for 5GBASER mode
  Change serdes lane parameter from u8 type to int.

 drivers/net/dsa/mv88e6xxx/chip.c    | 119 +++++++++--
 drivers/net/dsa/mv88e6xxx/chip.h    |  20 +-
 drivers/net/dsa/mv88e6xxx/global1.h |   2 +
 drivers/net/dsa/mv88e6xxx/global2.h |   8 +
 drivers/net/dsa/mv88e6xxx/port.c    | 239 +++++++++++++++++++++-
 drivers/net/dsa/mv88e6xxx/port.h    |  40 +++-
 drivers/net/dsa/mv88e6xxx/serdes.c  | 297 ++++++++++++++++++++++++----
 drivers/net/dsa/mv88e6xxx/serdes.h  |  89 ++++++---
 include/linux/phy.h                 |   3 +
 9 files changed, 730 insertions(+), 87 deletions(-)

Comments

Andrew Lunn Oct. 26, 2020, 1:38 p.m. UTC | #1 
On Mon, Oct 26, 2020 at 03:58:11PM +1000, Pavana Sharma wrote:
> Signed-off-by: Pavana Sharma <pavana.sharma@digi.com>

Please swap the order of the patches so the build does not break.

       Andrew
Florian Fainelli Oct. 26, 2020, 1:42 p.m. UTC | #2 
On 10/25/2020 10:58 PM, Pavana Sharma wrote:
> Signed-off-by: Pavana Sharma <pavana.sharma@digi.com>

Please subject this patch properly with "net: phy: Add 5GBASER interface 
mode" and please also consider updating other files that are relevant here:

Documentation/devicetree/bindings/net/ethernet-controller.yaml
drivers/net/phy/phy-core.c
Florian Fainelli Oct. 26, 2020, 1:43 p.m. UTC | #3 
On 10/25/2020 10:52 PM, Pavana Sharma wrote:
> Hi,

> 

> Thanks for the review.

> Following is the updated patchset.

> 

> The 6393X family has MV88E6191X, MV88E6193X and MV88E6393X products listed in

> Gigabit Ethernet and Gigabit 10G+ Ethernet categories. There are no 6393 devices

> (without X) but there is 6191 device (without X)from a different family.

> The product id is listed with the 'X' in the name so I prefer to retain the

> product name 6393X in the driver whereas we can define the family name as

> 'MV88E6XXX_FAMILY_6393' without 'X'.

> 

> The patchset adds support for modes 5GBASE-R, 10GBASE-R and USXGMII on

> ports 0, 9 and 10.

> 

> Tested on MV88E6193X device.


Please subject your patches appropriately using "net: dsa: mv88e6xxx: " 
for DSA changes to the driver and "net: phy: " for PHY subsystem changes.
-- 
Florian