From patchwork Sun Mar 8 22:45:54 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Chan X-Patchwork-Id: 222842 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.9 required=3.0 tests=DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI, SIGNED_OFF_BY, SPF_HELO_NONE, SPF_PASS, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C77DAC10DCE for ; Sun, 8 Mar 2020 22:46:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 92E0220675 for ; Sun, 8 Mar 2020 22:46:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="aISMWM0K" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726540AbgCHWq1 (ORCPT ); Sun, 8 Mar 2020 18:46:27 -0400 Received: from mail-pg1-f194.google.com ([209.85.215.194]:45290 "EHLO mail-pg1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726533AbgCHWq0 (ORCPT ); Sun, 8 Mar 2020 18:46:26 -0400 Received: by mail-pg1-f194.google.com with SMTP id m15so3819667pgv.12 for ; Sun, 08 Mar 2020 15:46:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=CAoVTG0moicyEN68mWeiUhSf+E1MnfdqCLnPCEmAe7I=; b=aISMWM0KQSkLZ8XTiUTGQ5/knLymTUXKKg5i0XTsyvJFB84LhZP6kiNyvRwE/9H8Xq YxEjGNNXjN62v2thRHL97G+xeq0JcS9kzQnRhwPE5E1gkZ6mRUeqPBuM1EShgCKXEME8 Yguvb57RTCtcas5w1wMAtaNuCtRxKrCJ6DIJQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=CAoVTG0moicyEN68mWeiUhSf+E1MnfdqCLnPCEmAe7I=; b=hApcZ7JUcrCSSexRWcFLDVG0B+oJIYA3ILBPR7cquQrM39/ZQHj3tx830lL3rd4dfs 4ZPcSsGjy/vsLQxNmNESsoUhKfPxuEaFhsjzzy1GEPq6u2smlsjQl92pWe8VvdYZ1c40 2o9bxFr7wnz8QVNoBQ2ImctA24eOMZcev6Pd0nhLOuWLhxxosWtVYXg3OmZQwIjGZGWf oZHIdXVq1ByqBVKOwrz34/ythwA1djEWwC4Tb4gbfkEe8wE7XEa1zadtqI4GdYx82cTl +Ov29/aKqyjxyVpYbkQw7mxbBgcgry/L8+gwweYnbxGhNymCq9EKYKlD/U29kqpUS0hr M5Nw== X-Gm-Message-State: ANhLgQ3NxAkFUjMppa3KvGPvNUyl7qcoiIedRnTB/4WKeYy8uwawul+Z 4ghdUIUXZcFWq0baBii42WwBig== X-Google-Smtp-Source: ADFU+vv8vgGva0CEYMi9UBwpsAxgW/vSNLYyDSwtOfEcyZOmnZjjNm2kAbHMez6zMyRSVEoMzu+iFA== X-Received: by 2002:a63:9c4:: with SMTP id 187mr11485224pgj.389.1583707586005; Sun, 08 Mar 2020 15:46:26 -0700 (PDT) Received: from localhost.swdvt.lab.broadcom.com ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id x66sm31241397pgb.9.2020.03.08.15.46.23 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 08 Mar 2020 15:46:25 -0700 (PDT) From: Michael Chan To: davem@davemloft.net Cc: netdev@vger.kernel.org, Vasundhara Volam , Jiri Pirko Subject: [PATCH net-next 8/8] bnxt_en: Call devlink_port_type_clear() in remove() Date: Sun, 8 Mar 2020 18:45:54 -0400 Message-Id: <1583707554-1163-9-git-send-email-michael.chan@broadcom.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1583707554-1163-1-git-send-email-michael.chan@broadcom.com> References: <1583707554-1163-1-git-send-email-michael.chan@broadcom.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Vasundhara Volam Similar to other drivers, properly clear the devlink port type when removing the device before unregistration. Cc: Jiri Pirko Signed-off-by: Vasundhara Volam Signed-off-by: Michael Chan --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.c b/drivers/net/ethernet/broadcom/bnxt/bnxt.c index 02ac718..4c9696a 100644 --- a/drivers/net/ethernet/broadcom/bnxt/bnxt.c +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt.c @@ -11429,6 +11429,8 @@ static void bnxt_remove_one(struct pci_dev *pdev) bnxt_sriov_disable(bp); bnxt_dl_fw_reporters_destroy(bp, true); + if (BNXT_PF(bp)) + devlink_port_type_clear(&bp->dl_port); pci_disable_pcie_error_reporting(pdev); unregister_netdev(dev); bnxt_dl_unregister(bp);