From patchwork Fri Nov 13 03:51:57 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alex Shi X-Patchwork-Id: 324257 Delivered-To: patch@linaro.org Received: by 2002:a05:6e02:5ce:0:0:0:0 with SMTP id l14csp887898ils; Thu, 12 Nov 2020 19:52:43 -0800 (PST) X-Google-Smtp-Source: ABdhPJzQBpZ9efvb9Oics61eyKtzaWYZJddw7xsGC0v57QBp1xSt+RYMpPTRI4/nRTrJNvGKGsyB X-Received: by 2002:a17:906:26c6:: with SMTP id u6mr138760ejc.349.1605239563197; Thu, 12 Nov 2020 19:52:43 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1605239563; cv=none; d=google.com; s=arc-20160816; b=U1MYiEZLZICioaDGSjTBf8p4HTR0SEuGBhOFMrY7+3BDitb1wTRDtEy6fIfUSwV+ws AOLYaD7WC4mXbbzpfVKv0Z3LbsKIr/Ql5czvhQ/dbTJscS2Hd/CMxdKT4/7uGZ3pkxtU pDCD4nF/4/pj9cdWjlL49c7X8a/y7HX6D8mNnWHx1po4ci06tHBbfVutlWrcSp0BTcj7 0v3+TWHeD5y8mG1i4DccFFKLgVy07nDzT2OnseeZU/Qkky6alL0u6+nPR/TquDQh457L Qvyv3n225F9fBEaKCPJx1sAFmt0Hi4eJ6c1/3Fo/ujcjrmVLz9pz75kgTyxSfZhGD4LR 08rA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:to:message-id:date:subject:cc:from; bh=L+HqFPfVhHa6aD+9yxvJr4n8Fy8b1A0o2i6AjZWrh8U=; b=gYo+gfy6VmoQ90mAylqu2AjE5D0Fe3rXvRZAEYOAk4CGX4WFcZtdRXOLHg8aFwXwtg Xni2DwfCe+wfk4X9x/VZ3gWfqLvF/KMnGcfQymHv9kDdz5nDSJ9EINnIw+I41EX2InyE DaUcfixiDhwscuVezZejpxTyDJvElk+qZWJBACgmY1g06Bay+xeD05XOVTwfIARIQWUo 6A/fPRnN9lX31Ki8CZe9nyqeRnDdoQenfE1p5Z/XaCq8ECgaDdY1IOYOgErsweZoq3Cq UPEwBRkgMR93JWaZuWTKAYlxN1dGb0t5+5XcQRWvjG0M1jHqCw1XU8tZZj1wuVNOTzFF kxKA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of netdev-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=netdev-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id a10si5691302edq.316.2020.11.12.19.52.42; Thu, 12 Nov 2020 19:52:43 -0800 (PST) Received-SPF: pass (google.com: domain of netdev-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of netdev-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=netdev-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726240AbgKMDwC (ORCPT + 8 others); Thu, 12 Nov 2020 22:52:02 -0500 Received: from out30-132.freemail.mail.aliyun.com ([115.124.30.132]:35551 "EHLO out30-132.freemail.mail.aliyun.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726011AbgKMDwC (ORCPT ); Thu, 12 Nov 2020 22:52:02 -0500 X-Alimail-AntiSpam: AC=PASS; BC=-1|-1; BR=01201311R281e4; CH=green; DM=||false|; DS=||; FP=0|-1|-1|-1|0|-1|-1|-1; HT=e01e01424; MF=alex.shi@linux.alibaba.com; NM=1; PH=DS; RN=4; SR=0; TI=SMTPD_---0UF8oyGL_1605239519; Received: from aliy80.localdomain(mailfrom:alex.shi@linux.alibaba.com fp:SMTPD_---0UF8oyGL_1605239519) by smtp.aliyun-inc.com(127.0.0.1); Fri, 13 Nov 2020 11:52:00 +0800 From: Alex Shi Cc: "David S. Miller" , Jakub Kicinski , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] net/nfc/nic: refined function nci_hci_resp_received Date: Fri, 13 Nov 2020 11:51:57 +0800 Message-Id: <1605239517-49707-1-git-send-email-alex.shi@linux.alibaba.com> X-Mailer: git-send-email 1.8.3.1 To: unlisted-recipients:; (no To-header on input) Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org We don't use the parameter result actually, so better to remove it and skip a gcc warning for unused variable. Signed-off-by: Alex Shi Cc: "David S. Miller" Cc: Jakub Kicinski Cc: netdev@vger.kernel.org Cc: linux-kernel@vger.kernel.org --- net/nfc/nci/hci.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) -- 2.29.GIT diff --git a/net/nfc/nci/hci.c b/net/nfc/nci/hci.c index c18e76d6d8ba..6b275a387a92 100644 --- a/net/nfc/nci/hci.c +++ b/net/nfc/nci/hci.c @@ -363,16 +363,13 @@ static void nci_hci_cmd_received(struct nci_dev *ndev, u8 pipe, } static void nci_hci_resp_received(struct nci_dev *ndev, u8 pipe, - u8 result, struct sk_buff *skb) + struct sk_buff *skb) { struct nci_conn_info *conn_info; - u8 status = result; conn_info = ndev->hci_dev->conn_info; - if (!conn_info) { - status = NCI_STATUS_REJECTED; + if (!conn_info) goto exit; - } conn_info->rx_skb = skb; @@ -388,7 +385,7 @@ static void nci_hci_hcp_message_rx(struct nci_dev *ndev, u8 pipe, { switch (type) { case NCI_HCI_HCP_RESPONSE: - nci_hci_resp_received(ndev, pipe, instruction, skb); + nci_hci_resp_received(ndev, pipe, skb); break; case NCI_HCI_HCP_COMMAND: nci_hci_cmd_received(ndev, pipe, instruction, skb);