From patchwork Mon Apr 20 23:43:08 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jeff Kirsher X-Patchwork-Id: 220896 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI, SIGNED_OFF_BY, SPF_HELO_NONE, SPF_PASS, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 70EC5C55181 for ; Mon, 20 Apr 2020 23:43:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 57B9420722 for ; Mon, 20 Apr 2020 23:43:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727031AbgDTXna (ORCPT ); Mon, 20 Apr 2020 19:43:30 -0400 Received: from mga01.intel.com ([192.55.52.88]:14658 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726707AbgDTXnS (ORCPT ); Mon, 20 Apr 2020 19:43:18 -0400 IronPort-SDR: ktlaIzvrI3dOoZ6Q9uwjXxYb4wkFlDraff0IUiT5KrYfPJo1JDOjguTTr9moQg3pUYI9CtIea+ /JBmz0w9jT7A== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Apr 2020 16:43:17 -0700 IronPort-SDR: qy/8ZLip1p19C2E8LN+KgcFB1GQui1jk5A/gkXB+iyfISpWP1Ive6GstPjCFRC9kJWw2Ury2Be ZOau5kMxhQbQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.72,408,1580803200"; d="scan'208";a="300428867" Received: from jtkirshe-desk1.jf.intel.com ([134.134.177.86]) by FMSMGA003.fm.intel.com with ESMTP; 20 Apr 2020 16:43:16 -0700 From: Jeff Kirsher To: davem@davemloft.net Cc: Andre Guedes , netdev@vger.kernel.org, nhorman@redhat.com, sassmann@redhat.com, Aaron Brown , Jeff Kirsher Subject: [net-next 08/13] igc: Remove '\n' from log strings in igc_i225.c Date: Mon, 20 Apr 2020 16:43:08 -0700 Message-Id: <20200420234313.2184282-9-jeffrey.t.kirsher@intel.com> X-Mailer: git-send-email 2.25.3 In-Reply-To: <20200420234313.2184282-1-jeffrey.t.kirsher@intel.com> References: <20200420234313.2184282-1-jeffrey.t.kirsher@intel.com> MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Andre Guedes To keep log strings in igc_i225.c consistent with the rest of the driver code, this patch removes the '\n' character at the end. The newline character is automatically added by netdev_dbg() so there is no changes in the output. Note: hw_dbg() is a macro that expands to netdev_dbg(). Signed-off-by: Andre Guedes Tested-by: Aaron Brown Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/igc/igc_i225.c | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/drivers/net/ethernet/intel/igc/igc_i225.c b/drivers/net/ethernet/intel/igc/igc_i225.c index c25f555aaf82..a5856ae87a7e 100644 --- a/drivers/net/ethernet/intel/igc/igc_i225.c +++ b/drivers/net/ethernet/intel/igc/igc_i225.c @@ -71,7 +71,7 @@ static s32 igc_get_hw_semaphore_i225(struct igc_hw *hw) /* If we do not have the semaphore here, we have to give up. */ if (i == timeout) { - hw_dbg("Driver can't access device - SMBI bit is set.\n"); + hw_dbg("Driver can't access device - SMBI bit is set"); return -IGC_ERR_NVM; } } @@ -91,7 +91,7 @@ static s32 igc_get_hw_semaphore_i225(struct igc_hw *hw) if (i == timeout) { /* Release semaphores */ igc_put_hw_semaphore(hw); - hw_dbg("Driver can't access the NVM\n"); + hw_dbg("Driver can't access the NVM"); return -IGC_ERR_NVM; } @@ -131,7 +131,7 @@ s32 igc_acquire_swfw_sync_i225(struct igc_hw *hw, u16 mask) } if (i == timeout) { - hw_dbg("Driver can't access resource, SW_FW_SYNC timeout.\n"); + hw_dbg("Driver can't access resource, SW_FW_SYNC timeout"); ret_val = -IGC_ERR_SWFW_SYNC; goto out; } @@ -228,7 +228,7 @@ static s32 igc_write_nvm_srwr(struct igc_hw *hw, u16 offset, u16 words, */ if (offset >= nvm->word_size || (words > (nvm->word_size - offset)) || words == 0) { - hw_dbg("nvm parameter(s) out of bounds\n"); + hw_dbg("nvm parameter(s) out of bounds"); ret_val = -IGC_ERR_NVM; goto out; } @@ -250,7 +250,7 @@ static s32 igc_write_nvm_srwr(struct igc_hw *hw, u16 offset, u16 words, } if (ret_val) { - hw_dbg("Shadow RAM write EEWR timed out\n"); + hw_dbg("Shadow RAM write EEWR timed out"); break; } } @@ -369,7 +369,7 @@ static s32 igc_update_flash_i225(struct igc_hw *hw) ret_val = igc_pool_flash_update_done_i225(hw); if (ret_val == -IGC_ERR_NVM) { - hw_dbg("Flash update time out\n"); + hw_dbg("Flash update time out"); goto out; } @@ -378,9 +378,9 @@ static s32 igc_update_flash_i225(struct igc_hw *hw) ret_val = igc_pool_flash_update_done_i225(hw); if (ret_val) - hw_dbg("Flash update time out\n"); + hw_dbg("Flash update time out"); else - hw_dbg("Flash update complete\n"); + hw_dbg("Flash update complete"); out: return ret_val; @@ -406,7 +406,7 @@ static s32 igc_update_nvm_checksum_i225(struct igc_hw *hw) */ ret_val = igc_read_nvm_eerd(hw, 0, 1, &nvm_data); if (ret_val) { - hw_dbg("EEPROM read failed\n"); + hw_dbg("EEPROM read failed"); goto out; } @@ -423,7 +423,7 @@ static s32 igc_update_nvm_checksum_i225(struct igc_hw *hw) ret_val = igc_read_nvm_eerd(hw, i, 1, &nvm_data); if (ret_val) { hw->nvm.ops.release(hw); - hw_dbg("NVM Read Error while updating checksum.\n"); + hw_dbg("NVM Read Error while updating checksum"); goto out; } checksum += nvm_data; @@ -433,7 +433,7 @@ static s32 igc_update_nvm_checksum_i225(struct igc_hw *hw) &checksum); if (ret_val) { hw->nvm.ops.release(hw); - hw_dbg("NVM Write Error while updating checksum.\n"); + hw_dbg("NVM Write Error while updating checksum"); goto out; }