From patchwork Fri Aug 14 11:39:05 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 247700 Delivered-To: patch@linaro.org Received: by 2002:a92:cc90:0:0:0:0:0 with SMTP id x16csp292750ilo; Fri, 14 Aug 2020 04:39:48 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwnMUKjbJ2B6ucmofyt/uGWZ8Ed7nPwwX0csNgGvvn5PQg4Kyx7i7Qjmj1a//gJHr6Oepq2 X-Received: by 2002:a05:6402:22b3:: with SMTP id cx19mr1793197edb.248.1597405188142; Fri, 14 Aug 2020 04:39:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1597405188; cv=none; d=google.com; s=arc-20160816; b=OWIphp6w+LLNl2bY1cS0bYrtSEdLmxzc9JldFm3GEHutq7AjMXbjcBzhM+2z+a4nQy FkTHEpSSpdXxw+0QWj9HLQgfj59vVYKn8aUR60zfylgYolj2Gi2jeaXcjD1ICWs9WIIB Im36S6KtFU8pA3CrAZi4tUHDualrT/YBhsNyLXa2+41eiYK6JSqFEy82P89SxzxzON7v VFVraFFSh/yOMaVKFCQRUeu5+8ulw3hKvC221vjE7Dw3zdV3HOnKYQiarY+HA6edWhIa Bi7jkf4JPR8cJzAlshkmZqyYvFRmFdDuMRgwBNfFy8Fil1oJ2rAIJSghH1XUnalEEwVL W3Fw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=MUV+yz+bHDDxU9QUealM8/lB5IQK1oTN3Rz5yVKFYm4=; b=IZyrINu8w5qHLM0Jm4XNjvjNhpXGcqroT570BNgpfvse/XDiU6C/KEP1G7xKZ1udXc H+VEuI08/1ae82yX/s2qi3knB7phq34j0QqSe+rAjYALNnloAnXnPeh8oqs/UGbzyWHU M6ePVK6YMRXxJSpcX6LPUpZmI0iTdhxAAfTyksP+IyIKeIf+pWvsNKj7MXuJyhavSj3A SCsNNC7tV3k91Yl7TPAPPE+6QgV7zmadiLRTm+EAhfp06lnoL3JY3Oc4JF5SwhTbwTjJ TlSsJjN4XE4sX4EJNVy3fatCJmjANuPu1W3R/Nks1g+kJ6VeEM15Ke9AFiGGvSyW2GZe SCTA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=l+111kqH; spf=pass (google.com: domain of netdev-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=netdev-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id e12si5170633edn.431.2020.08.14.04.39.47; Fri, 14 Aug 2020 04:39:48 -0700 (PDT) Received-SPF: pass (google.com: domain of netdev-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=l+111kqH; spf=pass (google.com: domain of netdev-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=netdev-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728084AbgHNLjq (ORCPT + 9 others); Fri, 14 Aug 2020 07:39:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39632 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728055AbgHNLjn (ORCPT ); Fri, 14 Aug 2020 07:39:43 -0400 Received: from mail-wm1-x342.google.com (mail-wm1-x342.google.com [IPv6:2a00:1450:4864:20::342]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 540D6C061385 for ; Fri, 14 Aug 2020 04:39:43 -0700 (PDT) Received: by mail-wm1-x342.google.com with SMTP id c19so8215909wmd.1 for ; Fri, 14 Aug 2020 04:39:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=MUV+yz+bHDDxU9QUealM8/lB5IQK1oTN3Rz5yVKFYm4=; b=l+111kqHdNB0lIDK3r++LA2g+EZA//8R6aznyiwvdp+j0MKetNqHwbb7cuk9RrKa2E 8JEl3bytLKvZNB/Kxrxwcx0aPjN7M2y+bOQJkVsEiBcXovmpYZgNBqtD6uN8FUb9juC4 ejvTWSUKwvqTKg/RZkPj8akPf09yu4PUEvPnRRoVS4e5LN87uJ5aMmSjKUKFY9bkIP+I mSSQkwqKtAL2BuvfF57rSKTwc30gSoz3RwUrZHckDSPhZpBbmMAtNleFt3ViyH/499aK 3sVD5bU402VDJaCJNhhN0gQnHRlothsgZqgQA7s3EBeQu5SpL3otQ7BRPB+1QHx7p2qW 2Dnw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=MUV+yz+bHDDxU9QUealM8/lB5IQK1oTN3Rz5yVKFYm4=; b=D28fxLJDXU6EMtTM1CaTu8a+oQIrl25HeLd9by/zYVqddnYjf0AEp9qmEgQVzwaxhn miRI1TbRQEQ9cVe/TKRSsXHl0kmDHSsbfhVbJOEst+Jblb5Mqojn5qpNxou1t43o2Y3w zcSZE7jTqb7WTa6X3EXNef7Koi2jFRpnytNLZlK7oaeOgyYwKOzlj4KVJ0/FM8kbi5dC fOCaJKtWg5FSPQ5oT5brGnLoSWkQct/+wgfSdqRF5p/AZEloQXohiAGzdfHDEy/35NeQ gP5XitzK0iOMghlaAX3AoMUdmm5A/ndM8Qs5+SPVuj9mEiwDNCCmkZri0fF2UqDlEkLh zkOQ== X-Gm-Message-State: AOAM5319awkNZWy58xjYiOIs2r9O2ULSUp2803Axg9yxF4c+yxAz5Gc9 uJqXCGwL4oY1ttPshHOQ5fNvGw== X-Received: by 2002:a1c:7405:: with SMTP id p5mr2151480wmc.130.1597405182109; Fri, 14 Aug 2020 04:39:42 -0700 (PDT) Received: from dell.default ([95.149.164.62]) by smtp.gmail.com with ESMTPSA id 32sm16409129wrh.18.2020.08.14.04.39.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 14 Aug 2020 04:39:41 -0700 (PDT) From: Lee Jones To: davem@davemloft.net, kuba@kernel.org Cc: linux-kernel@vger.kernel.org, Lee Jones , Jay Vosburgh , Veaceslav Falico , Andy Gospodarek , Thomas Davis , netdev@vger.kernel.org Subject: [PATCH 02/30] net: bonding: bond_main: Document 'proto' and rename 'new_active' parameters Date: Fri, 14 Aug 2020 12:39:05 +0100 Message-Id: <20200814113933.1903438-3-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200814113933.1903438-1-lee.jones@linaro.org> References: <20200814113933.1903438-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/net/bonding/bond_main.c:329: warning: Function parameter or member 'proto' not described in 'bond_vlan_rx_add_vid' drivers/net/bonding/bond_main.c:362: warning: Function parameter or member 'proto' not described in 'bond_vlan_rx_kill_vid' drivers/net/bonding/bond_main.c:964: warning: Function parameter or member 'new_active' not described in 'bond_change_active_slave' drivers/net/bonding/bond_main.c:964: warning: Excess function parameter 'new' description in 'bond_change_active_slave' Cc: Jay Vosburgh Cc: Veaceslav Falico Cc: Andy Gospodarek Cc: "David S. Miller" Cc: Jakub Kicinski Cc: Thomas Davis Cc: netdev@vger.kernel.org Signed-off-by: Lee Jones --- drivers/net/bonding/bond_main.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) -- 2.25.1 diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c index 5ad43aaf76e56..a448467d8789a 100644 --- a/drivers/net/bonding/bond_main.c +++ b/drivers/net/bonding/bond_main.c @@ -322,6 +322,7 @@ netdev_tx_t bond_dev_queue_xmit(struct bonding *bond, struct sk_buff *skb, /** * bond_vlan_rx_add_vid - Propagates adding an id to slaves * @bond_dev: bonding net device that got called + * @proto: network protocol ID * @vid: vlan id being added */ static int bond_vlan_rx_add_vid(struct net_device *bond_dev, @@ -355,6 +356,7 @@ static int bond_vlan_rx_add_vid(struct net_device *bond_dev, /** * bond_vlan_rx_kill_vid - Propagates deleting an id to slaves * @bond_dev: bonding net device that got called + * @proto: network protocol ID * @vid: vlan id being removed */ static int bond_vlan_rx_kill_vid(struct net_device *bond_dev, @@ -948,7 +950,7 @@ static bool bond_should_notify_peers(struct bonding *bond) /** * change_active_interface - change the active slave into the specified one * @bond: our bonding struct - * @new: the new slave to make the active one + * @new_active: the new slave to make the active one * * Set the new slave to the bond's settings and unset them on the old * curr_active_slave.