From patchwork Thu Oct 29 10:07:25 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ioana Ciornei X-Patchwork-Id: 316049 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.6 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,HK_RANDOM_FROM,INCLUDES_PATCH, MAILING_LIST_MULTI, SIGNED_OFF_BY, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A068CC55178 for ; Thu, 29 Oct 2020 10:08:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 43D0320790 for ; Thu, 29 Oct 2020 10:08:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="tNzBDghI" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726561AbgJ2KIr (ORCPT ); Thu, 29 Oct 2020 06:08:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52942 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726464AbgJ2KIp (ORCPT ); Thu, 29 Oct 2020 06:08:45 -0400 Received: from mail-ed1-x542.google.com (mail-ed1-x542.google.com [IPv6:2a00:1450:4864:20::542]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 09958C0613CF; Thu, 29 Oct 2020 03:08:45 -0700 (PDT) Received: by mail-ed1-x542.google.com with SMTP id v19so2412153edx.9; Thu, 29 Oct 2020 03:08:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=gCZxev2ha8Fo2QPH4Cy6SfUb+bofgsivfOY4ybWBIZg=; b=tNzBDghI9//MaoMaCCkPLO8017S1Tb1fuk54sAkrL8dysFQLhqRAcXONdVcPfA6f4U cfZighrF6pKdZz73DuNhWRkbydKsrRRPdgB4XDbLyytKGbZ8RdnYn8JOW+lyuJMjrQK3 nFh6uz3Vt6cKRACCLIo61UvGYKMRA7+qiESXP9nE9qvdsqlbuBibz7bNXTW7jeHa4ulz YrxEiVYSIu9yojSzrHK4yzNgDmTpYlH693Z72ddH973zu+GWGwRCniH3e9+byXoOUvPX 8lAoJpS+FPLRvxsOXQjwlJ/IKHcXZBc7ZOg4mw0Mqh9HOjOaB5Z4SdHn5V5BadppmsLA XrsQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=gCZxev2ha8Fo2QPH4Cy6SfUb+bofgsivfOY4ybWBIZg=; b=rCAUq4CoutJYgGAcmeZ5LPAA4ekF8I/gY/Ft+pSHJ5jmWy8BsOs51yNZoNPFhuuppV SOxaGP8SP3s7SRx80hWtGTpuyixoYnHSCuh7XOP0Ql4GxxEWn3yEfy8qgohHrjUZ72Fv 8Ye4luIoly62QS9bDNSGw8FDwsOwCftRTE9VQwim51RyiWc+yjrmEXHcrcb7nOwjlnwU U2A2G5ghK8JUSAMzA4gfoBJn0FTqdyl9Gok16g+FL5Gdhw2ZxtrFtkAZBvvYMWzsYosd 5at1UyvpKtOklcUojg+nmU4E9TRkDHQzW/phcDDP1e/Pmzawj54EktM0GRziKw1CsPzF nnyw== X-Gm-Message-State: AOAM533pPQ8rGSz27wtVBtr96s0LVC+VRKEhM7mzhdp5TI3aYdXZqKEg yU6j29UVsEbfIKNwNJPJvok= X-Google-Smtp-Source: ABdhPJz/N9AvJdBDfUaOACtC3ODaDOetSKX2ZQP3nLqv5p2iPCRcC/tIPYWVG1uGi7zpTJzdG3+p6w== X-Received: by 2002:a05:6402:142a:: with SMTP id c10mr3180675edx.261.1603966123723; Thu, 29 Oct 2020 03:08:43 -0700 (PDT) Received: from yoga-910.localhost ([188.25.2.177]) by smtp.gmail.com with ESMTPSA id m1sm1198650ejj.117.2020.10.29.03.08.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Oct 2020 03:08:43 -0700 (PDT) From: Ioana Ciornei To: Andrew Lunn , Heiner Kallweit , Russell King , Jakub Kicinski , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Ioana Ciornei , Alexandru Ardelean , Andre Edich , Antoine Tenart , Baruch Siach , Christophe Leroy , Dan Murphy , Divya Koppera , Florian Fainelli , Hauke Mehrtens , Jerome Brunet , Kavya Sree Kotagiri , Linus Walleij , Marco Felsch , Marek Vasut , Martin Blumenstingl , Mathias Kresin , Maxim Kochetkov , Michael Walle , Neil Armstrong , Nisar Sayed , Oleksij Rempel , Philippe Schenker , Willy Liu , Yuiko Oshino Subject: [PATCH net-next 03/19] net: phy: make .ack_interrupt() optional Date: Thu, 29 Oct 2020 12:07:25 +0200 Message-Id: <20201029100741.462818-4-ciorneiioana@gmail.com> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20201029100741.462818-1-ciorneiioana@gmail.com> References: <20201029100741.462818-1-ciorneiioana@gmail.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Ioana Ciornei As a first step into making phylib and all PHY drivers to actually have support for shared IRQs, make the .ack_interrupt() callback optional. After all drivers have been moved to implement the generic interrupt handle, the phy_drv_supports_irq() check will be changed again to only require the .handle_interrupts() callback. Cc: Alexandru Ardelean Cc: Andre Edich Cc: Antoine Tenart Cc: Baruch Siach Cc: Christophe Leroy Cc: Dan Murphy Cc: Divya Koppera Cc: Florian Fainelli Cc: Hauke Mehrtens Cc: Heiner Kallweit Cc: Jerome Brunet Cc: Kavya Sree Kotagiri Cc: Linus Walleij Cc: Marco Felsch Cc: Marek Vasut Cc: Martin Blumenstingl Cc: Mathias Kresin Cc: Maxim Kochetkov Cc: Michael Walle Cc: Neil Armstrong Cc: Nisar Sayed Cc: Oleksij Rempel Cc: Philippe Schenker Cc: Willy Liu Cc: Yuiko Oshino Signed-off-by: Ioana Ciornei --- drivers/net/phy/phy_device.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/phy/phy_device.c b/drivers/net/phy/phy_device.c index 413a0a2c5d51..f54f483d7fd6 100644 --- a/drivers/net/phy/phy_device.c +++ b/drivers/net/phy/phy_device.c @@ -2815,7 +2815,7 @@ EXPORT_SYMBOL(phy_get_internal_delay); static bool phy_drv_supports_irq(struct phy_driver *phydrv) { - return phydrv->config_intr && phydrv->ack_interrupt; + return phydrv->config_intr && (phydrv->ack_interrupt || phydrv->handle_interrupt); } /**