diff mbox series

[v3,net-next,12/12] net: dsa: tag_ar9331: let DSA core deal with TX reallocation

Message ID 20201101191620.589272-13-vladimir.oltean@nxp.com
State Superseded
Headers show
Series Generic TX reallocation for DSA | expand

Commit Message

Vladimir Oltean Nov. 1, 2020, 7:16 p.m. UTC 
Now that we have a central TX reallocation procedure that accounts for
the tagger's needed headroom in a generic way, we can remove the
skb_cow_head call.

Cc: Per Forlin <per.forlin@axis.com>
Cc: Oleksij Rempel <linux@rempel-privat.de>
Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Tested-by: Oleksij Rempel <linux@rempel-privat.de>
---
Changes in v3:
None.

Changes in v2:
None.

 net/dsa/tag_ar9331.c | 3 ---
 1 file changed, 3 deletions(-)

Comments

Florian Fainelli Nov. 2, 2020, 8:52 p.m. UTC | #1 
On 11/1/2020 11:16 AM, Vladimir Oltean wrote:
> Now that we have a central TX reallocation procedure that accounts for

> the tagger's needed headroom in a generic way, we can remove the

> skb_cow_head call.

> 

> Cc: Per Forlin <per.forlin@axis.com>

> Cc: Oleksij Rempel <linux@rempel-privat.de>

> Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>

> Tested-by: Oleksij Rempel <linux@rempel-privat.de>


Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>

-- 
Florian
diff mbox series

Patch

diff --git a/net/dsa/tag_ar9331.c b/net/dsa/tag_ar9331.c
index 55b00694cdba..002cf7f952e2 100644
--- a/net/dsa/tag_ar9331.c
+++ b/net/dsa/tag_ar9331.c
@@ -31,9 +31,6 @@  static struct sk_buff *ar9331_tag_xmit(struct sk_buff *skb,
 	__le16 *phdr;
 	u16 hdr;
 
-	if (skb_cow_head(skb, AR9331_HDR_LEN) < 0)
-		return NULL;
-
 	phdr = skb_push(skb, AR9331_HDR_LEN);
 
 	hdr = FIELD_PREP(AR9331_HDR_VERSION_MASK, AR9331_HDR_VERSION);