From patchwork Wed Nov 4 09:06:10 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 320517 Delivered-To: patch@linaro.org Received: by 2002:a92:7b12:0:0:0:0:0 with SMTP id w18csp5278219ilc; Wed, 4 Nov 2020 01:06:52 -0800 (PST) X-Google-Smtp-Source: ABdhPJyNq5F16tp+5F1UX395/SakJIzJGrXeEJvDdAfZbww1HG0ZsoeTShqeyzZ4WnZgnlbTgum1 X-Received: by 2002:aa7:c90a:: with SMTP id b10mr5920373edt.266.1604480812200; Wed, 04 Nov 2020 01:06:52 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1604480812; cv=none; d=google.com; s=arc-20160816; b=JlcPUXlA5n1rRsQlpsZe2XuVVtjRwsFMBeeJUPf8eqodF/4ILEgCogyY8XZn4SzNJ1 jNNdiP8JMooxCTq8NFiyuxTY4bLmOn+SU5QDVBM9AkHknufPU6fvS6lgfhUNnESecPgN x4Ix2JtY7ENxGAXbVx4FSVZ1TDmu7E75JRX7pfJugtmKvCwK2EPLT7FpVMroVSqnrmpd 0+SIxhyTH534o0zbayoayn1bKsOzlX9AcR7deXbJv0ZAemi5SgEI0w6f1BQFAc9Lmkrt c+pGE7vy1tLi5pItvw3aDf+RR2K5m4rSlKx2A8AsAAsKxrTDl/F2O5laAAY1jyK8gEpX rIfw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=hCoWNpiCY5I/CQYGLXURefOzHbVXVRlIXhsHqYI/w30=; b=JYg9JnXYicQJbzExLKL5d2TRNXl6NzHm9OnT4Lgr87dA8l5ywXbeaQp2q9vWzQRnyl hxeBlzQsG/f40/ATclZMVWfzUaYJc3rxEBbFdBcuwEdHdZVY+jj7jwp7nsafRiuaCQjQ jBX2O5HCo5a/6TupOBMthyavRVM9Vd4yl74B1zIWOkyXL3QLGlMm6Z6c9E+b8bT60VPb zrsTupoioJ4i3RQ/ZKS4HX26ajxZgGf8DZzceMALQkk5RRg9a704yrkeGZQTday9StGT miSenN8wH0XKoC1dvetzQhOriSPbUGV2UN2XclDZb4/QkF7Xs3l25+u1emu+27wsJdjr oY+g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=vwJYvf5t; spf=pass (google.com: domain of netdev-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=netdev-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id u19si1018874ejc.310.2020.11.04.01.06.52; Wed, 04 Nov 2020 01:06:52 -0800 (PST) Received-SPF: pass (google.com: domain of netdev-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=vwJYvf5t; spf=pass (google.com: domain of netdev-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=netdev-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729086AbgKDJGr (ORCPT + 8 others); Wed, 4 Nov 2020 04:06:47 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51178 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729037AbgKDJGm (ORCPT ); Wed, 4 Nov 2020 04:06:42 -0500 Received: from mail-wr1-x444.google.com (mail-wr1-x444.google.com [IPv6:2a00:1450:4864:20::444]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5E892C0401C4 for ; Wed, 4 Nov 2020 01:06:40 -0800 (PST) Received: by mail-wr1-x444.google.com with SMTP id x7so21206350wrl.3 for ; Wed, 04 Nov 2020 01:06:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=hCoWNpiCY5I/CQYGLXURefOzHbVXVRlIXhsHqYI/w30=; b=vwJYvf5tSu7houONcmY2RH0gAqaH3s1DrvDwNkF4scpQukej3gO26Urf1rHRcXlx7G B2whz/j1yA3d9bp292+5xEZLWicfY9GfbwHm4C6yccYuE9OZmNKeLxI5PBb//bQitl+E v6nlckH1Km93jQw2G02u45i90OEKa58QkQJKwuVrgtTcvR2aoDTlVT2T+iFhz7AEFzBt 4/GD1b8f73SRPihSSmP/Qu1gKvWTXZV54+o+y+7Dlakhv8SCIvaIOrhA7JHtfRDLugEK W+adwHbrSM4M/7sWpJ5Qu1vE6cyyvCWOjhiqzAcVRe3JrHoLI/3pZfXIMko92etRfCXg uymA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=hCoWNpiCY5I/CQYGLXURefOzHbVXVRlIXhsHqYI/w30=; b=scGqo5dCNM37gc6dg8w3I4I1zas9hf2gh6Brt1lRSkZlbtXl7FmhxcFQS9n+1Qq1c1 Z0yZ8dWKxuu/8Z2v/Xic5sJbtzs0tu88VZfvVEZcQxs9J/QyGLX+hHohGNSXdiMGQFbR EzZtRSubHcRjXytGgz3meGNX16j8nDedVwheW/dpuSEKNgawluwECFmSx2NGNaxaF9Aj uVeeDI4L1J9lUdLPakVP1cUghiq44dCm0TvBRw/yM+LdUtfmsVfHG2ApOBAYYMhXTt94 uLdIvCbMDc90vfo6aXSfTahfEno3Xyr2sL87tCXtvyaYMSA7AkcQaKJ3yGH8ATAWI1bo kNpw== X-Gm-Message-State: AOAM530vYorMsxbNFL9Mna+1HfFX6lsXsJPVTopnnYcwEShHntWJFB1l acup1T48KsqGfnxOlAemLUZU5A== X-Received: by 2002:adf:a195:: with SMTP id u21mr24545841wru.132.1604480799084; Wed, 04 Nov 2020 01:06:39 -0800 (PST) Received: from dell.default ([91.110.221.242]) by smtp.gmail.com with ESMTPSA id e25sm1607823wrc.76.2020.11.04.01.06.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Nov 2020 01:06:38 -0800 (PST) From: Lee Jones To: davem@davemloft.net, kuba@kernel.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Lee Jones , Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , Dany Madden , Lijun Pan , Sukadev Bhattiprolu , Santiago Leon , Thomas Falcon , John Allen , linuxppc-dev@lists.ozlabs.org, netdev@vger.kernel.org Subject: [PATCH 12/12] net: ethernet: ibm: ibmvnic: Fix some kernel-doc issues Date: Wed, 4 Nov 2020 09:06:10 +0000 Message-Id: <20201104090610.1446616-13-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201104090610.1446616-1-lee.jones@linaro.org> References: <20201104090610.1446616-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Fixes the following W=1 kernel build warning(s): from drivers/net/ethernet/ibm/ibmvnic.c:35: inlined from ‘handle_vpd_rsp’ at drivers/net/ethernet/ibm/ibmvnic.c:4124:3: drivers/net/ethernet/ibm/ibmvnic.c:1362: warning: Function parameter or member 'hdr_data' not described in 'build_hdr_data' drivers/net/ethernet/ibm/ibmvnic.c:1362: warning: Excess function parameter 'tot_len' description in 'build_hdr_data' drivers/net/ethernet/ibm/ibmvnic.c:1423: warning: Function parameter or member 'hdr_data' not described in 'create_hdr_descs' drivers/net/ethernet/ibm/ibmvnic.c:1423: warning: Excess function parameter 'data' description in 'create_hdr_descs' drivers/net/ethernet/ibm/ibmvnic.c:1474: warning: Function parameter or member 'txbuff' not described in 'build_hdr_descs_arr' drivers/net/ethernet/ibm/ibmvnic.c:1474: warning: Excess function parameter 'skb' description in 'build_hdr_descs_arr' drivers/net/ethernet/ibm/ibmvnic.c:1474: warning: Excess function parameter 'subcrq' description in 'build_hdr_descs_arr' Cc: Michael Ellerman Cc: Benjamin Herrenschmidt Cc: Paul Mackerras Cc: Dany Madden Cc: Lijun Pan Cc: Sukadev Bhattiprolu Cc: "David S. Miller" Cc: Jakub Kicinski Cc: Santiago Leon Cc: Thomas Falcon Cc: John Allen Cc: linuxppc-dev@lists.ozlabs.org Cc: netdev@vger.kernel.org Signed-off-by: Lee Jones --- drivers/net/ethernet/ibm/ibmvnic.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) -- 2.25.1 Reviewed-by: Dany Madden diff --git a/drivers/net/ethernet/ibm/ibmvnic.c b/drivers/net/ethernet/ibm/ibmvnic.c index b30e1f5784bad..08dab7a94b7ea 100644 --- a/drivers/net/ethernet/ibm/ibmvnic.c +++ b/drivers/net/ethernet/ibm/ibmvnic.c @@ -1360,7 +1360,7 @@ static int ibmvnic_close(struct net_device *netdev) * @hdr_field: bitfield determining needed headers * @skb: socket buffer * @hdr_len: array of header lengths - * @tot_len: total length of data + * @hdr_data: buffer to write the header to * * Reads hdr_field to determine which headers are needed by firmware. * Builds a buffer containing these headers. Saves individual header @@ -1418,7 +1418,7 @@ static int build_hdr_data(u8 hdr_field, struct sk_buff *skb, /** * create_hdr_descs - create header and header extension descriptors * @hdr_field: bitfield determining needed headers - * @data: buffer containing header data + * @hdr_data: buffer containing header data * @len: length of data buffer * @hdr_len: array of individual header lengths * @scrq_arr: descriptor array @@ -1469,9 +1469,8 @@ static int create_hdr_descs(u8 hdr_field, u8 *hdr_data, int len, int *hdr_len, /** * build_hdr_descs_arr - build a header descriptor array - * @skb: socket buffer + * @txbuff: tx buffer * @num_entries: number of descriptors to be sent - * @subcrq: first TX descriptor * @hdr_field: bit field determining which headers will be sent * * This function will build a TX descriptor array with applicable