From patchwork Wed Nov 4 09:06:06 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 320521 Delivered-To: patch@linaro.org Received: by 2002:a92:7b12:0:0:0:0:0 with SMTP id w18csp5278905ilc; Wed, 4 Nov 2020 01:08:03 -0800 (PST) X-Google-Smtp-Source: ABdhPJwNqryYPxIXsjVXn98DMqEqUsBHt8QNXAJb94R21tQ9e58+bULjpjIPbbBnJRE27/4BUcT3 X-Received: by 2002:a17:906:b0d6:: with SMTP id bk22mr23751907ejb.153.1604480883761; Wed, 04 Nov 2020 01:08:03 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1604480883; cv=none; d=google.com; s=arc-20160816; b=mASFYzGsKB/nb+HsrXRd1EI4UuAjSg2TvK78GE6SxaQJ8YGMRHmdgAacvdQq92BwfG XY5xYPeBAzaevTSXlz3/hQN/HvkNaij5OEAlgOyKZ5VjQSu8SwL2v7ILixbe1b6pPGlm n3II1Z+v2vT9RQJtLM4+QILx/7mnXiRtZIhubzfKwwS61JCS25kAiganJd8LWKh0f2r5 oBvwW3BTAQTtA1Q3OXAVVqKvV6frmU+dsasH7Yuan/MWQdW74/Eb97K4DfJuRKCP9MOg qE06jgvDbMerBAVoilWnUEFtkvG++bF4xIvgu4proJfM1oTCxJT/Mhh/zBgC4i+W/jcb fkSQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=kRmJDRZK6hYnZwsJWtSyII6GRFG28FGG7WVn2jtoat0=; b=lkhMhPZ/kIqv4TcloMe8DYHPeeUsdYd4Cwj8DsoaFwBo+dBvaKAywM0VsiX+vSXb81 CiMvkT0wmcj4aqLCLd5nDJlJys/mwglGAaLAP2BSv/Nqa/Z0NoWpXW51kC6rx4SrCfVs WXPp1nUyq+8htW8w0x4aYt5fj7bLid9s86AODDVZUoZrAm8vq7wWHCKkiWmqWwWUeKni o2AREyxyja3duIQ3ZbVaBNsMXdIFzwf2Mq1psEA51P3gHbox18pnMbddehggfbC18z6d BCUKi+zJe/D4ls44dKczuXNCpncLOy7irNO2sMh7ierX0k/3d1axNTCCly2WzRzia/C7 N5EA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Vy0ifnFN; spf=pass (google.com: domain of netdev-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=netdev-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id d21si1134330ejz.214.2020.11.04.01.08.03; Wed, 04 Nov 2020 01:08:03 -0800 (PST) Received-SPF: pass (google.com: domain of netdev-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Vy0ifnFN; spf=pass (google.com: domain of netdev-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=netdev-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729231AbgKDJIA (ORCPT + 8 others); Wed, 4 Nov 2020 04:08:00 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51154 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728960AbgKDJGg (ORCPT ); Wed, 4 Nov 2020 04:06:36 -0500 Received: from mail-wm1-x341.google.com (mail-wm1-x341.google.com [IPv6:2a00:1450:4864:20::341]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2C3B2C0401C1 for ; Wed, 4 Nov 2020 01:06:35 -0800 (PST) Received: by mail-wm1-x341.google.com with SMTP id p19so1423454wmg.0 for ; Wed, 04 Nov 2020 01:06:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=kRmJDRZK6hYnZwsJWtSyII6GRFG28FGG7WVn2jtoat0=; b=Vy0ifnFNZsdam2EYQqrtqEkqnpo+nDE+vtZ1Exog/zDTxcDNqjIjGsjIU1pi4kN3El WJb+mUgrcdzGRp3ibB8ikQUE/nHlWxpqRKWFVzAojniHotRo1+HOdbKPDVdxQrzIx6sR o5bH/KMSqaIrUmQaZkvfPrv1gFxI//c+XLeUSm9xVA3kwk7Z26qKNIX1zX0RkPnJ08Uu 3N/AsWZ+Jl5bU+SZ4vt/SsxAgf4VmWQbEcGIUXSUX2VSwqItVn590AY7hkgF110FhA9z j+QBoryGrshn3GGWS2c27qqPt497aXTtIabvKKAeyhw/gsk+3P4aFPmg5/JE0C/2HE/p rbiQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=kRmJDRZK6hYnZwsJWtSyII6GRFG28FGG7WVn2jtoat0=; b=nUMm05gonfnB4lWaFs1472nmLdUNxW4azgt6ZgNqfUta1vTBwQvb6fY/ec8Dq9joAR fXkaSXjGeqylpCgMIedZkS6BLHTad0PfwvyDBOYU86l1c6hyCkBiapJCGfIQr5UlxkLp 3uh0tDnr3+RByeRlKCOuPYBJ7B2zbCKk9Kwr9h83rLz2ebbfVKhQVgIIyJaRvabA6lO9 sIQi7pjyirmZl9v/kY+VlaAaX23b4TGUa3VYhh9bbp+6MV3HK6g7zJ1jsmzob9MM4F0s XGcqh+XicxN+KlBFwVNXuuQbl8bI4LmumaJircBILkOzT+3awn4XPG4fWAkp4CzlYuMi E4nA== X-Gm-Message-State: AOAM532b0DDqQek2MRtKKdOC3WqCpGpGZe+1Juf+BAvkelJt0xuXTUMJ aL8rkgzEQ43AQ0p3egCJja8Qhg== X-Received: by 2002:a1c:1dc1:: with SMTP id d184mr3360241wmd.169.1604480793874; Wed, 04 Nov 2020 01:06:33 -0800 (PST) Received: from dell.default ([91.110.221.242]) by smtp.gmail.com with ESMTPSA id e25sm1607823wrc.76.2020.11.04.01.06.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Nov 2020 01:06:33 -0800 (PST) From: Lee Jones To: davem@davemloft.net, kuba@kernel.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Lee Jones , Boris Ostrovsky , Juergen Gross , Stefano Stabellini , Alexei Starovoitov , Daniel Borkmann , Jesper Dangaard Brouer , John Fastabend , Martin KaFai Lau , Song Liu , Yonghong Song , Andrii Nakryiko , KP Singh , xen-devel@lists.xenproject.org, netdev@vger.kernel.org, bpf@vger.kernel.org Subject: [PATCH 08/12] net: xen-netfront: Demote non-kernel-doc headers to standard comment blocks Date: Wed, 4 Nov 2020 09:06:06 +0000 Message-Id: <20201104090610.1446616-9-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201104090610.1446616-1-lee.jones@linaro.org> References: <20201104090610.1446616-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/net/xen-netfront.c: In function ‘store_rxbuf’: drivers/net/xen-netfront.c:2416:16: warning: variable ‘target’ set but not used [-Wunused-but-set-variable] drivers/net/xen-netfront.c:1592: warning: Function parameter or member 'dev' not described in 'netfront_probe' drivers/net/xen-netfront.c:1592: warning: Function parameter or member 'id' not described in 'netfront_probe' drivers/net/xen-netfront.c:1669: warning: Function parameter or member 'dev' not described in 'netfront_resume' drivers/net/xen-netfront.c:2313: warning: Function parameter or member 'dev' not described in 'netback_changed' drivers/net/xen-netfront.c:2313: warning: Function parameter or member 'backend_state' not described in 'netback_changed' Cc: Boris Ostrovsky Cc: Juergen Gross Cc: Stefano Stabellini Cc: "David S. Miller" Cc: Jakub Kicinski Cc: Alexei Starovoitov Cc: Daniel Borkmann Cc: Jesper Dangaard Brouer Cc: John Fastabend Cc: Martin KaFai Lau Cc: Song Liu Cc: Yonghong Song Cc: Andrii Nakryiko Cc: KP Singh Cc: xen-devel@lists.xenproject.org Cc: netdev@vger.kernel.org Cc: bpf@vger.kernel.org Signed-off-by: Lee Jones --- drivers/net/xen-netfront.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) -- 2.25.1 Reviewed-by: Juergen Gross diff --git a/drivers/net/xen-netfront.c b/drivers/net/xen-netfront.c index 920cac4385bf7..93740ef4cf1b4 100644 --- a/drivers/net/xen-netfront.c +++ b/drivers/net/xen-netfront.c @@ -1582,7 +1582,7 @@ static struct net_device *xennet_create_dev(struct xenbus_device *dev) return ERR_PTR(err); } -/** +/* * Entry point to this code when a new device is created. Allocate the basic * structures and the ring buffers for communication with the backend, and * inform the backend of the appropriate details for those. @@ -1659,7 +1659,7 @@ static void xennet_disconnect_backend(struct netfront_info *info) } } -/** +/* * We are reconnecting to the backend, due to a suspend/resume, or a backend * driver restart. We tear down our netif structure and recreate it, but * leave the device-layer structures intact so that this is transparent to the @@ -2305,7 +2305,7 @@ static int xennet_connect(struct net_device *dev) return 0; } -/** +/* * Callback received when the backend's state changes. */ static void netback_changed(struct xenbus_device *dev,