From patchwork Wed Dec 2 12:33:44 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jonas Bonn X-Patchwork-Id: 336572 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER, INCLUDES_PATCH, MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DCA25C83014 for ; Wed, 2 Dec 2020 12:34:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8737622203 for ; Wed, 2 Dec 2020 12:34:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727181AbgLBMei (ORCPT ); Wed, 2 Dec 2020 07:34:38 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53090 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727066AbgLBMeh (ORCPT ); Wed, 2 Dec 2020 07:34:37 -0500 Received: from mail-lf1-x143.google.com (mail-lf1-x143.google.com [IPv6:2a00:1450:4864:20::143]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 059DAC061A04 for ; Wed, 2 Dec 2020 04:33:53 -0800 (PST) Received: by mail-lf1-x143.google.com with SMTP id u18so4403877lfd.9 for ; Wed, 02 Dec 2020 04:33:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=norrbonn-se.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=bIEvPF6uAlOusLOWdiQWcOfYNoZoRxWo1vGs3pnAlms=; b=2Q++9XqvDTBERf9LkNlpoJl/3WuqkmpMNCoXi0WgBMUbA/vNyhv4PXUU17RflpO2wj GRjoi2SVrJ06bZ6NyaMEUoI3GNYzdLZ5xIo24m9X8Zda3S//96+BRdh4WOw3pT0mVtH/ q12DdWo5KICy8kVIwGLenFGZ+Sp+PF0DZ+NhnZeM3lpOQjeBPZDhW+SiODiBYH5iYMog /TOCGOs0RogQiTfmWcygxTPyGOP9m6kjUmM5CUlazS/TauRd6ElK2FIfzXwOEdDtMco9 nlTcUxV1y3HZIp3owP+LTDVG28M6UB6aDLcWDwJdM4Kh0Wbobdo+quUNwTx4Rbh9BgFQ GTSw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=bIEvPF6uAlOusLOWdiQWcOfYNoZoRxWo1vGs3pnAlms=; b=S3x+ik1lEZdOLyLUfxRn+RZZ00ILkMdyHLp3rMtBmRrmmA45UypWftcZLFlALV80eq DOrH6RjXBnis03lTkkAAPSrBvDG0vJmmYLmqZSkp8yBB8VEia2YSY54ACPPLHY5kYceg T/QDI8I5LhI8NvP74iQAFTnV2O6fiqvzRDT/RKRV1fzNzSzGPcx+JOwrtRjKWtggBTPd VsZnlZkbN4e0qEO+oWComgY0aP0YZgnA1e2PKm8Qlo5GMRvoN+Mr3jf3xaglv8TmrDXi IHwHI4G/M6MF0j/z0nStcduyNMZcJpuNN8lGIN4dgHidnu26ljKHWttXYkb/opSe384+ LLWQ== X-Gm-Message-State: AOAM532v0TQG2jjOlFmT++nwqFi+yw1kG+o+sKvZtkeQeYSVQ027AY1/ 1hmg+c4/aktboYQkbvlZkKe3Tls6u8Be6Q== X-Google-Smtp-Source: ABdhPJyON2nCljwXZjF2n1H3o+S0g8xcPtNo9IG9L4uNObeJpkYCk1hZlIoAxvQNq1eN7HMHwiq7HQ== X-Received: by 2002:a19:8883:: with SMTP id k125mr1094028lfd.10.1606912431420; Wed, 02 Dec 2020 04:33:51 -0800 (PST) Received: from mimer.lan (h-137-65.A159.priv.bahnhof.se. [81.170.137.65]) by smtp.gmail.com with ESMTPSA id m7sm439230ljb.8.2020.12.02.04.33.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Dec 2020 04:33:50 -0800 (PST) From: Jonas Bonn To: netdev@vger.kernel.org, pablo@netfilter.org Cc: laforge@gnumonks.org, Jonas Bonn Subject: [PATCH 4/5] gtp: drop unnecessary call to skb_dst_drop Date: Wed, 2 Dec 2020 13:33:44 +0100 Message-Id: <20201202123345.565657-4-jonas@norrbonn.se> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20201202123345.565657-1-jonas@norrbonn.se> References: <20201202123345.565657-1-jonas@norrbonn.se> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org The call to skb_dst_drop() is already done as part of udp_tunnel_xmit(). Signed-off-by: Jonas Bonn --- drivers/net/gtp.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/net/gtp.c b/drivers/net/gtp.c index e053f86f43f3..c19465458187 100644 --- a/drivers/net/gtp.c +++ b/drivers/net/gtp.c @@ -515,8 +515,6 @@ static int gtp_build_skb_ip4(struct sk_buff *skb, struct net_device *dev, goto err_rt; } - skb_dst_drop(skb); - /* This is similar to tnl_update_pmtu(). */ df = iph->frag_off; if (df) {