From patchwork Mon Mar 15 13:34:50 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alex Elder X-Patchwork-Id: 400432 Delivered-To: patch@linaro.org Received: by 2002:a02:8562:0:0:0:0:0 with SMTP id g89csp3424712jai; Mon, 15 Mar 2021 06:35:47 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzvLIeKoblql1NnO+CdBKf9PJSNFtw/oRs8TxFUCTfkrpuXK8JxvmqIwQykNhr2GNYIkBzM X-Received: by 2002:a05:6402:5211:: with SMTP id s17mr30566684edd.327.1615815347628; Mon, 15 Mar 2021 06:35:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1615815347; cv=none; d=google.com; s=arc-20160816; b=hq6e+IMTRePUSVAPY8cGjgTpyX/vjTNI7+zBUlaQMVuCq28RZY9xgyxLica3/lYcjs JWPFz7Abmv856RdRwnWju1IuToxbvoWa//KdpM4TrXVp+avWWicSNZU1OAig9uPffuBn NDBnLe7VzfoNjtgR9yLSjgDJ8NscHR19oc+R0czah2b3t9jFT2FAjWg9EmGvr3c9W038 k9SBBJc+9iM5wx2F7GHNQcIdzN78wUHGWwBezsgBLRObfvaTI7JcpCgf6HJeyxsiuZO3 mmaal9pv0oY6oOouKtlhr6SEtOSPEXjGy4G5TAfZtBr2VjyIIAn1cKlRUcRGxTZWhLw4 yoZw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=siv8ALjvw5nAWM5oVnlAOXA/08MIyz7olXglWGx22ko=; b=wXxaWVvz2P6TfWLtMsPRxORpG9HVQf2J/U+dMnMyWbzH1snSlPieiJBcA/3ZvYr4te tslJMMbjOJzY2TGr4YVsk6VhD4ymLwZHVJNaKxWff0wTm8usO5CVJQIea1CN3GdkCCec yejRcoZ8npyBICfy2kFevJLCe2yjbFm9gFK+ajT89i/WiuizBEI0HADPL9HplrmmBuuK ec3By6izRh1v/Fh7zkZF0Z7ktnro+JZGb6fvxcg6MSiwHFEs1L+Sa6RtkGBTBAe3lXQR HYkGIqye2irSoVQGGO8AyYmMyUxQOp1Rl2sK+hUKxyJqLLi4+gNyXRjoynBZyxQoT5xK DbzA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=l7lFexo0; spf=pass (google.com: domain of netdev-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=netdev-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id s18si11097004edr.249.2021.03.15.06.35.47; Mon, 15 Mar 2021 06:35:47 -0700 (PDT) Received-SPF: pass (google.com: domain of netdev-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=l7lFexo0; spf=pass (google.com: domain of netdev-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=netdev-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229602AbhCONfP (ORCPT + 8 others); Mon, 15 Mar 2021 09:35:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39278 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229605AbhCONfA (ORCPT ); Mon, 15 Mar 2021 09:35:00 -0400 Received: from mail-io1-xd36.google.com (mail-io1-xd36.google.com [IPv6:2607:f8b0:4864:20::d36]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B9D0FC06175F for ; Mon, 15 Mar 2021 06:35:00 -0700 (PDT) Received: by mail-io1-xd36.google.com with SMTP id u20so33315505iot.9 for ; Mon, 15 Mar 2021 06:35:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=siv8ALjvw5nAWM5oVnlAOXA/08MIyz7olXglWGx22ko=; b=l7lFexo0b5S+LJMcrD4VEZOBoMyKEJdpy4GLKvP0UuCvCnZ/Ib2cwt2IirxXVgzThr WGXcio2aZZAf5pUeJq9HINoY4eXbx0M/YwqVz9/LnGNtPGjJJ4FyZE+SxwGde1+7hqGM lenXuPW6+0QRD7PesJZr0tWyGrSNUd+TK8QIMBjiayLv4ah3H8DmPOHt6R/JwjOVUvhg jf5QF+/aXCEwR4OMZ0bp51EpnMrHrsVPBqa6jIF98l3XbyYsuIRvJgREeW0Z73Mt+PDb GcMrMIImU1ldqtyQnk6NcFd4sJju0L8BD8IVIyNfsH+FIiEBTJDmiQMPVhrV/U65PNsl 1F0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=siv8ALjvw5nAWM5oVnlAOXA/08MIyz7olXglWGx22ko=; b=D4wlCQGJlezwMvDY/Q8+NPv3ve+3PMPpPSlBwsSUMA9dIPCl92cCjZ9xME1TfkBFiE UGP/qHTWJazQ7KzvplYX2vBy+UxgWZ1bkJlU2jRyCDawVapOiEp5EOl7EeZBjyRuU+R6 FyND1hblV7wbiAYK7s44z0abSLtNcRwek2b3hoFYG8n3j08x9sAROJDy1/B52nI2AlvB tZtvZgKXrxB/iwN+h9IhkOf4lBsaET7wfXAiCqTY8YimkrZb3O/Zr41SoU3vZapUPBzw jRCougkQ9FQLmhYqwS4YThiJ5AuVFdVHcfR6/kJ2WgSE+sf0GAezXlGu3P1Cdxo7mybu vVEw== X-Gm-Message-State: AOAM53282ZNd3He9ERHYZhuE8PEwRa7tUbJeXKis3D3YTfpiGPPXvERa zaXEdg1tQWax679amyZwnbiiqQ== X-Received: by 2002:a02:a90f:: with SMTP id n15mr9697057jam.110.1615815300258; Mon, 15 Mar 2021 06:35:00 -0700 (PDT) Received: from localhost.localdomain (c-73-185-129-58.hsd1.mn.comcast.net. [73.185.129.58]) by smtp.gmail.com with ESMTPSA id o23sm7127672ioo.24.2021.03.15.06.34.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Mar 2021 06:34:59 -0700 (PDT) From: Alex Elder To: subashab@codeaurora.org, stranche@codeaurora.org, davem@davemloft.net, kuba@kernel.org Cc: sharathv@codeaurora.org, bjorn.andersson@linaro.org, evgreen@chromium.org, cpratapa@codeaurora.org, David.Laight@ACULAB.COM, olteanv@gmail.com, elder@kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH net-next v4 1/6] net: qualcomm: rmnet: mark trailer field endianness Date: Mon, 15 Mar 2021 08:34:50 -0500 Message-Id: <20210315133455.1576188-2-elder@linaro.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210315133455.1576188-1-elder@linaro.org> References: <20210315133455.1576188-1-elder@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org The fields in the checksum trailer structure used for QMAP protocol RX packets are all big-endian format, so define them that way. It turns out these fields are never actually used by the RMNet code. The start offset is always assumed to be zero, and the length is taken from the other packet headers. So making these fields explicitly big endian has no effect on the behavior of the code. Signed-off-by: Alex Elder Reviewed-by: Bjorn Andersson --- include/linux/if_rmnet.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- 2.27.0 diff --git a/include/linux/if_rmnet.h b/include/linux/if_rmnet.h index 9661416a9bb47..8c7845baf3837 100644 --- a/include/linux/if_rmnet.h +++ b/include/linux/if_rmnet.h @@ -32,8 +32,8 @@ struct rmnet_map_dl_csum_trailer { #else #error "Please fix " #endif - u16 csum_start_offset; - u16 csum_length; + __be16 csum_start_offset; + __be16 csum_length; __be16 csum_value; } __aligned(1);