From patchwork Mon Mar 15 21:51:46 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alex Elder X-Patchwork-Id: 400554 Delivered-To: patch@linaro.org Received: by 2002:a02:8562:0:0:0:0:0 with SMTP id g89csp3784283jai; Mon, 15 Mar 2021 14:52:37 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyjO+mPGVmjJT1VYBxlNwHQxE1ZkdLg66X2303lk03WkHK9PvpQu0ocdn+eds32nFrftOjU X-Received: by 2002:a17:906:24c7:: with SMTP id f7mr25749278ejb.473.1615845157201; Mon, 15 Mar 2021 14:52:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1615845157; cv=none; d=google.com; s=arc-20160816; b=fqT4P0FmS3UYJaYC6HclnBPHwSkkJ86CTQiD3I6mF2oNiJAPH5IgkDB4L1RE8QqlGM I0MkUtEtbuvJsn7Vq5mZ114Sf4s0kS/EBz4lRyNJ4hE7dIvi/QQy+k9bvcY0oboBOGZj 62Zt8yZGpDOk1HupnqlhrR0mVFf3irZmKkFfLPTpxFV8oLZzmeCN4t8Wt/1WSYy1ElqO G6j+m7FfDNe7m/DTW0EbxMlVQUYLPmfvEQ5KCFj+Sy9HMhzX7N7qKI1YzIbf22aLs62z YSlE1OiBV0Vtw1blqu2ty4CZ92pOgM1XZdZ+zJd9VdSdMh5K/6jQpIbjwZHnGgRlJjfu BXHg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=tkE3LmGUj01YPH3BPs1/nEBfeLQdWBdBqpXnFwRgcR4=; b=flsyZeuUqRN7kDuVooQxSSP/UYZ32hpsqS7XTf7vKQuTCx+yZ9uA369YPvff1KEv4Y J1eRjpTHU7QUjoFCae7n4NrXgFRsN7aZjI3PcK2mdbCkUQ2n9ssf58tByBFjc6LpuiE6 ThSap0+MpWsXkLkiwikdKdcmYhA6DsHXavJyi9ZUO6lh4vc5UGkq0Zn5SYe8MctHHSwa HFLCK1oDY+IHN6V3zdb6AeHUW1vITgHpOJ0ysT5y2mbj4n7CrsmgbOK3WbI80E+Uppsb /M9cUFdS/R2Ab/u2WNmRQKbTtX9B1ovD/yl19rmdWJLk5zdu9b0gzdJpSOjbasd0IbH5 Iwxw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=hRSakI25; spf=pass (google.com: domain of netdev-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=netdev-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id c13si12173560eje.45.2021.03.15.14.52.37; Mon, 15 Mar 2021 14:52:37 -0700 (PDT) Received-SPF: pass (google.com: domain of netdev-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=hRSakI25; spf=pass (google.com: domain of netdev-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=netdev-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231233AbhCOVwF (ORCPT + 8 others); Mon, 15 Mar 2021 17:52:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34474 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231558AbhCOVv4 (ORCPT ); Mon, 15 Mar 2021 17:51:56 -0400 Received: from mail-io1-xd29.google.com (mail-io1-xd29.google.com [IPv6:2607:f8b0:4864:20::d29]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C6CBAC06175F for ; Mon, 15 Mar 2021 14:51:56 -0700 (PDT) Received: by mail-io1-xd29.google.com with SMTP id f20so35009945ioo.10 for ; Mon, 15 Mar 2021 14:51:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=tkE3LmGUj01YPH3BPs1/nEBfeLQdWBdBqpXnFwRgcR4=; b=hRSakI25uH/iqPFFwdYMutKVZkBqZDAiup5YEL0MEXGQQB8+ccGfQy8VEfOFnwdDUv X3GT0uWFTky5HvlgFc3ReSioSYnABS6VYnZoKDacviUuSfibMUEm5B/icGkIAnTkGIPB wH2d7OGxd0ZbUn+LFp5aGKzZje0rN77Ewhmp4f8cXL0RgML8D0eUA/bqcbfY6bFrD02f jR/hAwSTk9hadNE/elS86jdJEnZjGzQQrJffrtXYsHaltpk8W1jawXj43qD/cwxK428y Au3q2fQYRw/OpKDKQkm9nUpWFrD8oE+TusW68mH8W3dzPOPCN/pMUdB2NsgdipE6TnKG ZZvQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=tkE3LmGUj01YPH3BPs1/nEBfeLQdWBdBqpXnFwRgcR4=; b=heufmJlu3tQF7baXI2IZUUBk5YMdPcJ8jLIEiMr5J07ehNrLJ60SRuC4pkY8TpHOhQ vfqiN/tOCvLyNnG1ks0MOKEJUzvWGm8cxnrcog/hpOxRO1q8Ib7pas4E35gSJOVEZBo4 ukbXSWT6efjMkiFBxCZCMaoC7NldGrBVdVVb0uzSE1yUhqW4lG7+7gT7TIIWk5INg+VW hxKX4c+XGVen7IK/pWXm9zI01q/aGG4YoNKV64p2rqfglrU6lvRMtMZpb35edtnj04lg 5SKF3U4+fBR6zx4VMfMQXYarKNq6jIJjG0Z21qVV4o5Z5BuRImiK7VWC61K4Tr8B/yWN 66rQ== X-Gm-Message-State: AOAM533JtMKN4TUG6xtDf2w8pbXkqNiti5GsLOL3rLWGCVSDmvCTH5bf Fbvy1T6KyRS6KmDViw2X3vaUAw== X-Received: by 2002:a02:9645:: with SMTP id c63mr11445641jai.84.1615845116270; Mon, 15 Mar 2021 14:51:56 -0700 (PDT) Received: from localhost.localdomain (c-73-185-129-58.hsd1.mn.comcast.net. [73.185.129.58]) by smtp.gmail.com with ESMTPSA id y3sm7424625iot.15.2021.03.15.14.51.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Mar 2021 14:51:55 -0700 (PDT) From: Alex Elder To: subashab@codeaurora.org, stranche@codeaurora.org, davem@davemloft.net, kuba@kernel.org Cc: sharathv@codeaurora.org, bjorn.andersson@linaro.org, evgreen@chromium.org, cpratapa@codeaurora.org, David.Laight@ACULAB.COM, olteanv@gmail.com, alexander.duyck@gmail.com, elder@kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Alexander Duyck Subject: [PATCH net-next v6 1/6] net: qualcomm: rmnet: mark trailer field endianness Date: Mon, 15 Mar 2021 16:51:46 -0500 Message-Id: <20210315215151.3029676-2-elder@linaro.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210315215151.3029676-1-elder@linaro.org> References: <20210315215151.3029676-1-elder@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org The fields in the checksum trailer structure used for QMAP protocol RX packets are all big-endian format, so define them that way. It turns out these fields are never actually used by the RMNet code. The start offset is always assumed to be zero, and the length is taken from the other packet headers. So making these fields explicitly big endian has no effect on the behavior of the code. Signed-off-by: Alex Elder Reviewed-by: Bjorn Andersson Reviewed-by: Alexander Duyck --- include/linux/if_rmnet.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- 2.27.0 diff --git a/include/linux/if_rmnet.h b/include/linux/if_rmnet.h index 9661416a9bb47..8c7845baf3837 100644 --- a/include/linux/if_rmnet.h +++ b/include/linux/if_rmnet.h @@ -32,8 +32,8 @@ struct rmnet_map_dl_csum_trailer { #else #error "Please fix " #endif - u16 csum_start_offset; - u16 csum_length; + __be16 csum_start_offset; + __be16 csum_length; __be16 csum_value; } __aligned(1);