From patchwork Thu Mar 18 18:42:23 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Alexander Lobakin X-Patchwork-Id: 405333 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER, INCLUDES_PATCH, MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7597CC4332D for ; Thu, 18 Mar 2021 18:43:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 231A964F53 for ; Thu, 18 Mar 2021 18:43:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232725AbhCRSmo (ORCPT ); Thu, 18 Mar 2021 14:42:44 -0400 Received: from mail-40133.protonmail.ch ([185.70.40.133]:22084 "EHLO mail-40133.protonmail.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232675AbhCRSmg (ORCPT ); Thu, 18 Mar 2021 14:42:36 -0400 Date: Thu, 18 Mar 2021 18:42:23 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pm.me; s=protonmail; t=1616092954; bh=uga/a2V2PAZhoIbIvMFpYDGIy1+3tARpQIkiT76KT3w=; h=Date:To:From:Cc:Reply-To:Subject:In-Reply-To:References:From; b=g+3uQ5rbOLP8AEv2fyaFf/ESl7FCCuqGZ4kYFQ5fg7g6BHeobyHW4uYMyLMPrFwT8 93lfmMvjWSm4Iij/A+3wYYovZDDdEkurVnsdWd6yCqK3gSX5iNfRAmQxXt4E4v2LtT 5901nfIkdM6UmnxfI8pDeGtOfnGl84JMVQLh6ka2uqvo+SzvCQYa6gwpQB9v2Lr3ah zLa3mb5+NrEkW3IqGvJQbqSP05UnuSnJyGbZbTkAjGJA5xiyjaFY5vs9pxGwggyUJR r6FSgbcTPY7HZ/GDWnLoChC6TRgtofpGmt8t1eMrrprRTXVF0vOgshekcKGhpjPxz6 vBDiHSI7DWZmg== To: "David S. Miller" , Jakub Kicinski From: Alexander Lobakin Cc: Alexander Lobakin , Mauro Carvalho Chehab , Kirill Tkhai , Bartosz Golaszewski , Leon Romanovsky , Eric Dumazet , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Reply-To: Alexander Lobakin Subject: [PATCH net-next 1/4] gro: make net/gro.h self-contained Message-ID: <20210318184157.700604-2-alobakin@pm.me> In-Reply-To: <20210318184157.700604-1-alobakin@pm.me> References: <20210318184157.700604-1-alobakin@pm.me> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org If some source file includes , but doesn't include : In file included from net/8021q/vlan_core.c:7: ./include/net/gro.h:6:1: warning: data definition has no type or storage class 6 | INDIRECT_CALLABLE_DECLARE(struct sk_buff *ipv6_gro_receive(struct list_head *, | ^~~~~~~~~~~~~~~~~~~~~~~~~ ./include/net/gro.h:6:1: error: type defaults to ‘int’ in declaration of ‘INDIRECT_CALLABLE_DECLARE’ [-Werror=implicit-int] [...] Include directly. It's small and won't pull lots of dependencies. Also add some incomplete struct declarations to be fully stacked. Fixes: 04f00ab2275f ("net/core: move gro function declarations to separate header ") Signed-off-by: Alexander Lobakin --- include/net/gro.h | 5 +++++ 1 file changed, 5 insertions(+) -- 2.31.0 diff --git a/include/net/gro.h b/include/net/gro.h index 8a6eb5303cc4..27c38b36df16 100644 --- a/include/net/gro.h +++ b/include/net/gro.h @@ -3,6 +3,11 @@ #ifndef _NET_IPV6_GRO_H #define _NET_IPV6_GRO_H +#include + +struct list_head; +struct sk_buff; + INDIRECT_CALLABLE_DECLARE(struct sk_buff *ipv6_gro_receive(struct list_head *, struct sk_buff *)); INDIRECT_CALLABLE_DECLARE(int ipv6_gro_complete(struct sk_buff *, int));