From patchwork Thu Apr 22 09:42:56 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Prasanna Vengateshan X-Patchwork-Id: 426189 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER, INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B381CC433ED for ; Thu, 22 Apr 2021 09:44:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7F820600EF for ; Thu, 22 Apr 2021 09:44:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235957AbhDVJoj (ORCPT ); Thu, 22 Apr 2021 05:44:39 -0400 Received: from esa.microchip.iphmx.com ([68.232.153.233]:10116 "EHLO esa.microchip.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235925AbhDVJoh (ORCPT ); Thu, 22 Apr 2021 05:44:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1619084643; x=1650620643; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=Zl+dq70yJi0nwuzD/RsYbc7LZj2sYn/GdcGLmZ8GhbQ=; b=h9lAfTJmQAQsqBVk6P+dPxTFe9y2EBltwbXa+CRBOw/8x7oKnVDNXANJ jjWqnjj6w9bnm2YvvZezPAZ/rYm+Y7c+xL7uozilBSsEFuQtkqQTkv8eM c2xMaMQ9TWhAwvAYdO8uN9oFortbJ1MbJgpjPp+gDvpyIcBqiHn9OhH9Z DPLN6L5UES9veXqF1zuubWNuNs9J+5gwDvHeZ+bOObIyfBfphXXW1NfPm Rc2KDWTk9yF668xqrLFNcCiFoCx3A/sJiZ7xUKt+CCYovMir0DAhMDpTA 97Ng0LvpPhNc1MaBUz1jar12CxwGHJgBgTXKlopgVMMcH6/oRL0J7RGMx A==; IronPort-SDR: MDQ9Q7XnHxxxVPKpmSFJ6WLcTNkhNxAoCLWNeyMJdDFrtfrU1keRSvvedEhpzll/X1TErs6w7m PGSdFsAM0nCYzuqM50PFXvFa7N87V6xYSlnrRYRI0y7GeJOTAclmYo/kXvHYTX4XVWMgCx/Tzs QMxXJLzl4k3Y0lyRGrFlayMJxSSTiK6/O24cdSTnfRXbCFv4Fg1WKkPBjtODzi0DSQIVapoDPQ cwQWQDzEGWypvcsMwFNKYYxl1ROXdaXYtwpBnmlWT0QcssuCZshoZ+oHuxZEGR6un7FfQ7lIwd KWA= X-IronPort-AV: E=Sophos;i="5.82,242,1613458800"; d="scan'208";a="117417343" Received: from smtpout.microchip.com (HELO email.microchip.com) ([198.175.253.82]) by esa5.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 22 Apr 2021 02:44:03 -0700 Received: from chn-vm-ex01.mchp-main.com (10.10.85.143) by chn-vm-ex01.mchp-main.com (10.10.85.143) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Thu, 22 Apr 2021 02:44:02 -0700 Received: from CHE-LT-I21427LX.microchip.com (10.10.115.15) by chn-vm-ex01.mchp-main.com (10.10.85.143) with Microsoft SMTP Server id 15.1.2176.2 via Frontend Transport; Thu, 22 Apr 2021 02:43:54 -0700 From: Prasanna Vengateshan To: , , , CC: , , , , , , , , Subject: [PATCH v2 net-next 8/9] net: dsa: microchip: add support for fdb and mdb management Date: Thu, 22 Apr 2021 15:12:56 +0530 Message-ID: <20210422094257.1641396-9-prasanna.vengateshan@microchip.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210422094257.1641396-1-prasanna.vengateshan@microchip.com> References: <20210422094257.1641396-1-prasanna.vengateshan@microchip.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Support for fdb_add, mdb_add, fdb_del, mdb_del and fdb_dump operations It aligns with latest update of removing switchdev transactional logic from mdb entries Signed-off-by: Prasanna Vengateshan --- drivers/net/dsa/microchip/lan937x_main.c | 516 +++++++++++++++++++++++ 1 file changed, 516 insertions(+) diff --git a/drivers/net/dsa/microchip/lan937x_main.c b/drivers/net/dsa/microchip/lan937x_main.c index bfce5098ea69..7f6183dc0e31 100644 --- a/drivers/net/dsa/microchip/lan937x_main.c +++ b/drivers/net/dsa/microchip/lan937x_main.c @@ -14,6 +14,68 @@ #include "ksz_common.h" #include "lan937x_dev.h" +static int lan937x_read_table(struct ksz_device *dev, u32 *table) +{ + int rc; + + /* read alu table */ + rc = ksz_read32(dev, REG_SW_ALU_VAL_A, &table[0]); + if (rc < 0) + return rc; + + rc = ksz_read32(dev, REG_SW_ALU_VAL_B, &table[1]); + if (rc < 0) + return rc; + + rc = ksz_read32(dev, REG_SW_ALU_VAL_C, &table[2]); + if (rc < 0) + return rc; + + rc = ksz_read32(dev, REG_SW_ALU_VAL_D, &table[3]); + + return rc; +} + +static int lan937x_write_table(struct ksz_device *dev, u32 *table) +{ + int rc; + + /* write alu table */ + rc = ksz_write32(dev, REG_SW_ALU_VAL_A, table[0]); + if (rc < 0) + return rc; + + rc = ksz_write32(dev, REG_SW_ALU_VAL_B, table[1]); + if (rc < 0) + return rc; + + rc = ksz_write32(dev, REG_SW_ALU_VAL_C, table[2]); + if (rc < 0) + return rc; + + rc = ksz_write32(dev, REG_SW_ALU_VAL_D, table[3]); + + return rc; +} + +static int lan937x_wait_alu_ready(int alu, struct ksz_device *dev) +{ + unsigned int val; + + return regmap_read_poll_timeout(dev->regmap[2], REG_SW_ALU_CTRL(alu), + val, !(val & ALU_START), 10, 1000); +} + +static int lan937x_wait_alu_sta_ready(struct ksz_device *dev) +{ + unsigned int val; + + return regmap_read_poll_timeout(dev->regmap[2], + REG_SW_ALU_STAT_CTRL__4, + val, !(val & ALU_STAT_START), + 10, 1000); +} + static enum dsa_tag_protocol lan937x_get_tag_protocol(struct dsa_switch *ds, int port, enum dsa_tag_protocol mp) @@ -128,6 +190,455 @@ static void lan937x_port_stp_state_set(struct dsa_switch *ds, int port, mutex_unlock(&dev->dev_mutex); } +static u8 lan937x_get_fid(u16 vid) +{ + if (vid > ALU_FID_SIZE) + return LAN937X_GET_FID(vid); + else + return vid; +} + +static int lan937x_port_fdb_add(struct dsa_switch *ds, int port, + const unsigned char *addr, u16 vid) +{ + struct ksz_device *dev = ds->priv; + u8 fid = lan937x_get_fid(vid); + u32 alu_table[4]; + int rc, i; + u32 data; + u8 val; + + mutex_lock(&dev->alu_mutex); + + for (i = 0; i < ALU_STA_DYN_CNT; i++) { + /* find any entry with mac & fid */ + data = fid << ALU_FID_INDEX_S; + data |= ((addr[0] << 8) | addr[1]); + + rc = ksz_write32(dev, REG_SW_ALU_INDEX_0, data); + if (rc < 0) + goto exit; + + data = ((addr[2] << 24) | (addr[3] << 16)); + data |= ((addr[4] << 8) | addr[5]); + + rc = ksz_write32(dev, REG_SW_ALU_INDEX_1, data); + if (rc < 0) + goto exit; + + /* start read operation */ + rc = ksz_write32(dev, REG_SW_ALU_CTRL(i), ALU_READ | ALU_START); + if (rc < 0) + goto exit; + + /* wait to be finished */ + rc = lan937x_wait_alu_ready(i, dev); + if (rc < 0) { + dev_err(dev->dev, "Failed to read ALU\n"); + goto exit; + } + + /* read ALU entry */ + rc = lan937x_read_table(dev, alu_table); + if (rc < 0) { + dev_err(dev->dev, "Failed to read ALU\n"); + goto exit; + } + + /* update ALU entry */ + alu_table[0] = ALU_V_STATIC_VALID; + + /* update port number */ + alu_table[1] |= BIT(port); + + if (fid) + alu_table[1] |= ALU_V_USE_FID; + alu_table[2] = (fid << ALU_V_FID_S); + alu_table[2] |= ((addr[0] << 8) | addr[1]); + alu_table[3] = ((addr[2] << 24) | (addr[3] << 16)); + alu_table[3] |= ((addr[4] << 8) | addr[5]); + + rc = lan937x_write_table(dev, alu_table); + if (rc < 0) + goto exit; + + rc = ksz_write32(dev, REG_SW_ALU_CTRL(i), ALU_WRITE | ALU_START); + if (rc < 0) + goto exit; + + /* wait to be finished */ + rc = lan937x_wait_alu_ready(i, dev); + + if (rc < 0) { + dev_err(dev->dev, "Failed to write ALU\n"); + goto exit; + } + + rc = ksz_read8(dev, REG_SW_LUE_INT_STATUS__1, &val); + if (rc < 0) + goto exit; + + /* ALU write failed & do not return before checking ALU2*/ + if (val & WRITE_FAIL_INT && i == 1) + dev_err(dev->dev, "Failed to write ALU\n"); + + /* ALU1 write failed and attempt to write ALU2, otherwise exit*/ + if (val & WRITE_FAIL_INT) { + /* Write to clear the Write Fail */ + rc = ksz_write8(dev, REG_SW_LUE_INT_STATUS__1, WRITE_FAIL_INT); + if (rc < 0) + goto exit; + } else { + goto exit; + } + } + +exit: + mutex_unlock(&dev->alu_mutex); + + return rc; +} + +static int lan937x_port_fdb_del(struct dsa_switch *ds, int port, + const unsigned char *addr, u16 vid) +{ + struct ksz_device *dev = ds->priv; + u8 fid = lan937x_get_fid(vid); + u32 alu_table[4]; + int rc, i; + u32 data; + + mutex_lock(&dev->alu_mutex); + + for (i = 0; i < ALU_STA_DYN_CNT; i++) { + /* read any entry with mac & fid */ + data = fid << ALU_FID_INDEX_S; + data |= ((addr[0] << 8) | addr[1]); + rc = ksz_write32(dev, REG_SW_ALU_INDEX_0, data); + if (rc < 0) + goto exit; + + data = ((addr[2] << 24) | (addr[3] << 16)); + data |= ((addr[4] << 8) | addr[5]); + rc = ksz_write32(dev, REG_SW_ALU_INDEX_1, data); + if (rc < 0) + goto exit; + + /* start read operation */ + rc = ksz_write32(dev, REG_SW_ALU_CTRL(i), ALU_READ | ALU_START); + if (rc < 0) + goto exit; + + /* wait to be finished */ + rc = lan937x_wait_alu_ready(i, dev); + if (rc < 0) { + dev_err(dev->dev, "Failed to read ALU\n"); + goto exit; + } + + rc = ksz_read32(dev, REG_SW_ALU_VAL_A, &alu_table[0]); + if (rc < 0) + goto exit; + + if (alu_table[0] & ALU_V_STATIC_VALID) { + /* read ALU entry */ + rc = lan937x_read_table(dev, alu_table); + if (rc < 0) { + dev_err(dev->dev, "Failed to read ALU\n"); + goto exit; + } + + /* clear forwarding port */ + alu_table[1] &= ~BIT(port); + + /* if there is no port to forward, clear table */ + if ((alu_table[1] & ALU_V_PORT_MAP) == 0) { + alu_table[0] = 0; + alu_table[1] = 0; + alu_table[2] = 0; + alu_table[3] = 0; + } + } else { + alu_table[0] = 0; + alu_table[1] = 0; + alu_table[2] = 0; + alu_table[3] = 0; + } + + rc = lan937x_write_table(dev, alu_table); + if (rc < 0) + goto exit; + + rc = ksz_write32(dev, REG_SW_ALU_CTRL(i), ALU_WRITE | ALU_START); + if (rc < 0) + goto exit; + + /* wait to be finished */ + rc = lan937x_wait_alu_ready(i, dev); + if (rc < 0) + dev_err(dev->dev, "Failed to write ALU\n"); + } + +exit: + mutex_unlock(&dev->alu_mutex); + + return rc; +} + +static void lan937x_convert_alu(struct lan_alu_struct *alu, u32 *alu_table) +{ + alu->is_static = !!(alu_table[0] & ALU_V_STATIC_VALID); + alu->is_src_filter = !!(alu_table[0] & ALU_V_SRC_FILTER); + alu->is_dst_filter = !!(alu_table[0] & ALU_V_DST_FILTER); + alu->prio_age = (alu_table[0] >> ALU_V_PRIO_AGE_CNT_S) & + ALU_V_PRIO_AGE_CNT_M; + alu->mstp = alu_table[0] & ALU_V_MSTP_M; + + alu->is_override = !!(alu_table[1] & ALU_V_OVERRIDE); + alu->is_use_fid = !!(alu_table[1] & ALU_V_USE_FID); + alu->port_forward = alu_table[1] & ALU_V_PORT_MAP; + + alu->fid = (alu_table[2] >> ALU_V_FID_S) & ALU_V_FID_M; + + alu->mac[0] = (alu_table[2] >> 8) & 0xFF; + alu->mac[1] = alu_table[2] & 0xFF; + alu->mac[2] = (alu_table[3] >> 24) & 0xFF; + alu->mac[3] = (alu_table[3] >> 16) & 0xFF; + alu->mac[4] = (alu_table[3] >> 8) & 0xFF; + alu->mac[5] = alu_table[3] & 0xFF; +} + +static int lan937x_port_fdb_dump(struct dsa_switch *ds, int port, + dsa_fdb_dump_cb_t *cb, void *data) +{ + struct ksz_device *dev = ds->priv; + struct lan_alu_struct alu; + u32 lan937x_data; + u32 alu_table[4]; + int timeout; + int rc, i; + + mutex_lock(&dev->alu_mutex); + + for (i = 0; i < ALU_STA_DYN_CNT; i++) { + /* start ALU search */ + rc = ksz_write32(dev, REG_SW_ALU_CTRL(i), ALU_START | ALU_SEARCH); + + if (rc < 0) + goto exit; + + do { + timeout = 1000; + do { + rc = ksz_read32(dev, REG_SW_ALU_CTRL(i), &lan937x_data); + + if (rc < 0) + goto exit; + + if ((lan937x_data & ALU_VALID) || !(lan937x_data & ALU_START)) + break; + usleep_range(1, 10); + } while (timeout-- > 0); + + if (!timeout) { + dev_err(dev->dev, "Failed to search ALU\n"); + rc = -ETIMEDOUT; + goto exit; + } + + /* read ALU table */ + rc = lan937x_read_table(dev, alu_table); + if (rc < 0) + goto exit; + + lan937x_convert_alu(&alu, alu_table); + + if (alu.port_forward & BIT(port)) { + rc = cb(alu.mac, alu.fid, alu.is_static, data); + if (rc) + goto exit; + } + } while (lan937x_data & ALU_START); + +exit: + /* stop ALU search & continue to next ALU if available */ + rc = ksz_write32(dev, REG_SW_ALU_CTRL(i), 0); + } + + mutex_unlock(&dev->alu_mutex); + + return rc; +} + +static int lan937x_port_mdb_add(struct dsa_switch *ds, int port, + const struct switchdev_obj_port_mdb *mdb) +{ + struct ksz_device *dev = ds->priv; + u8 fid = lan937x_get_fid(mdb->vid); + u32 static_table[4]; + u32 mac_hi, mac_lo; + int index, rc; + u32 data; + + mac_hi = ((mdb->addr[0] << 8) | mdb->addr[1]); + mac_lo = ((mdb->addr[2] << 24) | (mdb->addr[3] << 16)); + mac_lo |= ((mdb->addr[4] << 8) | mdb->addr[5]); + + mutex_lock(&dev->alu_mutex); + + for (index = 0; index < dev->num_statics; index++) { + /* find empty slot first */ + data = (index << ALU_STAT_INDEX_S) | + ALU_STAT_READ | ALU_STAT_START; + rc = ksz_write32(dev, REG_SW_ALU_STAT_CTRL__4, data); + if (rc < 0) + goto exit; + + /* wait to be finished */ + rc = lan937x_wait_alu_sta_ready(dev); + if (rc < 0) { + dev_err(dev->dev, "Failed to read ALU STATIC\n"); + goto exit; + } + + /* read ALU static table */ + rc = lan937x_read_table(dev, static_table); + if (rc < 0) + goto exit; + + if (static_table[0] & ALU_V_STATIC_VALID) { + /* check this has same fid & mac address */ + if (((static_table[2] >> ALU_V_FID_S) == fid) && + ((static_table[2] & ALU_V_MAC_ADDR_HI) == mac_hi) && + static_table[3] == mac_lo) { + /* found matching one */ + break; + } + } else { + /* found empty one */ + break; + } + } + + /* no available entry */ + if (index == dev->num_statics) { + rc = -ENOSPC; + goto exit; + } + + /* add entry */ + static_table[0] = ALU_V_STATIC_VALID; + + static_table[1] |= BIT(port); + if (fid) + static_table[1] |= ALU_V_USE_FID; + static_table[2] = (fid << ALU_V_FID_S); + static_table[2] |= mac_hi; + static_table[3] = mac_lo; + + rc = lan937x_write_table(dev, static_table); + if (rc < 0) + goto exit; + + data = (index << ALU_STAT_INDEX_S) | ALU_STAT_START; + rc = ksz_write32(dev, REG_SW_ALU_STAT_CTRL__4, data); + if (rc < 0) + goto exit; + + /* wait to be finished */ + rc = lan937x_wait_alu_sta_ready(dev); + if (rc < 0) + dev_err(dev->dev, "Failed to read ALU STATIC\n"); + +exit: + mutex_unlock(&dev->alu_mutex); + return rc; +} + +static int lan937x_port_mdb_del(struct dsa_switch *ds, int port, + const struct switchdev_obj_port_mdb *mdb) +{ + struct ksz_device *dev = ds->priv; + u8 fid = lan937x_get_fid(mdb->vid); + u32 static_table[4]; + u32 mac_hi, mac_lo; + int index, rc; + u32 data; + + mac_hi = ((mdb->addr[0] << 8) | mdb->addr[1]); + mac_lo = ((mdb->addr[2] << 24) | (mdb->addr[3] << 16)); + mac_lo |= ((mdb->addr[4] << 8) | mdb->addr[5]); + + mutex_lock(&dev->alu_mutex); + + for (index = 0; index < dev->num_statics; index++) { + /* find empty slot first */ + data = (index << ALU_STAT_INDEX_S) | + ALU_STAT_READ | ALU_STAT_START; + rc = ksz_write32(dev, REG_SW_ALU_STAT_CTRL__4, data); + if (rc < 0) + goto exit; + + /* wait to be finished */ + rc = lan937x_wait_alu_sta_ready(dev); + if (rc < 0) { + dev_err(dev->dev, "Failed to read ALU STATIC\n"); + goto exit; + } + + /* read ALU static table */ + rc = lan937x_read_table(dev, static_table); + + if (rc < 0) + goto exit; + + if (static_table[0] & ALU_V_STATIC_VALID) { + /* check this has same fid & mac address */ + + if (((static_table[2] >> ALU_V_FID_S) == fid) && + ((static_table[2] & ALU_V_MAC_ADDR_HI) == mac_hi) && + static_table[3] == mac_lo) { + /* found matching one */ + break; + } + } + } + + /* no available entry */ + if (index == dev->num_statics) + goto exit; + + /* clear port based on port arg */ + static_table[1] &= ~BIT(port); + + if ((static_table[1] & ALU_V_PORT_MAP) == 0) { + /* delete entry */ + static_table[0] = 0; + static_table[1] = 0; + static_table[2] = 0; + static_table[3] = 0; + } + + rc = lan937x_write_table(dev, static_table); + if (rc < 0) + goto exit; + + data = (index << ALU_STAT_INDEX_S) | ALU_STAT_START; + rc = ksz_write32(dev, REG_SW_ALU_STAT_CTRL__4, data); + if (rc < 0) + goto exit; + + /* wait to be finished */ + rc = lan937x_wait_alu_sta_ready(dev); + if (rc < 0) + dev_err(dev->dev, "Failed to read ALU STATIC\n"); + +exit: + mutex_unlock(&dev->alu_mutex); + + return rc; +} + static int lan937x_port_mirror_add(struct dsa_switch *ds, int port, struct dsa_mall_mirror_tc_entry *mirror, bool ingress) @@ -444,6 +955,11 @@ const struct dsa_switch_ops lan937x_switch_ops = { .port_bridge_flags = lan937x_port_bridge_flags, .port_stp_state_set = lan937x_port_stp_state_set, .port_fast_age = ksz_port_fast_age, + .port_fdb_dump = lan937x_port_fdb_dump, + .port_fdb_add = lan937x_port_fdb_add, + .port_fdb_del = lan937x_port_fdb_del, + .port_mdb_add = lan937x_port_mdb_add, + .port_mdb_del = lan937x_port_mdb_del, .port_mirror_add = lan937x_port_mirror_add, .port_mirror_del = lan937x_port_mirror_del, .port_max_mtu = lan937x_get_max_mtu,