From patchwork Mon Jul 26 14:11:19 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Marc Kleine-Budde X-Patchwork-Id: 485822 Delivered-To: patch@linaro.org Received: by 2002:a02:c94a:0:0:0:0:0 with SMTP id u10csp3866825jao; Mon, 26 Jul 2021 07:13:50 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzPiGS4YQHkU1fJc7CcaKaK6pjPLZVxxF3kByrFF3pZU0Lc71fXxHDVgpd+tSHk3UN1xlau X-Received: by 2002:a02:7093:: with SMTP id f141mr16586055jac.24.1627308830518; Mon, 26 Jul 2021 07:13:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1627308830; cv=none; d=google.com; s=arc-20160816; b=u0aj1Ea3navnU0E68+GA+yDfecIxic1mf2bHakkppmTSsIXdUIY38C3pFkCyKBfzhV QHEu+46aLldQkJiNHzxsXPZBluXLcyJnaQp7eK+w8dnQH0XCnUMKjO0Q6lLRSvXMq37p swBdel1/FCs90t9Dd8+FUbzisBz3AywdzwxCPYdtwIh0649Xbbtm5AutWEBxoJ3ZRTQO NcgHfEnd6d265FoTyAJHzTk8/+PPdTXnrUEP/I33YyfptquS+dvprzN/IDgLVSG4leVG M5mQCnge0r7CKd9LMqTfWl00EZTnSU5HW+mK5Pc51YdJomPDMeZsnXbKzsrNfNOJ9k7m shnA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=sKS1MAaMc4iWIsWKDkYkOo33gacil841XOBjfhV5kp0=; b=h5X5YM5Fx22lTe7XYJCt+Dpq0H/iw+4u0zfYO9WMaAgO1QFXxvjnm+GNnNMvhXQw/q l6renMq0/O7Y/TbLbMabxIp2Vu8UUp9Ef0UX7s4LEnSeLtgk54o9+FAraG8z7pIZJ7lj yEHAufs8fBuOc/xm+Jte8pbERSe6n12JD3QRToARAC1V4bXzXfiEA3atRT03jFFDjxOm 0eYXALYJ4ARA78CAcY3wmfMQ/GRu5+YLlYXDsY+RymUVrud7kIdBzOkHZp2l5mTAeCko DtLgKEKbC9BLfx9oJdw5ccql2Trg9kE+FQBb31bD5DRXwDdXUZ7HGxzlB4wSzDPJ5LkH /jvw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of netdev-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=netdev-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id d1si26190jak.77.2021.07.26.07.13.50; Mon, 26 Jul 2021 07:13:50 -0700 (PDT) Received-SPF: pass (google.com: domain of netdev-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of netdev-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=netdev-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234419AbhGZNdT (ORCPT + 8 others); Mon, 26 Jul 2021 09:33:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53436 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233816AbhGZNcz (ORCPT ); Mon, 26 Jul 2021 09:32:55 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 84DE4C0617B9 for ; Mon, 26 Jul 2021 07:12:27 -0700 (PDT) Received: from gallifrey.ext.pengutronix.de ([2001:67c:670:201:5054:ff:fe8d:eefb] helo=bjornoya.blackshift.org) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m81LF-0001jg-VE for netdev@vger.kernel.org; Mon, 26 Jul 2021 16:12:26 +0200 Received: from dspam.blackshift.org (localhost [127.0.0.1]) by bjornoya.blackshift.org (Postfix) with SMTP id 3E03165824E for ; Mon, 26 Jul 2021 14:12:10 +0000 (UTC) Received: from hardanger.blackshift.org (unknown [172.20.34.65]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by bjornoya.blackshift.org (Postfix) with ESMTPS id 060DC6581AF; Mon, 26 Jul 2021 14:11:53 +0000 (UTC) Received: from blackshift.org (localhost [::1]) by hardanger.blackshift.org (OpenSMTPD) with ESMTP id 6d2f691e; Mon, 26 Jul 2021 14:11:46 +0000 (UTC) From: Marc Kleine-Budde To: netdev@vger.kernel.org Cc: davem@davemloft.net, kuba@kernel.org, linux-can@vger.kernel.org, kernel@pengutronix.de, Zhen Lei , Marc Kleine-Budde Subject: [PATCH net-next 21/46] can: janz-ican3: use DEVICE_ATTR_RO/RW() helper macro Date: Mon, 26 Jul 2021 16:11:19 +0200 Message-Id: <20210726141144.862529-22-mkl@pengutronix.de> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210726141144.862529-1-mkl@pengutronix.de> References: <20210726141144.862529-1-mkl@pengutronix.de> MIME-Version: 1.0 X-SA-Exim-Connect-IP: 2001:67c:670:201:5054:ff:fe8d:eefb X-SA-Exim-Mail-From: mkl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: netdev@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Zhen Lei Use DEVICE_ATTR_RO/RW() helper macro instead of plain DEVICE_ATTR(), which makes the code a bit shorter and easier to read. Link: https://lore.kernel.org/r/20210603111739.11983-1-thunder.leizhen@huawei.com Signed-off-by: Zhen Lei Signed-off-by: Marc Kleine-Budde --- drivers/net/can/janz-ican3.c | 23 +++++++++++------------ 1 file changed, 11 insertions(+), 12 deletions(-) -- 2.30.2 diff --git a/drivers/net/can/janz-ican3.c b/drivers/net/can/janz-ican3.c index 2a6c918186c0..c68ad56628bd 100644 --- a/drivers/net/can/janz-ican3.c +++ b/drivers/net/can/janz-ican3.c @@ -1815,9 +1815,9 @@ static int ican3_get_berr_counter(const struct net_device *ndev, * Sysfs Attributes */ -static ssize_t ican3_sysfs_show_term(struct device *dev, - struct device_attribute *attr, - char *buf) +static ssize_t termination_show(struct device *dev, + struct device_attribute *attr, + char *buf) { struct ican3_dev *mod = netdev_priv(to_net_dev(dev)); int ret; @@ -1834,9 +1834,9 @@ static ssize_t ican3_sysfs_show_term(struct device *dev, return snprintf(buf, PAGE_SIZE, "%u\n", mod->termination_enabled); } -static ssize_t ican3_sysfs_set_term(struct device *dev, - struct device_attribute *attr, - const char *buf, size_t count) +static ssize_t termination_store(struct device *dev, + struct device_attribute *attr, + const char *buf, size_t count) { struct ican3_dev *mod = netdev_priv(to_net_dev(dev)); unsigned long enable; @@ -1852,18 +1852,17 @@ static ssize_t ican3_sysfs_set_term(struct device *dev, return count; } -static ssize_t ican3_sysfs_show_fwinfo(struct device *dev, - struct device_attribute *attr, - char *buf) +static ssize_t fwinfo_show(struct device *dev, + struct device_attribute *attr, + char *buf) { struct ican3_dev *mod = netdev_priv(to_net_dev(dev)); return scnprintf(buf, PAGE_SIZE, "%s\n", mod->fwinfo); } -static DEVICE_ATTR(termination, 0644, ican3_sysfs_show_term, - ican3_sysfs_set_term); -static DEVICE_ATTR(fwinfo, 0444, ican3_sysfs_show_fwinfo, NULL); +static DEVICE_ATTR_RW(termination); +static DEVICE_ATTR_RO(fwinfo); static struct attribute *ican3_sysfs_attrs[] = { &dev_attr_termination.attr,