| Message ID | 20210816232219.557083-2-saeed@kernel.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [net-next,V2,01/17] net/mlx5e: Do not try enable RSS when resetting indir table | expand |
Hello: This series was applied to netdev/net-next.git (refs/heads/master): On Mon, 16 Aug 2021 16:22:03 -0700 you wrote: > From: Tariq Toukan <tariqt@nvidia.com> > > All calls to mlx5e_rx_res_rss_set_indir_uniform() occur while the RSS > state is inactive, i.e. the RQT is pointing to the drop RQ, not to the > channels' RQs. > It means that the "apply" part of the function is not called. > Remove this part from the function, and document the change. It will be > useful for next patches in the series, allows code simplifications when > multiple RSS contexts are introduced. > > [...] Here is the summary with links: - [net-next,V2,01/17] net/mlx5e: Do not try enable RSS when resetting indir table https://git.kernel.org/netdev/net-next/c/6e5fea51961e - [net-next,V2,02/17] net/mlx5e: Introduce TIR create/destroy API in rx_res https://git.kernel.org/netdev/net-next/c/fc651ff9105a - [net-next,V2,03/17] net/mlx5e: Introduce abstraction of RSS context https://git.kernel.org/netdev/net-next/c/713ba5e5f689 - [net-next,V2,04/17] net/mlx5e: Convert RSS to a dedicated object https://git.kernel.org/netdev/net-next/c/25307a91cb50 - [net-next,V2,05/17] net/mlx5e: Dynamically allocate TIRs in RSS contexts https://git.kernel.org/netdev/net-next/c/49095f641b69 - [net-next,V2,06/17] net/mlx5e: Support multiple RSS contexts https://git.kernel.org/netdev/net-next/c/f01cc58c18d6 - [net-next,V2,07/17] net/mlx5e: Support flow classification into RSS contexts https://git.kernel.org/netdev/net-next/c/248d3b4c9a39 - [net-next,V2,08/17] net/mlx5e: Abstract MQPRIO params https://git.kernel.org/netdev/net-next/c/86d747a3f969 - [net-next,V2,09/17] net/mlx5e: Maintain MQPRIO mode parameter https://git.kernel.org/netdev/net-next/c/e2aeac448f06 - [net-next,V2,10/17] net/mlx5e: Handle errors of netdev_set_num_tc() https://git.kernel.org/netdev/net-next/c/21ecfcb83a85 - [net-next,V2,11/17] net/mlx5e: Support MQPRIO channel mode https://git.kernel.org/netdev/net-next/c/ec60c4581bd9 - [net-next,V2,12/17] net/mlx5: Bridge, release bridge in same function where it is taken https://git.kernel.org/netdev/net-next/c/4de20e9a1225 - [net-next,V2,13/17] net/mlx5: Bridge, obtain core device from eswitch instead of priv https://git.kernel.org/netdev/net-next/c/a514d1735059 - [net-next,V2,14/17] net/mlx5: Bridge, identify port by vport_num+esw_owner_vhca_id pair https://git.kernel.org/netdev/net-next/c/3ee6233e61a1 - [net-next,V2,15/17] net/mlx5: Bridge, extract FDB delete notification to function https://git.kernel.org/netdev/net-next/c/bf3d56d8f55f - [net-next,V2,16/17] net/mlx5: Bridge, allow merged eswitch connectivity https://git.kernel.org/netdev/net-next/c/c358ea1741bc - [net-next,V2,17/17] net/mlx5: Bridge, support LAG https://git.kernel.org/netdev/net-next/c/ff9b7521468b You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en/rx_res.c b/drivers/net/ethernet/mellanox/mlx5/core/en/rx_res.c index e2a8fe13f29d..2d0e8c809936 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/en/rx_res.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/en/rx_res.c @@ -617,14 +617,11 @@ mlx5e_rx_res_rss_get_current_tt_config(struct mlx5e_rx_res *res, enum mlx5_traff return rss_tt; } +/* Updates the indirection table SW shadow, does not update the HW resources yet */ void mlx5e_rx_res_rss_set_indir_uniform(struct mlx5e_rx_res *res, unsigned int nch) { + WARN_ON_ONCE(res->rss_active); mlx5e_rss_params_indir_init_uniform(&res->rss_params.indir, nch); - - if (!res->rss_active) - return; - - mlx5e_rx_res_rss_enable(res); } void mlx5e_rx_res_rss_get_rxfh(struct mlx5e_rx_res *res, u32 *indir, u8 *key, u8 *hfunc)