From patchwork Mon Sep 13 13:01:49 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?SsOpcsO0bWUgUG91aWxsZXI=?= X-Patchwork-Id: 510294 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER, INCLUDES_PATCH, MAILING_LIST_MULTI, MSGID_FROM_MTA_HEADER, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C5955C433FE for ; Mon, 13 Sep 2021 13:06:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B283E6101B for ; Mon, 13 Sep 2021 13:06:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236229AbhIMNHg (ORCPT ); Mon, 13 Sep 2021 09:07:36 -0400 Received: from mail-mw2nam12on2045.outbound.protection.outlook.com ([40.107.244.45]:7936 "EHLO NAM12-MW2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S239855AbhIMNGB (ORCPT ); Mon, 13 Sep 2021 09:06:01 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QBFY77E3PTHGZOrwOItHHlhc5Y9UjVIPIxKQp3L7ZAaA7+yGnxuH0y6GiPCQm2vmvZpFPHv/nOsQHANbgZTI2CdK4c5uCL4x2widT8+QjAgpbEESIqarM79ICA8dm5eHVkPdp5EDA/htZ8GU6zOzdAkNLzFL13GP+smqRHUjJfBL/sLIGXAvebQvPZDwre9rcg30gGPuWmbRrrNHXgdGQ4Apbz/PjJvla9OhCIJ7gAFDR+2vlB9X0cx91nXCuirJw5WAZbB0sh8BblbRuzc39G0FsVuYCUtu9EQ152atoDCDOnf0YQmZHwsx9TmmxPKT+AqtMm5cgDH4Oi9Pi9eQSA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=D2RF/Y6vM+Lj63470xCmRdZGPoY4c0kiDfF+JTD4zDA=; b=dXVHTZ/0ZvO8ySZ+1RZq0yHU/NxRdAI7w7MfAxNiaLTxkDkWCINpk99FbGJmhD7PGqPv3D+vUlHLGIgD8ID6cwxfIErf+uxkmfWBMDaGKXBLbjWEeRyuslHgyVUf3B2yvrkiBLz1VbsFom5ewAgQEgbWAlin4la3JuYD/00mrkF8cwJzFWTawLCDtOg46jaZPMz4OAR5GYjGzhJiFJE5MCL3+aEVHQRsI5dbnjB/abOHmfgT3Tkk/gn9ivpISVsiSEcNRfzS8+Qh/31rFgalh1s2TzVWqnb2ktoVzeMQXaI5iY4/31QaNSm7HGePHNSL++BkM4Yf/4boSkq5FzrMxw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=silabs.com; dmarc=pass action=none header.from=silabs.com; dkim=pass header.d=silabs.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=silabs.onmicrosoft.com; s=selector2-silabs-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=D2RF/Y6vM+Lj63470xCmRdZGPoY4c0kiDfF+JTD4zDA=; b=XwfVVd/I9pCJllhxQI1CEiQy09Zs84aDDfpcqhXx8Bife2UNyxLplUDCOJwGfDQtK2l40BavfUMDAShbY2LD0EzBm+vK/Hna+j+pkb5lsYK+RjQPAM2SpqKMbuHDNYH9wmyGZtOwAhfYDAa+hrGcoheEQrqcehhh1HA1a/EeOjU= Authentication-Results: driverdev.osuosl.org; dkim=none (message not signed) header.d=none; driverdev.osuosl.org; dmarc=none action=none header.from=silabs.com; Received: from SN6PR11MB2718.namprd11.prod.outlook.com (2603:10b6:805:63::18) by SA2PR11MB4860.namprd11.prod.outlook.com (2603:10b6:806:11b::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4500.14; Mon, 13 Sep 2021 13:02:50 +0000 Received: from SN6PR11MB2718.namprd11.prod.outlook.com ([fe80::7050:a0a:415:2ccd]) by SN6PR11MB2718.namprd11.prod.outlook.com ([fe80::7050:a0a:415:2ccd%7]) with mapi id 15.20.4500.017; Mon, 13 Sep 2021 13:02:50 +0000 From: Jerome Pouiller To: devel@driverdev.osuosl.org, linux-wireless@vger.kernel.org Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Greg Kroah-Hartman , Kalle Valo , "David S . Miller" , =?utf-8?b?SsOpcsO0bWUgUG91aWxsZXI=?= Subject: [PATCH v3 18/32] staging: wfx: reorder function for slightly better eye candy Date: Mon, 13 Sep 2021 15:01:49 +0200 Message-Id: <20210913130203.1903622-19-Jerome.Pouiller@silabs.com> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20210913130203.1903622-1-Jerome.Pouiller@silabs.com> References: <20210913130203.1903622-1-Jerome.Pouiller@silabs.com> X-ClientProxiedBy: PR2P264CA0021.FRAP264.PROD.OUTLOOK.COM (2603:10a6:101::33) To SN6PR11MB2718.namprd11.prod.outlook.com (2603:10b6:805:63::18) MIME-Version: 1.0 Received: from pc-42.silabs.com (37.71.187.125) by PR2P264CA0021.FRAP264.PROD.OUTLOOK.COM (2603:10a6:101::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4500.14 via Frontend Transport; Mon, 13 Sep 2021 13:02:49 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 7ec4e442-4351-4801-5ccb-08d976b6caa8 X-MS-TrafficTypeDiagnostic: SA2PR11MB4860: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:483; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: R0ghX04hdSNcbVuHVzoBC/p994LQc1dN7Z8++WYx+UOoMmWEXeFK1zPWfvJXndJ/SWlFMicxgCsZEs7I6UrE+blcC+n7n2pakNwLqEJxpKPZN8y1P5+zXSNlipFspjQufcJ7afJ7QAXRRlDuZ0isqz5naMnTXfPOu6POPweBHogsN5vF7FssmQUK6dDEP33Ibkcf9HvWhdDaY81KlSLnz1yDkdH1xYduOBiWztrefbcDRgOdA0mNIYskvkEfwIoJWyB6R7MnEnWB1SiqPspVIG6rsy9LizcFMHzsoyX3eTLZq0OjgpMBpS4BtX+eu3AWIgG/J0Cho7i6iRmbD5pGwUCJlvpkmMqnBbH7HEIxtsHvHbyTczH73ah5+pGfRBinpaTwSw1Pf7GiQ4GvXMINj5vNjRaqE6zAI0rQ3dbj9JAsP2GLV48rrTTGQn2T2kg/slTqo5yZc5yZOejRvCGYpuXfAON5z4m8RY/mapVy330Ug/uBs+l0pCVI/XSZHN8AP9LSHBG2eZJ2Z3yVPITP+60Q5ev9dDADjWAf520YaGcLyFkYfkUDq+7oIK9h60Wq4yCEOmbxvwNwggUjaFIhhRL3F/euyKEVJT9nNjFSIblUCyDjex0GIr+GHGIN0R0hDidMukCQQKW9UgkDHF+zo+2E1QbbTJJN0vR06FYF6Km/f6wHeD4X1JdCAmh5vQH1b5fcWaTET7qwt7kBsOQSYA== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SN6PR11MB2718.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(956004)(66946007)(2616005)(26005)(36756003)(38100700002)(38350700002)(316002)(4326008)(107886003)(7696005)(54906003)(5660300002)(52116002)(66556008)(1076003)(66476007)(6486002)(508600001)(8936002)(83380400001)(86362001)(2906002)(8676002)(186003); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?QZu6NqyoW09BrUKKdQi/6F0L9?= =?utf-8?q?sIvO39KtQZ1+txy2/LPqddZ5ka6DIbb6SVUzVnyDqfdCaGT58dDxvaaC?= =?utf-8?q?Q6Pvf+IBRNakE4P90seFDK+ws+F3lWMH13tEV8oy/QzXTJVuOMd6hJcJ?= =?utf-8?q?1bDNIaq6IAb9RSumjUklOHeK9WQaUjo7YdvDXeGq3UpJmbiWGUXTmOiO?= =?utf-8?q?W+SxL+JIJv8iXIxXroGLf1DSeYK6+synQxqhmUK806s/ko30cnSlmysa?= =?utf-8?q?yliFjd4ikD/l9LVq/L1gN/8XSdEH9rz+hXhvflAMqHXh1Cov8jcuBRD8?= =?utf-8?q?JfFce4fwpnGRjQuEfGOreVVjNFWJfyZPqmfN/mt3SI4iLL/KAwhbD1CZ?= =?utf-8?q?9vDb18K/rg89SiPitiZJpcrUyjCoGgWFbTvhI9BwNCdfpPeBx3iPcckV?= =?utf-8?q?M9HX2NSNrJAfGpg5QL7+B12aybakWy4ZMDa+al2pNsylMHVqaGjn3BRA?= =?utf-8?q?NG+6a+CacaLlYOIUTBBTGDJ4djiRl6e5GqZmqlDZuAgQIBNpVOEZgGys?= =?utf-8?q?8+xfQt+X5hHEVhqCA9293h4fjA7ES2n58q0W0BSRt9HjdgYXPbQXYyUE?= =?utf-8?q?tJJMyV2Z/QwF0nOer0h+u5NWLboOK8q+zo/O+isB1LZgTtIku/IF5kpo?= =?utf-8?q?B/bav5FrjJTKErjusoEddBAOlHtB69EGLxDytiuqVrtFp0k1aqiVvCHo?= =?utf-8?q?wWR9TCfANgxf/6kYF4sMZ9WUukM8KaC5usgX88XqciM3heIfEzq3cbMT?= =?utf-8?q?o2kLxTLbU16GxxbIKqadsCaCqXJQbuWNhoYKJcs00XDFGIKx9FDfySsE?= =?utf-8?q?bOwd1vKfElDsM4S/IakhVFGAH66nB3x6C1za3w26lgO5CjIi3bKMrr5C?= =?utf-8?q?7vNdxOivZFMGPWedoRWiHBeDKYzADItu2kHbuce8eQYgRat70FcAQ6VB?= =?utf-8?q?W7yZkb/g40ovx5/6f4W6pTJqDt8kF8y6k6Wytog07BnjbFSXE5DK2JkL?= =?utf-8?q?gW0YkSzIJ0Iayaxn6ourRNq/eVXNa9cu9wHPKrWcvkEL1T/CHgiSfPrt?= =?utf-8?q?pvltYnUOya8C9QybVoy/wwOLdo70qmQCj89pbZG91GxqJ9xjCvAS0BhG?= =?utf-8?q?9QZ2IwwrkLAw7cILR0d78eP/66i5JLlB2ja4k+o04HQw1gZu5/zpmcjr?= =?utf-8?q?lcDx7n7f4c/sGGHkheAptW1s6u50mhtx8mY3Tn9J/R6B5HiHsdMJQSrp?= =?utf-8?q?Is9lqPMpzxX2+qkR65eX95m6rYf79U3DL4Lp9XqqJfCXZCHUfILUNM8a?= =?utf-8?q?T488UgHsKOJ7GLC74h7Sov1Vp26SeFdJ7u4a/qtxZQAtuNm1yxWAUrj6?= =?utf-8?q?dfVTZZq8Cnuu3duI6Stfv2YSL4Gyh2J?= X-OriginatorOrg: silabs.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7ec4e442-4351-4801-5ccb-08d976b6caa8 X-MS-Exchange-CrossTenant-AuthSource: SN6PR11MB2718.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Sep 2021 13:02:50.7071 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 54dbd822-5231-4b20-944d-6f4abcd541fb X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: r3sds/xBb3D8DWpImO4sz8aiBCfYQTqUhNz7l/+mHeE4Lxf3b3P56Gn7O+q4mu1uCUmy8zeY/PxPD60T2plqlA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR11MB4860 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Jérôme Pouiller For a code more eye candy, group all the unconditional assignments together. Signed-off-by: Jérôme Pouiller --- drivers/staging/wfx/data_tx.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/wfx/data_tx.c b/drivers/staging/wfx/data_tx.c index 00c305f192bb..77d69ed73e28 100644 --- a/drivers/staging/wfx/data_tx.c +++ b/drivers/staging/wfx/data_tx.c @@ -376,15 +376,15 @@ static int wfx_tx_inner(struct wfx_vif *wvif, struct ieee80211_sta *sta, req->packet_id |= queue_id << 28; req->fc_offset = offset; - if (tx_info->flags & IEEE80211_TX_CTL_SEND_AFTER_DTIM) - req->after_dtim = 1; - req->peer_sta_id = wfx_tx_get_link_id(wvif, sta, hdr); // Queue index are inverted between firmware and Linux req->queue_id = 3 - queue_id; + req->peer_sta_id = wfx_tx_get_link_id(wvif, sta, hdr); req->retry_policy_index = wfx_tx_get_retry_policy_id(wvif, tx_info); req->frame_format = wfx_tx_get_frame_format(tx_info); if (tx_info->driver_rates[0].flags & IEEE80211_TX_RC_SHORT_GI) req->short_gi = 1; + if (tx_info->flags & IEEE80211_TX_CTL_SEND_AFTER_DTIM) + req->after_dtim = 1; // Auxiliary operations wfx_tx_queues_put(wvif, skb);