From patchwork Tue Nov 28 08:57:50 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yaakov Selkowitz X-Patchwork-Id: 119812 Delivered-To: patch@linaro.org Received: by 10.140.22.227 with SMTP id 90csp1440933qgn; Tue, 28 Nov 2017 01:04:56 -0800 (PST) X-Google-Smtp-Source: AGs4zMYq2Lw5J6ZVS8lOx3mSzdNrHD7sOHy0jG8XJLXd3lz3bGQHds3X+5NhZp7XUUBhfN31IyYF X-Received: by 10.159.218.66 with SMTP id x2mr41087604plv.326.1511859895945; Tue, 28 Nov 2017 01:04:55 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1511859895; cv=none; d=google.com; s=arc-20160816; b=p/Oe6z8XSbdPHV8ejdG9ABttd9y+iF6Q0NsCuBc+M1MmDx6Maj64aDAAeDw+ajscc7 viqnA4ToJCZWe+848Mam2j31ogj+DxmHFmsjEtBmJgn44QT9a2bxHfKWUnqWSHDgxWQT oZ+NNei6+jDK0p8LzP5Ktm5OsRGGSrD307yprONqCQjfHqyqL+CXrewMspyns6LGg2Za NqLSIggX56hyly6pgJDH6+wNb1h9PB1n9QHLUOUiB7mSoqdApBuJBVxh6Pn2XVOyuA8L NT0LIzzOuPut1pYp85av4X9OxvsWlSh2oPIGaaTcd4dIR/3joSxEliVfwHtDKN+WY2Ax 07lA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=references:in-reply-to:message-id:date:subject:to:from:delivered-to :sender:list-help:list-post:list-archive:list-subscribe :list-unsubscribe:list-id:precedence:mailing-list:dkim-signature :domainkey-signature:arc-authentication-results; bh=AXfYNCaHkrx3RcBZbrOJjfSPzkllnVBDQUjRiVEL0ts=; b=RkLFjARKN7Ia5u9L9bi+xHVmYL8o7AQfF8E5MoWDS/BWpyxQGuZmESvfjp43EGTpPJ FLmRn7gjJQJmslO8EAYnlqGhUgRp7lXS4sd/Ibrfh3qet6ER75iFRcNu0JmUHT3xd2tS lk1Ky8j1WE/NqKEQfQTLnrJUbNqzI8XkU3IjBPQfekvIdAIG+mQsQg4mW5seasGpabPm GGbWx6n/nrWF2hTwzMyzO9ytlggnwSdbKOz7TBKY16goKRi1LCxwIFiRC5D7b6Mb7DsB rUTNWc5cMUyNWVzDsievvL+VA6SMvj4LoHTyPRsnUQYifJIEd8w0d0LXpPkLIawRleWy kYFw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@sourceware.org header.s=default header.b=WkYCdbtM; spf=pass (google.com: domain of newlib-return-15380-patch=linaro.org@sourceware.org designates 209.132.180.131 as permitted sender) smtp.mailfrom=newlib-return-15380-patch=linaro.org@sourceware.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from sourceware.org (server1.sourceware.org. [209.132.180.131]) by mx.google.com with ESMTPS id t14si7287316pgv.647.2017.11.28.01.04.55 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 28 Nov 2017 01:04:55 -0800 (PST) Received-SPF: pass (google.com: domain of newlib-return-15380-patch=linaro.org@sourceware.org designates 209.132.180.131 as permitted sender) client-ip=209.132.180.131; Authentication-Results: mx.google.com; dkim=pass header.i=@sourceware.org header.s=default header.b=WkYCdbtM; spf=pass (google.com: domain of newlib-return-15380-patch=linaro.org@sourceware.org designates 209.132.180.131 as permitted sender) smtp.mailfrom=newlib-return-15380-patch=linaro.org@sourceware.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:subject:date:message-id:in-reply-to :references; q=dns; s=default; b=WDugOegRko8R40KYGy7NrYD2fmVwDlA VdYA9Mmv/bZEDwVhW3qjlYxerBcxhPI5HLhZnNR9CFbKqJ7WM9RJ3vIdfpATO9/x Czqks8nzjedXlrdprFqMaN+yrBeLCMaTOlBCJnDmPIoaLXE9TP11Q3qSyROo3h8I chB58H+kcts8= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:subject:date:message-id:in-reply-to :references; s=default; bh=l2FfgCiS8bmvo4ONMR1UG5Z54sE=; b=WkYCd btMfeIBxGYVnAtzyLEelGuM4MYxbDzUBAA5JFD51XohrolV8k9VcKIHk6U8+2SD0 biLf2KJUA/rld+vQgsr4/uurNo1O85xeI1pPI83z7ZwX8PyeQA2TrB6zHLgO3bAZ cGbXQIWMW043Lg9SBvRvqk3y/X2aF47ifbNuh4= Received: (qmail 108909 invoked by alias); 28 Nov 2017 09:04:43 -0000 Mailing-List: contact newlib-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: newlib-owner@sourceware.org Delivered-To: mailing list newlib@sourceware.org Received: (qmail 107666 invoked by uid 89); 28 Nov 2017 09:04:27 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-26.7 required=5.0 tests=BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, KB_WAM_FROM_NAME_SINGLEWORD, SPF_HELO_PASS, T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy=Hx-languages-length:3645 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 28 Nov 2017 09:04:21 +0000 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 1F949C04AC44 for ; Tue, 28 Nov 2017 08:58:10 +0000 (UTC) Received: from localhost.localdomain (ovpn-120-142.rdu2.redhat.com [10.10.120.142]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 9E6D15D753 for ; Tue, 28 Nov 2017 08:58:09 +0000 (UTC) From: Yaakov Selkowitz To: newlib@sourceware.org Subject: [PATCH v3 4/9] ssp: add Object Size Checking for strings.h functions Date: Tue, 28 Nov 2017 02:57:50 -0600 Message-Id: <20171128085755.5928-5-yselkowi@redhat.com> In-Reply-To: <20171128085755.5928-1-yselkowi@redhat.com> References: <20171128085755.5928-1-yselkowi@redhat.com> The implementation is from NetBSD, with the addition of explicit_bzero for parity with glibc. Signed-off-by: Yaakov Selkowitz --- newlib/libc/include/ssp/strings.h | 55 +++++++++++++++++++++++++++++++++++++++ newlib/libc/include/strings.h | 6 ++++- 2 files changed, 60 insertions(+), 1 deletion(-) create mode 100644 newlib/libc/include/ssp/strings.h -- 2.15.0 diff --git a/newlib/libc/include/ssp/strings.h b/newlib/libc/include/ssp/strings.h new file mode 100644 index 000000000..13adba175 --- /dev/null +++ b/newlib/libc/include/ssp/strings.h @@ -0,0 +1,55 @@ +/* $NetBSD: strings.h,v 1.3 2008/04/28 20:22:54 martin Exp $ */ + +/*- + * Copyright (c) 2007 The NetBSD Foundation, Inc. + * All rights reserved. + * + * This code is derived from software contributed to The NetBSD Foundation + * by Christos Zoulas. + * + * Redistribution and use in source and binary forms, with or without + * modification, are permitted provided that the following conditions + * are met: + * 1. Redistributions of source code must retain the above copyright + * notice, this list of conditions and the following disclaimer. + * 2. Redistributions in binary form must reproduce the above copyright + * notice, this list of conditions and the following disclaimer in the + * documentation and/or other materials provided with the distribution. + * + * THIS SOFTWARE IS PROVIDED BY THE NETBSD FOUNDATION, INC. AND CONTRIBUTORS + * ``AS IS'' AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED + * TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR + * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE FOUNDATION OR CONTRIBUTORS + * BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR + * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF + * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS + * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN + * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) + * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE + * POSSIBILITY OF SUCH DAMAGE. + */ +#ifndef _SSP_STRINGS_H_ +#define _SSP_STRINGS_H_ + +#include + +#if __SSP_FORTIFY_LEVEL > 0 + +#if __BSD_VISIBLE || __POSIX_VISIBLE <= 200112 +#define bcopy(src, dst, len) \ + ((__ssp_bos0(dst) != (size_t)-1) ? \ + __builtin___memmove_chk(dst, src, len, __ssp_bos0(dst)) : \ + __memmove_ichk(dst, src, len)) +#define bzero(dst, len) \ + ((__ssp_bos0(dst) != (size_t)-1) ? \ + __builtin___memset_chk(dst, 0, len, __ssp_bos0(dst)) : \ + __memset_ichk(dst, 0, len)) +#endif + +#if __BSD_VISIBLE +__ssp_redirect0(void, explicit_bzero, (void *__buf, size_t __len), \ + (__buf, __len)); +#endif + +#endif /* __SSP_FORTIFY_LEVEL > 0 */ +#endif /* _SSP_STRINGS_H_ */ diff --git a/newlib/libc/include/strings.h b/newlib/libc/include/strings.h index 50a304215..38a84a220 100644 --- a/newlib/libc/include/strings.h +++ b/newlib/libc/include/strings.h @@ -47,7 +47,7 @@ int bcmp(const void *, const void *, size_t) __pure; /* LEGACY */ void bcopy(const void *, void *, size_t); /* LEGACY */ void bzero(void *, size_t); /* LEGACY */ #endif -#if __BSD_VISIBLE +#if __BSD_VISIBLE && !__SSP_FORTIFY_LEVEL void explicit_bzero(void *, size_t); #endif #if __MISC_VISIBLE || __POSIX_VISIBLE < 200809 || __XSI_VISIBLE >= 700 @@ -73,4 +73,8 @@ int strncasecmp_l (const char *, const char *, size_t, locale_t); #endif __END_DECLS +#if __SSP_FORTIFY_LEVEL > 0 +#include +#endif + #endif /* _STRINGS_H_ */