From patchwork Mon Mar 25 10:45:22 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sachin Kamat X-Patchwork-Id: 15584 Return-Path: X-Original-To: patchwork@peony.canonical.com Delivered-To: patchwork@peony.canonical.com Received: from fiordland.canonical.com (fiordland.canonical.com [91.189.94.145]) by peony.canonical.com (Postfix) with ESMTP id 9F76F23E64 for ; Mon, 25 Mar 2013 10:56:52 +0000 (UTC) Received: from mail-la0-f44.google.com (mail-la0-f44.google.com [209.85.215.44]) by fiordland.canonical.com (Postfix) with ESMTP id 6C09BA181D1 for ; Mon, 25 Mar 2013 10:56:52 +0000 (UTC) Received: by mail-la0-f44.google.com with SMTP id eb20so11058379lab.3 for ; Mon, 25 Mar 2013 03:56:52 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-received:x-forwarded-to:x-forwarded-for:delivered-to:x-received :received-spf:x-received:from:to:cc:subject:date:message-id:x-mailer :in-reply-to:references:x-gm-message-state; bh=HO98xl05qKGkF5d39lH8VFnhbrMz7NDL38ESZQVniuA=; b=M7FglrMlboJcN/9FPkPXVOMfpJhtfqzVjkTRmM/SaC5QUfNw1DBFRdB/smXKqJ6erW R/8kQ4vibS6kl24mQb0ELBsNDhScOdokyadpecgK0YSAJ1JyyxGTSzEZWG2up3ShyVGg kr2Wk/rw6ETx8m8VrFtEo9OEPR6u5E5rDzsTFI/leiGi94k1rDVAlvLB5yQLgGibX0xX ilVR93c28BSDEKYK+Ra8VgbZNjmGQxh4QYzFM7OjuOjcLLpsULfwVjufEOnuNyxDMsrn 6AxcEYuaFXuUZgJLmhn70/+1wB4OXZQbKjFg4La3KICGFSfO0keqZxg5IP6yQKkfT+YX GLDg== X-Received: by 10.152.105.38 with SMTP id gj6mr5734137lab.25.1364209012005; Mon, 25 Mar 2013 03:56:52 -0700 (PDT) X-Forwarded-To: linaro-patchwork@canonical.com X-Forwarded-For: patch@linaro.org linaro-patchwork@canonical.com Delivered-To: patches@linaro.org Received: by 10.112.147.5 with SMTP id tg5csp41233lbb; Mon, 25 Mar 2013 03:56:51 -0700 (PDT) X-Received: by 10.66.11.164 with SMTP id r4mr17290084pab.219.1364209010078; Mon, 25 Mar 2013 03:56:50 -0700 (PDT) Received: from mail-pb0-f50.google.com (mail-pb0-f50.google.com [209.85.160.50]) by mx.google.com with ESMTPS id yx4si13300418pac.334.2013.03.25.03.56.49 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 25 Mar 2013 03:56:50 -0700 (PDT) Received-SPF: neutral (google.com: 209.85.160.50 is neither permitted nor denied by best guess record for domain of sachin.kamat@linaro.org) client-ip=209.85.160.50; Authentication-Results: mx.google.com; spf=neutral (google.com: 209.85.160.50 is neither permitted nor denied by best guess record for domain of sachin.kamat@linaro.org) smtp.mail=sachin.kamat@linaro.org Received: by mail-pb0-f50.google.com with SMTP id up1so4105048pbc.37 for ; Mon, 25 Mar 2013 03:56:49 -0700 (PDT) X-Received: by 10.68.225.73 with SMTP id ri9mr16962424pbc.70.1364209009390; Mon, 25 Mar 2013 03:56:49 -0700 (PDT) Received: from localhost.localdomain ([115.113.119.130]) by mx.google.com with ESMTPS id y1sm13067861pbg.10.2013.03.25.03.56.46 (version=TLSv1 cipher=RC4-SHA bits=128/128); Mon, 25 Mar 2013 03:56:48 -0700 (PDT) From: Sachin Kamat To: rtc-linux@googlegroups.com Cc: a.zummo@towertech.it, akpm@linux-foundation.org, sachin.kamat@linaro.org, patches@linaro.org, Mark Brown Subject: [PATCH 1/6] drivers/rtc/rtc-wm831x.c: Return error if devm_request_threaded_irq fails Date: Mon, 25 Mar 2013 16:15:22 +0530 Message-Id: <1364208327-14207-2-git-send-email-sachin.kamat@linaro.org> X-Mailer: git-send-email 1.7.4.1 In-Reply-To: <1364208327-14207-1-git-send-email-sachin.kamat@linaro.org> References: <1364208327-14207-1-git-send-email-sachin.kamat@linaro.org> X-Gm-Message-State: ALoCoQl1u9EbZsIQohG76jM5bMpn0wuvJoz1l8EtmOVlJiWcLkFv+eLV3mBJGH2AinW8nDvEDXqH wm831x_rtc_probe() returned 0 even if devm_request_threaded_irq failed. Added 'goto' to return error code upon failure. Signed-off-by: Sachin Kamat Cc: Mark Brown --- drivers/rtc/rtc-wm831x.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/rtc/rtc-wm831x.c b/drivers/rtc/rtc-wm831x.c index 8d65b94..862640e 100644 --- a/drivers/rtc/rtc-wm831x.c +++ b/drivers/rtc/rtc-wm831x.c @@ -450,6 +450,7 @@ static int wm831x_rtc_probe(struct platform_device *pdev) if (ret != 0) { dev_err(&pdev->dev, "Failed to request alarm IRQ %d: %d\n", alm_irq, ret); + goto err; } wm831x_rtc_add_randomness(wm831x);