From patchwork Thu Jun 13 14:30:50 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Julien Grall X-Patchwork-Id: 17911 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-vb0-f71.google.com (mail-vb0-f71.google.com [209.85.212.71]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 4C77925DF1 for ; Thu, 13 Jun 2013 14:31:07 +0000 (UTC) Received: by mail-vb0-f71.google.com with SMTP id f12sf5100265vbg.6 for ; Thu, 13 Jun 2013 07:31:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:x-beenthere:x-forwarded-to:x-forwarded-for :delivered-to:from:to:cc:subject:date:message-id:x-mailer :x-gm-message-state:x-original-sender :x-original-authentication-results:precedence:mailing-list:list-id :x-google-group-id:list-post:list-help:list-archive:list-unsubscribe; bh=Ss6jImx7tZOGobDNObvCaVswVKLrjqSe3Gr7/tjdh+Y=; b=AmzAAkDxCJ8K9Y/V9RnHxvZglEShO9jTpqUBr5joSM9l2EU028OQfzoNKI5VJMu+88 ds8VIleiyazzNIsvCRoCXX28kYj0mf2uy6nsacaYMgAZ0HT0b5hnRIwjGNA5WYIuSsnI gwHRQphLrsa2QeSFCt90xghf1Zx8hRzMat/mkrV/xOPpU0e1Qls1O3u7FBk4ipfwDry/ tclOlFjda+q+U8Ax57KhHNzuJoMbXjXfeGrpUnlh/+lro9ydDMLCYME3v6lKgDD2wWat 7p/tPBQhqbTJxEmtbX4NqUHWX8vPPyRL/GEBn3Poe98JR67zJqbqdj+dQm5Xtdvn0PU+ OokA== X-Received: by 10.236.112.33 with SMTP id x21mr423415yhg.57.1371133866239; Thu, 13 Jun 2013 07:31:06 -0700 (PDT) MIME-Version: 1.0 X-BeenThere: patchwork-forward@linaro.org Received: by 10.49.53.102 with SMTP id a6ls3971268qep.59.gmail; Thu, 13 Jun 2013 07:31:06 -0700 (PDT) X-Received: by 10.52.19.67 with SMTP id c3mr393931vde.19.1371133866025; Thu, 13 Jun 2013 07:31:06 -0700 (PDT) Received: from mail-vc0-f178.google.com (mail-vc0-f178.google.com [209.85.220.178]) by mx.google.com with ESMTPS id nx5si10521354vcb.35.2013.06.13.07.31.05 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 13 Jun 2013 07:31:05 -0700 (PDT) Received-SPF: neutral (google.com: 209.85.220.178 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) client-ip=209.85.220.178; Received: by mail-vc0-f178.google.com with SMTP id m17so3080776vca.37 for ; Thu, 13 Jun 2013 07:31:05 -0700 (PDT) X-Received: by 10.220.144.67 with SMTP id y3mr454288vcu.17.1371133865700; Thu, 13 Jun 2013 07:31:05 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patches@linaro.org Received: by 10.58.191.99 with SMTP id gx3csp24641vec; Thu, 13 Jun 2013 07:31:05 -0700 (PDT) X-Received: by 10.194.238.199 with SMTP id vm7mr742885wjc.37.1371133864559; Thu, 13 Jun 2013 07:31:04 -0700 (PDT) Received: from mail-wg0-x22e.google.com (mail-wg0-x22e.google.com [2a00:1450:400c:c00::22e]) by mx.google.com with ESMTPS id r3si6664921wjw.75.2013.06.13.07.31.04 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 13 Jun 2013 07:31:04 -0700 (PDT) Received-SPF: neutral (google.com: 2a00:1450:400c:c00::22e is neither permitted nor denied by best guess record for domain of julien.grall@linaro.org) client-ip=2a00:1450:400c:c00::22e; Received: by mail-wg0-f46.google.com with SMTP id c11so4543952wgh.1 for ; Thu, 13 Jun 2013 07:31:04 -0700 (PDT) X-Received: by 10.194.238.42 with SMTP id vh10mr783380wjc.28.1371133863891; Thu, 13 Jun 2013 07:31:03 -0700 (PDT) Received: from belegaer.uk.xensource.com (firewall.ctxuk.citrix.com. [46.33.159.2]) by mx.google.com with ESMTPSA id r9sm10543472wik.1.2013.06.13.07.31.02 for (version=TLSv1.2 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 13 Jun 2013 07:31:03 -0700 (PDT) From: Julien Grall To: xen-devel@lists.xen.org Cc: stefano.stabellini@citrix.com, ian.campbell@citrix.com, patches@linaro.org, sander.bogaert@elis.ugent.be, Julien Grall Subject: [PATCH] xen/arm: Use the right GICD register to initialize IRQs routing Date: Thu, 13 Jun 2013 15:30:50 +0100 Message-Id: <1371133850-13716-1-git-send-email-julien.grall@linaro.org> X-Mailer: git-send-email 1.7.10.4 X-Gm-Message-State: ALoCoQmitg0zzdXN5TDtydBrtRHzo12Bv0K5KyYX/rOHZ6CTShp8bm/uZS4EQXyH4H+bEUs8vPBC X-Original-Sender: julien.grall@linaro.org X-Original-Authentication-Results: mx.google.com; spf=neutral (google.com: 209.85.220.178 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Precedence: list Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org List-ID: X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , Currently IRQs routing is initialized to the wrong register and overwrites interrupt configuration register (ICFGRn). Furthermore, the register describes target CPUs for 4 interrupts, update the cpumask variable to also redirect the last interrupts to the current cpu. Reported-by: Sander Bogaert Signed-off-by: Julien Grall --- xen/arch/arm/gic.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/xen/arch/arm/gic.c b/xen/arch/arm/gic.c index a7a70b8..181e12a 100644 --- a/xen/arch/arm/gic.c +++ b/xen/arch/arm/gic.c @@ -274,6 +274,7 @@ static void __init gic_dist_init(void) cpumask |= cpumask << 8; cpumask |= cpumask << 16; + cpumask |= cpumask << 24; /* Disable the distributor */ GICD[GICD_CTLR] = 0; @@ -292,7 +293,7 @@ static void __init gic_dist_init(void) /* Route all global IRQs to this CPU */ for ( i = 32; i < gic.lines; i += 4 ) - GICD[GICD_ICFGR + i / 4] = cpumask; + GICD[GICD_ITARGETSR + i / 4] = cpumask; /* Default priority for global interrupts */ for ( i = 32; i < gic.lines; i += 4 )