From patchwork Tue Sep 2 22:56:38 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Laszlo Ersek X-Patchwork-Id: 36534 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-qg0-f72.google.com (mail-qg0-f72.google.com [209.85.192.72]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 1C94D20C87 for ; Tue, 2 Sep 2014 22:57:10 +0000 (UTC) Received: by mail-qg0-f72.google.com with SMTP id j5sf23610459qga.7 for ; Tue, 02 Sep 2014 15:57:09 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:delivered-to:from:to:date:message-id:in-reply-to :references:subject:precedence:reply-to:list-id:list-unsubscribe :list-archive:list-post:list-help:list-subscribe:mime-version :errors-to:x-original-sender:x-original-authentication-results :mailing-list:content-type:content-transfer-encoding; bh=ExkRiZ/5u6/IDZgve1J8n0xjflayWb5yvGVOUi/vPvM=; b=c7YoFcGbFP8Fvd8Vlgt+/VhK9GCz5GaitYV29879FL6mVqoV8tBb0Ox3+rnT6jeUn3 Fq/v7Iy6vywYxzT6wdTM0mhScEemcdZ1sHAEra4Zmm2+u4ymmEIBwnKR8eEiBByG+1+r hjGKBKnDcY311d93xNra3nVwL2KfYwVrAy8z7MtaOWsWFcHArNpKjKx5EuumSQgrD2GL AQui8dYvTHP3qrAM+9m4jjfJjWRFIYyJwJvdPUhH9L3b/uZJXKTlOXEAOF3W/OrgX3Cj qPMnLL/6Hfw4JzBwZgtVh9lXIeJcVj/IqbKrNazxFbF/mkQ1IZyJvwIm48qUYmR8xaLs k7SQ== X-Gm-Message-State: ALoCoQlPitgkgxcRbwMhbqeI7OpWoWpjqipUyhIbHweW9ME9mHJUpY/DBpKLbeH3/gJk89p9GovC X-Received: by 10.52.190.163 with SMTP id gr3mr20992704vdc.3.1409698629892; Tue, 02 Sep 2014 15:57:09 -0700 (PDT) X-BeenThere: patchwork-forward@linaro.org Received: by 10.140.94.87 with SMTP id f81ls2732503qge.65.gmail; Tue, 02 Sep 2014 15:57:09 -0700 (PDT) X-Received: by 10.220.251.200 with SMTP id mt8mr32248698vcb.24.1409698629776; Tue, 02 Sep 2014 15:57:09 -0700 (PDT) Received: from mail-vc0-f171.google.com (mail-vc0-f171.google.com [209.85.220.171]) by mx.google.com with ESMTPS id cd8si2924780vcb.83.2014.09.02.15.57.09 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 02 Sep 2014 15:57:09 -0700 (PDT) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.220.171 as permitted sender) client-ip=209.85.220.171; Received: by mail-vc0-f171.google.com with SMTP id id10so7903589vcb.16 for ; Tue, 02 Sep 2014 15:57:09 -0700 (PDT) X-Received: by 10.220.86.72 with SMTP id r8mr2817601vcl.36.1409698629693; Tue, 02 Sep 2014 15:57:09 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.221.45.67 with SMTP id uj3csp596465vcb; Tue, 2 Sep 2014 15:57:09 -0700 (PDT) X-Received: by 10.42.227.10 with SMTP id iy10mr34146527icb.3.1409698629181; Tue, 02 Sep 2014 15:57:09 -0700 (PDT) Received: from lists.sourceforge.net (lists.sourceforge.net. [216.34.181.88]) by mx.google.com with ESMTPS id am5si185911igc.20.2014.09.02.15.57.08 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Tue, 02 Sep 2014 15:57:09 -0700 (PDT) Received-SPF: pass (google.com: domain of edk2-devel-bounces@lists.sourceforge.net designates 216.34.181.88 as permitted sender) client-ip=216.34.181.88; Received: from localhost ([127.0.0.1] helo=sfs-ml-3.v29.ch3.sourceforge.com) by sfs-ml-3.v29.ch3.sourceforge.com with esmtp (Exim 4.76) (envelope-from ) id 1XOx0X-0000J1-A9; Tue, 02 Sep 2014 22:57:01 +0000 Received: from sog-mx-1.v43.ch3.sourceforge.com ([172.29.43.191] helo=mx.sourceforge.net) by sfs-ml-3.v29.ch3.sourceforge.com with esmtp (Exim 4.76) (envelope-from ) id 1XOx0V-0000IN-2A for edk2-devel@lists.sourceforge.net; Tue, 02 Sep 2014 22:56:59 +0000 Received-SPF: pass (sog-mx-1.v43.ch3.sourceforge.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=lersek@redhat.com; helo=mx1.redhat.com; Received: from mx1.redhat.com ([209.132.183.28]) by sog-mx-1.v43.ch3.sourceforge.com with esmtps (TLSv1:AES256-SHA:256) (Exim 4.76) id 1XOx0U-0008OV-8b for edk2-devel@lists.sourceforge.net; Tue, 02 Sep 2014 22:56:59 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s82MuqZM016344 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Tue, 2 Sep 2014 18:56:52 -0400 Received: from lacos-laptop-7.usersys.redhat.com (ovpn-116-55.ams2.redhat.com [10.36.116.55]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s82MueDb005138 for ; Tue, 2 Sep 2014 18:56:51 -0400 From: Laszlo Ersek To: edk2-devel@lists.sourceforge.net Date: Wed, 3 Sep 2014 00:56:38 +0200 Message-Id: <1409698598-9766-12-git-send-email-lersek@redhat.com> In-Reply-To: <1409698598-9766-1-git-send-email-lersek@redhat.com> References: <54063964.8060402@redhat.com> <1409698598-9766-1-git-send-email-lersek@redhat.com> X-Scanned-By: MIMEDefang 2.68 on 10.5.11.24 X-Spam-Score: -3.2 (---) X-Spam-Report: Spam Filtering performed by mx.sourceforge.net. See http://spamassassin.org/tag/ for more details. -1.5 SPF_CHECK_PASS SPF reports sender host as permitted sender for sender-domain -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -0.0 SPF_PASS SPF: sender matches SPF record -1.7 RP_MATCHES_RCVD Envelope sender domain matches handover relay domain X-Headers-End: 1XOx0U-0008OV-8b Subject: [edk2] [PATCH 12/12] OvmfPkg: VirtioMmioDeviceLib: add constructor X-BeenThere: edk2-devel@lists.sourceforge.net X-Mailman-Version: 2.1.9 Precedence: list Reply-To: edk2-devel@lists.sourceforge.net List-Id: List-Unsubscribe: , List-Archive: List-Post: , List-Help: , List-Subscribe: , MIME-Version: 1.0 Errors-To: edk2-devel-bounces@lists.sourceforge.net X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: lersek@redhat.com X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.220.171 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 Calls to constructors of interdependent library instances are generated in the correct order only if all library instances in question have constructors. If some have no constructors, then the rest may see their constructors called out of order. Cycle detection also only works when all library instances have constructors. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Laszlo Ersek --- OvmfPkg/Library/VirtioMmioDeviceLib/VirtioMmioDeviceLib.inf | 2 ++ OvmfPkg/Library/VirtioMmioDeviceLib/VirtioMmioDevice.c | 11 +++++++++++ 2 files changed, 13 insertions(+) diff --git a/OvmfPkg/Library/VirtioMmioDeviceLib/VirtioMmioDeviceLib.inf b/OvmfPkg/Library/VirtioMmioDeviceLib/VirtioMmioDeviceLib.inf index 2e266a9..600ba63 100644 --- a/OvmfPkg/Library/VirtioMmioDeviceLib/VirtioMmioDeviceLib.inf +++ b/OvmfPkg/Library/VirtioMmioDeviceLib/VirtioMmioDeviceLib.inf @@ -22,6 +22,8 @@ VERSION_STRING = 1.0 LIBRARY_CLASS = VirtioMmioDeviceLib + CONSTRUCTOR = VirtioMmioDeviceLibConstructor + [Sources] VirtioMmioDevice.c VirtioMmioDeviceFunctions.c diff --git a/OvmfPkg/Library/VirtioMmioDeviceLib/VirtioMmioDevice.c b/OvmfPkg/Library/VirtioMmioDeviceLib/VirtioMmioDevice.c index 4af9dd0..f36ba81 100644 --- a/OvmfPkg/Library/VirtioMmioDeviceLib/VirtioMmioDevice.c +++ b/OvmfPkg/Library/VirtioMmioDeviceLib/VirtioMmioDevice.c @@ -222,3 +222,14 @@ VirtioMmioUninstallDevice ( return EFI_SUCCESS; } + + +EFI_STATUS +EFIAPI +VirtioMmioDeviceLibConstructor ( + IN EFI_HANDLE ImageHandle, + IN EFI_SYSTEM_TABLE *SystemTable + ) +{ + return EFI_SUCCESS; +}