From patchwork Wed Oct 22 13:21:54 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Laszlo Ersek X-Patchwork-Id: 39290 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-ee0-f71.google.com (mail-ee0-f71.google.com [74.125.83.71]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 5CC02202DB for ; Wed, 22 Oct 2014 13:22:31 +0000 (UTC) Received: by mail-ee0-f71.google.com with SMTP id e51sf1644714eek.6 for ; Wed, 22 Oct 2014 06:22:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:delivered-to:from:to:date:message-id:in-reply-to :references:subject:precedence:reply-to:list-id:list-unsubscribe :list-archive:list-post:list-help:list-subscribe:mime-version :errors-to:x-original-sender:x-original-authentication-results :mailing-list:content-type:content-transfer-encoding; bh=HPWfT1vIRefm1lGij3IWAoNHzMWPd+ermfRZhJ9wLjI=; b=dV5+zpOh4FJ+AH1n13HGNSe8Ynrfsm9ZTz3fXGXA/MrylDqRKKFB0PdpYUVSmRauji wzfyCP25fEDTM5MlS7Gr+UUp8mcEn6Ja0Iy7RoyAYPQhprydD4GX7e+Y0Fpb4hxv2yCB fljHEw0LHE6fOBWDmoLIQ7YHOaA6rAxNfAoFcCdqtZZn5snDZTbe7eV3A8YK3hoHk+KI DChN/J2rkKvNWewtiTWdjROTBM0QofqUkZvefT63GHfJ2mVxhZ0rMFqSd26MhAy+u0cc 7PrJp6GCQTh0C731c8tfa08KuCHBisV2WNWOuOwmPOCjlQk9c53giI8kbx6n8tAia/NA Pznw== X-Gm-Message-State: ALoCoQnEcVqKE/BXjGyNJBgwLarBNxWQ9UjvDbAQ0wwU7OyguT+cuX4ViZPGpXtPBrdSXNwqNsxt X-Received: by 10.180.105.74 with SMTP id gk10mr5698459wib.0.1413984150540; Wed, 22 Oct 2014 06:22:30 -0700 (PDT) X-BeenThere: patchwork-forward@linaro.org Received: by 10.152.2.67 with SMTP id 3ls192477las.63.gmail; Wed, 22 Oct 2014 06:22:30 -0700 (PDT) X-Received: by 10.112.89.8 with SMTP id bk8mr42213900lbb.30.1413984150346; Wed, 22 Oct 2014 06:22:30 -0700 (PDT) Received: from mail-la0-f54.google.com (mail-la0-f54.google.com. [209.85.215.54]) by mx.google.com with ESMTPS id zm10si23272462lbb.125.2014.10.22.06.22.30 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 22 Oct 2014 06:22:30 -0700 (PDT) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.215.54 as permitted sender) client-ip=209.85.215.54; Received: by mail-la0-f54.google.com with SMTP id gm9so2871610lab.41 for ; Wed, 22 Oct 2014 06:22:30 -0700 (PDT) X-Received: by 10.152.29.8 with SMTP id f8mr41738287lah.56.1413984150217; Wed, 22 Oct 2014 06:22:30 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.112.84.229 with SMTP id c5csp69731lbz; Wed, 22 Oct 2014 06:22:29 -0700 (PDT) X-Received: by 10.52.75.200 with SMTP id e8mr6960813vdw.32.1413984148817; Wed, 22 Oct 2014 06:22:28 -0700 (PDT) Received: from lists.sourceforge.net (lists.sourceforge.net. [216.34.181.88]) by mx.google.com with ESMTPS id ev6si10183110vcb.69.2014.10.22.06.22.28 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Wed, 22 Oct 2014 06:22:28 -0700 (PDT) Received-SPF: pass (google.com: domain of edk2-devel-bounces@lists.sourceforge.net designates 216.34.181.88 as permitted sender) client-ip=216.34.181.88; Received: from localhost ([127.0.0.1] helo=sfs-ml-2.v29.ch3.sourceforge.com) by sfs-ml-2.v29.ch3.sourceforge.com with esmtp (Exim 4.76) (envelope-from ) id 1Xgvrp-0000v1-94; Wed, 22 Oct 2014 13:22:21 +0000 Received: from sog-mx-2.v43.ch3.sourceforge.com ([172.29.43.192] helo=mx.sourceforge.net) by sfs-ml-2.v29.ch3.sourceforge.com with esmtp (Exim 4.76) (envelope-from ) id 1Xgvrm-0000ud-Qf for edk2-devel@lists.sourceforge.net; Wed, 22 Oct 2014 13:22:18 +0000 Received-SPF: pass (sog-mx-2.v43.ch3.sourceforge.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=lersek@redhat.com; helo=mx1.redhat.com; Received: from mx1.redhat.com ([209.132.183.28]) by sog-mx-2.v43.ch3.sourceforge.com with esmtps (TLSv1:AES256-SHA:256) (Exim 4.76) id 1Xgvrl-00051a-W6 for edk2-devel@lists.sourceforge.net; Wed, 22 Oct 2014 13:22:18 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s9MDMBgB032759 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Wed, 22 Oct 2014 09:22:12 -0400 Received: from lacos-laptop-7.usersys.redhat.com (ovpn-116-81.ams2.redhat.com [10.36.116.81]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s9MDM2M6016088 for ; Wed, 22 Oct 2014 09:22:10 -0400 From: Laszlo Ersek To: edk2-devel@lists.sourceforge.net Date: Wed, 22 Oct 2014 15:21:54 +0200 Message-Id: <1413984117-20000-5-git-send-email-lersek@redhat.com> In-Reply-To: <1413984117-20000-1-git-send-email-lersek@redhat.com> References: <1413984117-20000-1-git-send-email-lersek@redhat.com> X-Scanned-By: MIMEDefang 2.68 on 10.5.11.22 X-Spam-Score: -2.9 (--) X-Spam-Report: Spam Filtering performed by mx.sourceforge.net. See http://spamassassin.org/tag/ for more details. -1.5 SPF_CHECK_PASS SPF reports sender host as permitted sender for sender-domain -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -0.0 SPF_PASS SPF: sender matches SPF record -1.4 RP_MATCHES_RCVD Envelope sender domain matches handover relay domain X-Headers-End: 1Xgvrl-00051a-W6 Subject: [edk2] [PATCH 4/7] OvmfPkg: BDS: optimize second argument in PlatformBdsEnterFrontPage() call X-BeenThere: edk2-devel@lists.sourceforge.net X-Mailman-Version: 2.1.9 Precedence: list Reply-To: edk2-devel@lists.sourceforge.net List-Id: List-Unsubscribe: , List-Archive: List-Post: , List-Help: , List-Subscribe: , MIME-Version: 1.0 Errors-To: edk2-devel-bounces@lists.sourceforge.net X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: lersek@redhat.com X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.215.54 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 The second parameter of said function is "ConnectAllHappened", and if set to TRUE, the function sets "gConnectAllHappened" to TRUE. This global variable in turn controls whether Intel BDS code *itself* calls BdsLibConnectAllDriversToAllControllers() in various places -- if the indicator is TRUE, then the "connect all" is assumed to have been performed, and Intel BDS doesn't do it itself. OVMF should pass TRUE as "ConnectAllHappened", because a few lines before our call to PlatformBdsEnterFrontPage(), we already connect everything with BdsLibConnectAll(), which includes the effects of BdsLibConnectAllDriversToAllControllers(): PlatformBdsPolicyBehavior() [OvmfPkg/Library/PlatformBdsLib/BdsPlatform.c] BdsLibConnectAll() [IntelFrameworkModulePkg/Library/GenericBdsLib/BdsConnect.c] BdsLibConnectAllDriversToAllControllers() PlatformBdsEnterFrontPage() [IntelFrameworkModulePkg/Universal/BdsDxe/FrontPage.c] Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Laszlo Ersek --- OvmfPkg/Library/PlatformBdsLib/BdsPlatform.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/OvmfPkg/Library/PlatformBdsLib/BdsPlatform.c b/OvmfPkg/Library/PlatformBdsLib/BdsPlatform.c index f2ece66..9fa48c9 100644 --- a/OvmfPkg/Library/PlatformBdsLib/BdsPlatform.c +++ b/OvmfPkg/Library/PlatformBdsLib/BdsPlatform.c @@ -1193,7 +1193,7 @@ Returns: // // Enter Setup if user input // - PlatformBdsEnterFrontPage (Timeout, FALSE); + PlatformBdsEnterFrontPage (Timeout, TRUE); } }