From patchwork Wed Jan 28 06:45:48 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: John Stultz X-Patchwork-Id: 43876 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-ee0-f71.google.com (mail-ee0-f71.google.com [74.125.83.71]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 902A72409D for ; Wed, 28 Jan 2015 06:46:02 +0000 (UTC) Received: by mail-ee0-f71.google.com with SMTP id d49sf9895127eek.2 for ; Tue, 27 Jan 2015 22:46:01 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:delivered-to:from:to:cc:subject :date:message-id:x-original-sender:x-original-authentication-results :precedence:mailing-list:list-id:list-post:list-help:list-archive :list-unsubscribe; bh=o325KSLm2nQrI+URK2ZCoVevJqxwSINtauePojWUEf8=; b=Ql2RcHiXictehZw36d9By+BRrhprnKjq+9crzPtkSGwsD6QAoGiHKUz4Jr+4Uyd2Bn 05764O0J3unGhW7MasxwBaL1shbSEXHmY2ANbOSdr7GIJUGeFXNfLYn89z/jD8JsUoWn bo4v+Xa8d0ZSiV9imBsFqE7IQRhi5Z4p69Nz8f9S5nElryrtxLFF+Cv+uoyIvKzEPYz6 wUODH2kvejequMC1GNCVZ1w+FX+eao69QCMOWFM3Qwk299BXVCkYjYqok58wZtH2Dr4T mAVP2jXK0NoHAN4kdCSOGOTGbfSTRgw4iuUMJ5NjuDslWPHhkPCIO5PxL5plVJmqxInW wJbg== X-Gm-Message-State: ALoCoQk0KTg0VatHZlnRjOQ9TqFylw3W1GiKJE483b/oeGdOFadtna+8uzrPIE3IlUkXN8KXxdp4 X-Received: by 10.152.3.234 with SMTP id f10mr750143laf.1.1422427561724; Tue, 27 Jan 2015 22:46:01 -0800 (PST) MIME-Version: 1.0 X-BeenThere: patchwork-forward@linaro.org Received: by 10.153.7.132 with SMTP id dc4ls104719lad.97.gmail; Tue, 27 Jan 2015 22:46:01 -0800 (PST) X-Received: by 10.152.2.226 with SMTP id 2mr5825278lax.67.1422427561585; Tue, 27 Jan 2015 22:46:01 -0800 (PST) Received: from mail-lb0-f176.google.com (mail-lb0-f176.google.com. [209.85.217.176]) by mx.google.com with ESMTPS id ec7si3438678lbc.32.2015.01.27.22.46.01 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 27 Jan 2015 22:46:01 -0800 (PST) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.217.176 as permitted sender) client-ip=209.85.217.176; Received: by mail-lb0-f176.google.com with SMTP id z12so16967814lbi.7 for ; Tue, 27 Jan 2015 22:46:01 -0800 (PST) X-Received: by 10.112.41.234 with SMTP id i10mr6080967lbl.25.1422427561079; Tue, 27 Jan 2015 22:46:01 -0800 (PST) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patches@linaro.org Received: by 10.112.35.133 with SMTP id h5csp1338014lbj; Tue, 27 Jan 2015 22:46:00 -0800 (PST) X-Received: by 10.70.34.65 with SMTP id x1mr3205554pdi.120.1422427559318; Tue, 27 Jan 2015 22:45:59 -0800 (PST) Received: from mail-pd0-f169.google.com (mail-pd0-f169.google.com. [209.85.192.169]) by mx.google.com with ESMTPS id t3si4463774pdn.198.2015.01.27.22.45.58 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 27 Jan 2015 22:45:59 -0800 (PST) Received-SPF: pass (google.com: domain of john.stultz@linaro.org designates 209.85.192.169 as permitted sender) client-ip=209.85.192.169; Received: by mail-pd0-f169.google.com with SMTP id g10so23839589pdj.0 for ; Tue, 27 Jan 2015 22:45:58 -0800 (PST) X-Received: by 10.68.216.161 with SMTP id or1mr3203896pbc.120.1422427558393; Tue, 27 Jan 2015 22:45:58 -0800 (PST) Received: from localhost.localdomain (c-67-170-153-23.hsd1.or.comcast.net. [67.170.153.23]) by mx.google.com with ESMTPSA id w3sm3567899pbs.11.2015.01.27.22.45.57 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 27 Jan 2015 22:45:57 -0800 (PST) From: John Stultz To: projectara-software-dev@linaro.org Cc: John Stultz , "Mark A. Greer" Subject: [PATCH] greybus-spec: I2S: Try to add some minor clarifications and notes Date: Tue, 27 Jan 2015 22:45:48 -0800 Message-Id: <1422427548-15140-1-git-send-email-john.stultz@linaro.org> X-Mailer: git-send-email 1.9.1 X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: john.stultz@linaro.org X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.217.176 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Precedence: list Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org List-ID: X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , Add some minor clarifications to try to improve the intro, and add a few notes where I think further improvements are needed. Cc: Mark A. Greer Signed-off-by: John Stultz --- source/bridged_phy.rst | 36 ++++++++++++++++++++++++++++++------ 1 file changed, 30 insertions(+), 6 deletions(-) diff --git a/source/bridged_phy.rst b/source/bridged_phy.rst index 91412cc..608c55b 100644 --- a/source/bridged_phy.rst +++ b/source/bridged_phy.rst @@ -1447,12 +1447,14 @@ the Module supports other Greybus Protocols. document. This does not preclude the use of other data formats. -An I2S Module shall contain one or more *I2S Bundles*. Each I2S Bundle -shall contain one *I2S Management CPort*, and may contain zero or -more *I2S Transmitter CPorts* and zero or more *I2S Receiver CPorts*. -There shall be at least one I2S Transmitter or Receiver CPort in each -I2S Bundle. An I2S Bundle may have no physical low-level I2S or -similar hardware associated with it. +An I2S Module shall contain one or more *I2S Bundles*. A bundle is a +collection of CPorts on a module. Each I2S Bundle shall contain one *I2S +Management CPort*, and may contain zero or more *I2S Transmitter CPorts* +and zero or more *I2S Receiver CPorts*, which are controlled and +configured by the I2S Management CPort in that bundle. There shall be +at least one I2S Transmitter or Receiver CPort in each I2S Bundle. An +I2S Bundle may have no physical low-level I2S or similar hardware +associated with it. I2S Management CPorts, I2S Transmitter CPorts, and I2S Receiver CPorts have unique CPort Protocol values in the `protocol` field of the CPort @@ -1476,6 +1478,15 @@ from the I2S Management CPort used by the AP Module to manage that I2S Bundle. The AP Module shall treat the I2S Bundle in the AP Module no differently than an I2S Bundle in any other I2S Module. +.. Personally I find the last few statements in the + above quite complicated, and difficult to understand. + If an AP module has a transmitter bundle, which includes + a management cport, why would it need an additional + management port for that bundle? Is the idea that + the management cport would be the other end of a control + connection (ie, connecting to localhost) to configure + the AP bridge transmission settings? -jstultz + Separate Management and Data Protocols ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ @@ -1611,6 +1622,14 @@ device. The currently supported Low-level Interface Protocols are: Pulse Code Modulation (PCM), Inter-IC Sound (I2S), and Left-Right Stereo (LR Stereo). They are described in more detail below. +.. Personally I think we should be a bit more opinionated + in the spec and advise support for one low-level protocol. + We may also support other protocols for compatability,but + there should probably be some mention here that the + PCM or I2S protocol is the preferred/advised protocol + to be used. Or even we might only describe one but reserve + the bits needed to have the others work. -jstultz + Sometimes Low-level Interface Protocols also specify the format of the audio data (e.g., I2S). For this discussion, the audio data format is irrelevant and only the Low-level Interface Protocol is relevant. @@ -1991,6 +2010,11 @@ the :ref:`i2s-management-protocol`. * Activate the I2S Receiver CPort in the I2S Receiver Bundle. * Activate the I2S Transmitter CPort in the I2S Transmitter Bundle. +.. It might be good to explicitly mention the control + mechanism to create unipro connections between I2S + transmitter and reciever cports. This seems to gloss + over it a bit -jstultz + The I2S Transmitter Bundle may now stream audio data to the I2S Receiver Bundle using :ref:`i2s-send-data-op`\s.