From patchwork Mon Jun 24 07:44:18 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Dong, Eric" X-Patchwork-Id: 18053 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-vb0-f72.google.com (mail-vb0-f72.google.com [209.85.212.72]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 0E53925CFE for ; Mon, 24 Jun 2013 07:44:38 +0000 (UTC) Received: by mail-vb0-f72.google.com with SMTP id p12sf14580070vbe.3 for ; Mon, 24 Jun 2013 00:44:37 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-beenthere:x-forwarded-to:x-forwarded-for:delivered-to:x-extloop1 :x-ironport-av:from:to:subject:thread-topic:thread-index:date :message-id:references:in-reply-to:accept-language:x-ms-has-attach :x-ms-tnef-correlator:x-originating-ip:mime-version :x-gm-message-state:x-original-sender :x-original-authentication-results:precedence:mailing-list:list-id :x-google-group-id:list-post:list-help:list-archive:list-unsubscribe :content-language:content-type:content-transfer-encoding; bh=Gu0z5R+GcF8N4x1Bztcvnv6xP48nNFezKhfZLsrbvLE=; b=eGBl2GbMm047Hb3p5B7g4nSscCJbI74TchVTETqJUUFwskfEm7BkJlAnNUKDViFT8b F1zgmrY6ak2b1VY+sysVdCabJ0mmSNsKr+T5H52MvWHTMd+YheLZEL9bFaObrSBY5Qg/ m2fJiEHQgRRe6yvbr4G88mOk3LB9tfH/MVhEd6HHmfgKQ8E0vScjRCvR2xIel26iSIsP IzyUWAb4BcJQejId349oQe2mWXwW8Vef5Ht6i7WddSAow+wIm4sCinNVDHW39SkHU+0z rdktXRd+UQ5nqktJKn+w6bHc1oJkbSzC2tFxd9mxFHbFtuwjZSNov6NOWQVndc4rGPi2 l+tw== X-Received: by 10.224.205.138 with SMTP id fq10mr24992442qab.1.1372059877400; Mon, 24 Jun 2013 00:44:37 -0700 (PDT) X-BeenThere: patchwork-forward@linaro.org Received: by 10.49.118.227 with SMTP id kp3ls1865383qeb.19.gmail; Mon, 24 Jun 2013 00:44:37 -0700 (PDT) X-Received: by 10.58.233.47 with SMTP id tt15mr10777258vec.56.1372059877237; Mon, 24 Jun 2013 00:44:37 -0700 (PDT) Received: from mail-vb0-x22e.google.com (mail-vb0-x22e.google.com [2607:f8b0:400c:c02::22e]) by mx.google.com with ESMTPS id o7si4601203vet.93.2013.06.24.00.44.37 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 24 Jun 2013 00:44:37 -0700 (PDT) Received-SPF: neutral (google.com: 2607:f8b0:400c:c02::22e is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) client-ip=2607:f8b0:400c:c02::22e; Received: by mail-vb0-f46.google.com with SMTP id 10so7907313vbe.33 for ; Mon, 24 Jun 2013 00:44:37 -0700 (PDT) X-Received: by 10.58.119.233 with SMTP id kx9mr2203496veb.3.1372059877140; Mon, 24 Jun 2013 00:44:37 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patches@linaro.org Received: by 10.58.165.8 with SMTP id yu8csp17488veb; Mon, 24 Jun 2013 00:44:36 -0700 (PDT) X-Received: by 10.68.221.69 with SMTP id qc5mr5061499pbc.60.1372059876094; Mon, 24 Jun 2013 00:44:36 -0700 (PDT) Received: from mga14.intel.com (mga14.intel.com. [143.182.124.37]) by mx.google.com with ESMTP id zg2si8279438pbb.345.2013.06.24.00.44.34 for ; Mon, 24 Jun 2013 00:44:36 -0700 (PDT) Received-SPF: pass (google.com: domain of eric.dong@intel.com designates 143.182.124.37 as permitted sender) client-ip=143.182.124.37; Received: from azsmga002.ch.intel.com ([10.2.17.35]) by azsmga102.ch.intel.com with ESMTP; 24 Jun 2013 00:44:22 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.87,927,1363158000"; d="scan'208";a="259219913" Received: from fmsmsx106.amr.corp.intel.com ([10.19.9.37]) by AZSMGA002.ch.intel.com with ESMTP; 24 Jun 2013 00:44:21 -0700 Received: from fmsmsx151.amr.corp.intel.com (10.19.17.220) by FMSMSX106.amr.corp.intel.com (10.19.9.37) with Microsoft SMTP Server (TLS) id 14.3.123.3; Mon, 24 Jun 2013 00:44:21 -0700 Received: from shsmsx104.ccr.corp.intel.com (10.239.110.15) by FMSMSX151.amr.corp.intel.com (10.19.17.220) with Microsoft SMTP Server (TLS) id 14.3.123.3; Mon, 24 Jun 2013 00:44:20 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.42]) by SHSMSX104.ccr.corp.intel.com ([169.254.5.33]) with mapi id 14.03.0123.003; Mon, 24 Jun 2013 15:44:19 +0800 From: "Dong, Eric" To: Ryan Harkin , "edk2-devel@lists.sourceforge.net" , "patches@linaro.org" , "boot-architecture@lists.linaro.org" Subject: RE: [edk2] [PATCH] MdeModulePkg: fix compilation errors Thread-Topic: [edk2] [PATCH] MdeModulePkg: fix compilation errors Thread-Index: AQHOblc12PtUBU0vq0S1EL6BW9BOQ5lEf4iw Date: Mon, 24 Jun 2013 07:44:18 +0000 Message-ID: References: <1371800898-15026-1-git-send-email-ryan.harkin@linaro.org> In-Reply-To: <1371800898-15026-1-git-send-email-ryan.harkin@linaro.org> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 X-Gm-Message-State: ALoCoQnae0f1up6ZIiqmRTuwr9GqT8ekTo+ykHtlWPBabl9lyzyPG1vAglXQpKkqzjGM4BLrMPMS X-Original-Sender: eric.dong@intel.com X-Original-Authentication-Results: mx.google.com; spf=neutral (google.com: 2607:f8b0:400c:c02::22e is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Precedence: list Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org List-ID: X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , Content-Language: en-US This change is not correct, the "Buffer" variable is not defined. Thanks, Eric -----Original Message----- From: Ryan Harkin [mailto:ryan.harkin@linaro.org] Sent: Friday, June 21, 2013 3:48 PM To: ryan.harkin@linaro.org; edk2-devel@lists.sourceforge.net; patches@linaro.org; boot-architecture@lists.linaro.org Subject: [edk2] [PATCH] MdeModulePkg: fix compilation errors From: Leif Lindholm This patch fixes a minor error that prevents the native ARM compiler from building the code. Signed-off-by: Leif Lindholm --- .../Universal/SetupBrowserDxe/Expression.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 1.7.9.5 ------------------------------------------------------------------------------ This SF.net email is sponsored by Windows: Build for Windows Store. http://p.sf.net/sfu/windows-dev2dev diff --git a/MdeModulePkg/Universal/SetupBrowserDxe/Expression.c b/MdeModulePkg/Universal/SetupBrowserDxe/Expression.c index cd29e29..29de503 100644 --- a/MdeModulePkg/Universal/SetupBrowserDxe/Expression.c +++ b/MdeModulePkg/Universal/SetupBrowserDxe/Expression.c @@ -1511,7 +1511,7 @@ IfrMid ( Result->BufferLen = (UINT16)((BufferLen - Base) < Length ? (BufferLen - Base) : Length); Result->Buffer = AllocateZeroPool (Result->BufferLen); ASSERT (Result->Buffer != NULL); - CopyMem (Result->Buffer, &Value[2].Buffer[Base], Result->BufferLen); + CopyMem (Result->Buffer, &Buffer[Base], Result->BufferLen); } FreePool (Value[2].Buffer);